mirror of
https://github.com/MariaDB/server.git
synced 2025-07-05 12:42:17 +03:00
BUG#49978: Replication tests don't clean up replication state at the end
Major replication test framework cleanup. This does the following: - Ensure that all tests clean up the replication state when they finish, by making check-testcase check the output of SHOW SLAVE STATUS. This implies: - Slave must not be running after test finished. This is good because it removes the risk for sporadic errors in subsequent tests when a test forgets to sync correctly. - Slave SQL and IO errors must be cleared when test ends. This is good because we will notice if a test gets an unexpected error in the slave threads near the end. - We no longer have to clean up before a test starts. - Ensure that all tests that wait for an error in one of the slave threads waits for a specific error. It is no longer possible to source wait_for_slave_[sql|io]_to_stop.inc when there is an error in one of the slave threads. This is good because: - If a test expects an error but there is a bug that causes another error to happen, or if it stops the slave thread without an error, then we will notice. - When developing tests, wait_for_*_to_[start|stop].inc will fail immediately if there is an error in the relevant slave thread. Before this patch, we had to wait for the timeout. - Remove duplicated and repeated code for setting up unusual replication topologies. Now, there is a single file that is capable of setting up arbitrary topologies (include/rpl_init.inc, but include/master-slave.inc is still available for the most common topology). Tests can now end with include/rpl_end.inc, which will clean up correctly no matter what topology is used. The topology can be changed with include/rpl_change_topology.inc. - Improved debug information when tests fail. This includes: - debug info is printed on all servers configured by include/rpl_init.inc - User can set $rpl_debug=1, which makes auxiliary replication files print relevant debug info. - Improved documentation for all auxiliary replication files. Now they describe purpose, usage, parameters, and side effects. - Many small code cleanups: - Made have_innodb.inc output a sensible error message. - Moved contents of rpl000017-slave.sh into rpl000017.test - Added mysqltest variables that expose the current state of disable_warnings/enable_warnings and friends. - Too many to list here: see per-file comments for details.
This commit is contained in:
50
mysql-test/include/sync_slave_sql_with_io.inc
Normal file
50
mysql-test/include/sync_slave_sql_with_io.inc
Normal file
@ -0,0 +1,50 @@
|
||||
# ==== Purpose ====
|
||||
#
|
||||
# Sync the slave SQL thread with the IO thread.
|
||||
#
|
||||
# ==== Usage ====
|
||||
#
|
||||
# [--let $slave_timeout= NUMBER]
|
||||
# [--let $rpl_debug= 1]
|
||||
# --source include/sync_slave_sql_with_io.inc
|
||||
#
|
||||
# Parameters:
|
||||
# $slave_timeout
|
||||
# By default, the synchronization timeouts after 300 seconds. If
|
||||
# $slave_timeout is set, the synchronization timeouts after
|
||||
# $slave_timeout seconds.
|
||||
#
|
||||
# $rpl_debug
|
||||
# See include/rpl_init.inc
|
||||
|
||||
|
||||
--let $include_filename= sync_slave_sql_with_io.inc
|
||||
--source include/begin_include_file.inc
|
||||
|
||||
|
||||
let $_slave_timeout= $slave_timeout;
|
||||
if (!$_slave_timeout)
|
||||
{
|
||||
let $_slave_timeout= 300;
|
||||
}
|
||||
|
||||
--let $_master_log_file= query_get_value(SHOW SLAVE STATUS, Master_Log_File, 1)
|
||||
--let $_master_log_pos= query_get_value(SHOW SLAVE STATUS, Read_Master_Log_Pos, 1)
|
||||
|
||||
if ($rpl_debug)
|
||||
{
|
||||
--echo Master_Log_File='$_master_log_file' Read_Master_Log_Pos='$_master_log_pos' \$slave_timeout='$_slave_timeout'
|
||||
}
|
||||
|
||||
--let $_sync_slave_sql_with_io_errno= `SELECT MASTER_POS_WAIT('$_master_log_file', $_master_log_pos, $_slave_timeout)`
|
||||
if (`SELECT IFNULL($_sync_slave_sql_with_io_errno, -1) < 0`)
|
||||
{
|
||||
--echo #### Failed to sync slave SQL thread with slave IO thread. ####
|
||||
--echo MASTER_POS_WAIT('$_master_log_file', $_master_log_pos, $_slave_timeout) returned $_sync_slave_sql_with_io_errno
|
||||
--source include/show_rpl_debug_info.inc
|
||||
--die Failed to sync slave SQL thread with slave IO thread.
|
||||
}
|
||||
|
||||
|
||||
--let $include_filename= sync_slave_sql_with_io.inc
|
||||
--source include/end_include_file.inc
|
Reference in New Issue
Block a user