mirror of
https://github.com/MariaDB/server.git
synced 2025-08-31 22:22:30 +03:00
BUG#49978: Replication tests don't clean up replication state at the end
Major replication test framework cleanup. This does the following: - Ensure that all tests clean up the replication state when they finish, by making check-testcase check the output of SHOW SLAVE STATUS. This implies: - Slave must not be running after test finished. This is good because it removes the risk for sporadic errors in subsequent tests when a test forgets to sync correctly. - Slave SQL and IO errors must be cleared when test ends. This is good because we will notice if a test gets an unexpected error in the slave threads near the end. - We no longer have to clean up before a test starts. - Ensure that all tests that wait for an error in one of the slave threads waits for a specific error. It is no longer possible to source wait_for_slave_[sql|io]_to_stop.inc when there is an error in one of the slave threads. This is good because: - If a test expects an error but there is a bug that causes another error to happen, or if it stops the slave thread without an error, then we will notice. - When developing tests, wait_for_*_to_[start|stop].inc will fail immediately if there is an error in the relevant slave thread. Before this patch, we had to wait for the timeout. - Remove duplicated and repeated code for setting up unusual replication topologies. Now, there is a single file that is capable of setting up arbitrary topologies (include/rpl_init.inc, but include/master-slave.inc is still available for the most common topology). Tests can now end with include/rpl_end.inc, which will clean up correctly no matter what topology is used. The topology can be changed with include/rpl_change_topology.inc. - Improved debug information when tests fail. This includes: - debug info is printed on all servers configured by include/rpl_init.inc - User can set $rpl_debug=1, which makes auxiliary replication files print relevant debug info. - Improved documentation for all auxiliary replication files. Now they describe purpose, usage, parameters, and side effects. - Many small code cleanups: - Made have_innodb.inc output a sensible error message. - Moved contents of rpl000017-slave.sh into rpl000017.test - Added mysqltest variables that expose the current state of disable_warnings/enable_warnings and friends. - Too many to list here: see per-file comments for details.
This commit is contained in:
47
mysql-test/include/rpl_connection.inc
Normal file
47
mysql-test/include/rpl_connection.inc
Normal file
@@ -0,0 +1,47 @@
|
||||
# ==== Purpose ====
|
||||
#
|
||||
# The same as 'connection $rpl_connection_name', but it can also
|
||||
# prints the connection name. The connection is printed if $rpl_debug
|
||||
# is set, or if rpl_connection.inc is not called between two
|
||||
# invocations of begin_include_file.inc/end_include_file.inc.
|
||||
# Otherwise the connection name is not printed.
|
||||
#
|
||||
#
|
||||
# ==== Usage ====
|
||||
#
|
||||
# --let $rpl_connection_name= master
|
||||
# [--let $rpl_debug= 1]
|
||||
# --source include/rpl_connection.inc
|
||||
#
|
||||
# Parameters:
|
||||
# $rpl_connection_name
|
||||
# Name of the connection to connect to.
|
||||
#
|
||||
# $rpl_debug
|
||||
# By default, the connection name is printed only when this file
|
||||
# is sourced from a top-level test script. If $rpl_debug is set,
|
||||
# the connection name is also printed whenever auxiliary files
|
||||
# like rpl_init.inc change connection.
|
||||
|
||||
|
||||
if (!$rpl_connection_name)
|
||||
{
|
||||
--die ERROR IN TEST: you must set $rpl_connection_name before sourcing rpl_connection.inc
|
||||
}
|
||||
|
||||
# This is the same as "if (!$_rpl_include_file_depth || $rpl_debug)",
|
||||
# but the mysqltest language doesn't have boolean operations.
|
||||
|
||||
if (!$_include_file_depth)
|
||||
{
|
||||
--echo [connection $rpl_connection_name]
|
||||
}
|
||||
if ($_include_file_depth)
|
||||
{
|
||||
if ($rpl_debug)
|
||||
{
|
||||
--echo [connection $rpl_connection_name]
|
||||
}
|
||||
}
|
||||
--connection $rpl_connection_name
|
||||
--let $rpl_connection_name=
|
Reference in New Issue
Block a user