From 0993d4b4f5e5710022c5c0262b803617f8bf28c8 Mon Sep 17 00:00:00 2001 From: Olivier Bertrand Date: Wed, 14 Aug 2013 16:07:32 +0200 Subject: [PATCH] - Change the Blanks parameter from true to false in catalog getting information function. This solve the problem of uninitialised zone that was detected by valgrind. modified: storage/connect/myconn.cpp storage/connect/odbconn.cpp storage/connect/tabfmt.cpp storage/connect/tabutil.cpp storage/connect/tabwmi.cpp --- storage/connect/myconn.cpp | 2 +- storage/connect/odbconn.cpp | 12 ++++++------ storage/connect/tabfmt.cpp | 2 +- storage/connect/tabutil.cpp | 2 +- storage/connect/tabwmi.cpp | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/storage/connect/myconn.cpp b/storage/connect/myconn.cpp index 4cad68a9a1e..ea0425d3fae 100644 --- a/storage/connect/myconn.cpp +++ b/storage/connect/myconn.cpp @@ -134,7 +134,7 @@ PQRYRES MyColumns(PGLOBAL g, const char *host, const char *db, /* Allocate the structures used to refer to the result set. */ /**********************************************************************/ qrp = PlgAllocResult(g, ncol, n, IDS_COLUMNS + 3, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); // Some columns must be renamed for (i = 0, crp = qrp->Colresp; crp; crp = crp->Next) diff --git a/storage/connect/odbconn.cpp b/storage/connect/odbconn.cpp index 4d16286ad76..4feaafa34a9 100644 --- a/storage/connect/odbconn.cpp +++ b/storage/connect/odbconn.cpp @@ -280,7 +280,7 @@ PQRYRES ODBCColumns(PGLOBAL g, char *dsn, char *table, /* Allocate the structures used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_COLUMNS, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); if (info) // Info table return qrp; @@ -422,7 +422,7 @@ PQRYRES ODBCDataSources(PGLOBAL g, bool info) /* Allocate the structures used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_DSRC, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); /************************************************************************/ /* Now get the results into blocks. */ @@ -467,7 +467,7 @@ PQRYRES ODBCDrivers(PGLOBAL g, bool info) /* Allocate the structures used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_DRIVER, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); /************************************************************************/ /* Now get the results into blocks. */ @@ -532,7 +532,7 @@ PQRYRES ODBCTables(PGLOBAL g, char *dsn, char *tabpat, bool info) /* Allocate the structures used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_TABLES, buftyp, - fldtyp, length, true, true); + fldtyp, length, false, true); if (info) return qrp; @@ -616,7 +616,7 @@ PQRYRES ODBCPrimaryKeys(PGLOBAL g, ODBConn *op, char *dsn, char *table) /* Allocate the structure used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_PKEY, - buftyp, NULL, length, true, true); + buftyp, NULL, length, false, true); if (trace) htrc("Getting pkey results ncol=%d\n", qrp->Nbcol); @@ -698,7 +698,7 @@ PQRYRES ODBCStatistics(PGLOBAL g, ODBConn *op, char *dsn, char *pat, /* Allocate the structure used to refer to the result set. */ /************************************************************************/ qrp = PlgAllocResult(g, ncol, maxres, IDS_STAT, - buftyp, NULL, length, true, true); + buftyp, NULL, length, false, true); if (trace) htrc("Getting stat results ncol=%d\n", qrp->Nbcol); diff --git a/storage/connect/tabfmt.cpp b/storage/connect/tabfmt.cpp index 860a1304a14..b538383b766 100644 --- a/storage/connect/tabfmt.cpp +++ b/storage/connect/tabfmt.cpp @@ -339,7 +339,7 @@ PQRYRES CSVColumns(PGLOBAL g, const char *fn, char sep, char q, /* Allocate the structures used to refer to the result set. */ /*********************************************************************/ qrp = PlgAllocResult(g, ncol, imax, IDS_COLUMNS + 3, - buftyp, fldtyp, length, true, false); + buftyp, fldtyp, length, false, false); qrp->Nblin = imax; if (info) diff --git a/storage/connect/tabutil.cpp b/storage/connect/tabutil.cpp index 151b527507a..110c53c33b2 100644 --- a/storage/connect/tabutil.cpp +++ b/storage/connect/tabutil.cpp @@ -159,7 +159,7 @@ PQRYRES TabColumns(PGLOBAL g, THD *thd, const char *db, /* Allocate the structures used to refer to the result set. */ /**********************************************************************/ qrp = PlgAllocResult(g, ncol, n, IDS_COLUMNS + 3, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); // Some columns must be renamed for (i = 0, crp = qrp->Colresp; crp; crp = crp->Next) diff --git a/storage/connect/tabwmi.cpp b/storage/connect/tabwmi.cpp index dbd4330a2f9..1c626a06256 100644 --- a/storage/connect/tabwmi.cpp +++ b/storage/connect/tabwmi.cpp @@ -211,7 +211,7 @@ PQRYRES WMIColumns(PGLOBAL g, char *nsp, char *cls, bool info) /* Allocate the structures used to refer to the result set. */ /*********************************************************************/ qrp = PlgAllocResult(g, ncol, n, IDS_COLUMNS + 3, - buftyp, fldtyp, length, true, true); + buftyp, fldtyp, length, false, true); if (info) return qrp;