mirror of
https://github.com/MariaDB/server.git
synced 2025-12-24 11:21:21 +03:00
Review of new pushed code (Indentation fixes and simple optimizations)
Use 'mysqltest' as test database instead of test_$1 or test1,test2 to not accidently delete an important database Safety fix for mailformed MERGE files Build-tools/mysql-copyright: Print correct file name in case of errors Fixed indentation include/config-win.h: Removed unnecessary #ifdef myisammrg/myrg_open.c: Don't give a core if merge file contains INSERT_METHOD first (not legal but better safe than sorry) Don't set struct variables to zero that are already zero Indentation fixes mysql-test/r/create.result: Use 'mysqltest' as test database mysql-test/r/ndb_basic.result: Use 'mysqltest' as test database mysql-test/r/ndb_blob.result: Use 'mysqltest' as test database mysql-test/r/ndb_transaction.result: Use 'mysqltest' as test database mysql-test/r/ps_1general.result: Use 'mysqltest' as test database mysql-test/r/rpl_charset.result: Use 'mysqltest' as test database mysql-test/r/rpl_delete_all.result: Use 'mysqltest' as test database mysql-test/r/show_check.result: Use 'mysqltest' as test database mysql-test/t/create.test: Use 'mysqltest' as test database mysql-test/t/ndb_basic.test: Use 'mysqltest' as test database mysql-test/t/ndb_blob.test: Use 'mysqltest' as test database mysql-test/t/ndb_transaction.test: Use 'mysqltest' as test database mysql-test/t/ps_1general.test: Use 'mysqltest' as test database mysql-test/t/rpl_charset.test: Use 'mysqltest' as test database mysql-test/t/rpl_delete_all.test: Use 'mysqltest' as test database mysql-test/t/show_check.test: Use 'mysqltest' as test database sql/field.h: Mark functions that should be deleted as soon as we have a new prototype for store(longlong) sql/lock.cc: Indentation fix sql/sql_base.cc: Better comment. Break find_item_in_list in case of perfect match sql/sql_prepare.cc: Simple optimization sql/sql_select.cc: Portability fix
This commit is contained in:
@@ -4,7 +4,7 @@
|
||||
|
||||
--disable_warnings
|
||||
drop table if exists t1,t2,t3;
|
||||
drop database if exists test_$1;
|
||||
drop database if exists mysqltest;
|
||||
--enable_warnings
|
||||
|
||||
create table t1 (b char(0));
|
||||
@@ -69,14 +69,14 @@ drop table 1ea10;
|
||||
create table t1 (t1.index int);
|
||||
drop table t1;
|
||||
# Test that we get warning for this
|
||||
drop database if exists test_$1;
|
||||
create database test_$1;
|
||||
create table test_$1.$test1 (a$1 int, $b int, c$ int);
|
||||
insert into test_$1.$test1 values (1,2,3);
|
||||
select a$1, $b, c$ from test_$1.$test1;
|
||||
create table test_$1.test2$ (a int);
|
||||
drop table test_$1.test2$;
|
||||
drop database test_$1;
|
||||
drop database if exists mysqltest;
|
||||
create database mysqltest;
|
||||
create table mysqltest.$test1 (a$1 int, $b int, c$ int);
|
||||
insert into mysqltest.$test1 values (1,2,3);
|
||||
select a$1, $b, c$ from mysqltest.$test1;
|
||||
create table mysqltest.test2$ (a int);
|
||||
drop table mysqltest.test2$;
|
||||
drop database mysqltest;
|
||||
|
||||
--error 1103
|
||||
create table `` (a int);
|
||||
@@ -281,16 +281,16 @@ drop table t3;
|
||||
show create table t3;
|
||||
select * from t3;
|
||||
drop table t2, t3;
|
||||
create database test_$1;
|
||||
create table test_$1.t3 like t1;
|
||||
create temporary table t3 like test_$1.t3;
|
||||
create database mysqltest;
|
||||
create table mysqltest.t3 like t1;
|
||||
create temporary table t3 like mysqltest.t3;
|
||||
show create table t3;
|
||||
create table t2 like t3;
|
||||
show create table t2;
|
||||
select * from t2;
|
||||
create table t3 like t1;
|
||||
--error 1050
|
||||
create table t3 like test_$1.t3;
|
||||
create table t3 like mysqltest.t3;
|
||||
--error 1044,1
|
||||
create table non_existing_database.t1 like t1;
|
||||
--error 1051
|
||||
@@ -301,7 +301,7 @@ create temporary table t3 like t1;
|
||||
create table t3 like `a/a`;
|
||||
drop table t1, t2, t3;
|
||||
drop table t3;
|
||||
drop database test_$1;
|
||||
drop database mysqltest;
|
||||
|
||||
#
|
||||
# Test default table type
|
||||
@@ -393,10 +393,10 @@ drop table t1, t2, t3;
|
||||
# Bug #1209
|
||||
#
|
||||
|
||||
create database test_$1;
|
||||
use test_$1;
|
||||
create database mysqltest;
|
||||
use mysqltest;
|
||||
select database();
|
||||
drop database test_$1;
|
||||
drop database mysqltest;
|
||||
select database();
|
||||
|
||||
# Connect without a database
|
||||
|
||||
Reference in New Issue
Block a user