database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-9281 - Debian: the Lintian complains about "shlib-calls-exit" in handlersocket.so

Browse Source 
MDEV-9278 - Debian: the Lintian complains about "shlib-calls-exit" in ha_spider.so

Handlersocket handles errors in a way that it aborts program execution. In most
cases it is done via abort(). One exception was host/service resolution failure,
which was aborted with exit().

As a workaround replaced this exit() with abort() for symmetry with other error
handling.
This commit is contained in:
Sergey Vojtovich
2016-04-20 18:20:31 +04:00
parent f8adeccd78
commit 072ca71d26
7 changed files with 5 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugin/handler_socket/libhsclient/fatal.cpp
View File

@@ -17,14 +17,6 @@ namespace dena {
const int opt_syslog = LOG_ERR | LOG_PID | LOG_CONS;
void
fatal_exit(const std::string& message)
{
fprintf(stderr, "FATAL_EXIT: %s\n", message.c_str());
syslog(opt_syslog, "FATAL_EXIT: %s", message.c_str());
_exit(1);
}
void
fatal_abort(const std::string& message)
{

1
plugin/handler_socket/libhsclient/fatal.hpp
View File

@@ -13,7 +13,6 @@
namespace dena {
void fatal_exit(const std::string& message);
void fatal_abort(const std::string& message);
};

2
plugin/handler_socket/libhsclient/socket.cpp
View File

@@ -43,7 +43,7 @@ socket_args::set(const config& conf)
} else {
const char *nd = node.empty() ? 0 : node.c_str();
if (resolve(nd, port.c_str()) != 0) {
fatal_exit("getaddrinfo failed: " + node + ":" + port);
fatal_abort("getaddrinfo failed: " + node + ":" + port);
}
}
}