database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-28124 Server crashes in Explain_aggr_filesort::print_json_members

Browse Source 
SHOW EXPLAIN/ANALYZE FORMAT=JSON tries to access items that have already been
freed by a call to free_items() during THD::cleanup_after_query().
The solution is to disallow APC calls including SHOW EXPLAIN/ANALYZE
just before the call to free_items().
This commit is contained in:
Oleg Smirnov
2022-03-27 11:58:27 +07:00
committed by Sergei Petrunia
parent a0475cb9ca
commit 02c3babdec
22 changed files with 303 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sql/sql_explain.cc
View File

@@ -159,6 +159,16 @@ void Explain_query::query_plan_ready()
apc_enabled= true;
}
void Explain_query::notify_item_objects_about_to_be_freed()
{
if (apc_enabled)
{
thd->apc_target.disable();
apc_enabled= false;
}
}
/*
Send EXPLAIN output to the client.
*/