database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-8115 mysql_upgrade crashes the server with REPAIR VIEW

Browse Source 
on REPAIR don't do table-specific stuff for views
(because even if the view has a temp table opened for it,
it's not opened all the way down the engine. In particular,
Aria crashes in maria_status() because MARIA_HA* info - that is
table->table->file->file - is NULL)
This commit is contained in:
Sergei Golubchik
2015-05-07 22:18:34 +02:00
parent 8350ea0514
commit 0014bdc7ee
3 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mysql-test/r/repair.result
View File

@ -207,3 +207,10 @@ check table t1;
Table Op Msg_type Msg_text Table Op Msg_type Msg_text
test.t1 check status OK test.t1 check status OK
drop table t1; drop table t1;
create table t1 (a blob);
create view v1 as select * from t1;
repair view v1;
Table Op Msg_type Msg_text
test.v1 repair status OK
drop view v1;
drop table t1;

9
mysql-test/t/repair.test
View File

@ -208,3 +208,12 @@ repair table t1 use_frm;
select count(*) from t1; select count(*) from t1;
check table t1; check table t1;
drop table t1; drop table t1;
#
# MDEV-8115 mysql_upgrade crashes the server with REPAIR VIEW
#
create table t1 (a blob);
create view v1 as select * from t1;
repair view v1;
drop view v1;
drop table t1;

2
sql/sql_admin.cc
View File

@ -901,7 +901,7 @@ send_result_message:
break; break;
} }
} }
if (table->table) if (table->table && !table->view)
{ {
if (table->table->s->tmp_table) if (table->table->s->tmp_table)
{ {