SET_CLIENT_ERROR and return 1;
because jumping to the error label is not viable in this case as pos is
not initialized and it could raise more errors, this way we still handle
the error while not clashing with the original error handling
implementation
at 252 if the strdup at 248 fails and thus returns NULL by
setting a client error signalling that the client ran out of
memory for easier communication of what exactly failed during the
loading of the plugins and why. Returning from the function just after
rpl->filename being NULL by setting an error signalling that we ran out
of memory to ease the debugging of the mariadb_rpl_options function and make
it clearer if it ever fails because of this. Also added va_end in this case to
avoid the va_list (ap) leaking when we return from this function and
then returning 1 from the fucntion.
Windows Server 2022 uses version number 10.0.20348, which is less than 10.0.22000.
Therefore, instead of checking for build numbers >= 22000 (which would exclude Server 2022),
we must check for build numbers >= 20348 to correctly include both Windows Server 2022
and Windows 11.
This is safe because TLSv1.3 was first supported in:
- Windows 11 (starting with build 22000)
- Windows Server 2022 (starting with build 20348)
Earlier versions did not support TLSv1.3:
- Windows 10 (up to build 19044)
- Windows Server 2019 (latest build 17763)
Its possible for the net extensions allocation to
succeed but the other extensions to fail to allocate.
In this later case free the net alternatives explicitly
if we where going to free the entire allocation.
Fixes SIGILL in MariaDB Server "main.non_blocking_api" test case on
aarch64 processors supporting Branch Target Identification (BTI).
Branch Target Identification is a new aarch64 feature that prevents
jumping to arbitrary code locations that are not properly marked as
branch targets.
The "-mbranch-protection=standard" flag to GCC will enable code
generation using BTI. This is backwards compatible as the added
instructions are no-ops on older processors.
One example of where both "-mbranch-protection=standard" is enabled and
hardware supports it is with Amazon Linux 2023 and Graviton 4.
The symptom is the following mtr main.non_blocking_api failure:
mysqltest got signal 4
read_command_buf (0xaaaae6ae27a8): connect
(con_nonblock,localhost,root,,test)
conn->name (0xaaaae6b0c0b8):
Attempting backtrace...
stack_bottom = 0x0 thread_stack 0x3c000
/usr/bin/mariadb-test(my_print_stacktrace+0x48)[0xaaaab6934088]
bits/stdio2.h:79(signal_handler)[0xaaaab68f41a0]
addr2line: 'linux-vdso.so.1': No such file
linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffffa22bc830]
/usr/bin/mariadb-test(my_context_spawn+0x74)[0xaaaab6914d84]
With GDB giving the information that SIGILL was on the perfectly legal
'mov' instruction:
Program received signal SIGILL, Illegal instruction.
0x0000aaaaaab44d84 in my_context_spawn (c=0xaaaaab07ada8, f=0xfffff7fed240, d=0x0) at
mariadb1011-10.11.11-1.amzn2023.0.1.aarch64/libmariadb/libmariadb/ma_context.c:674
674 __asm__ __volatile__
(gdb) x/i$pc
=> 0xaaaaaab44d84 <my_context_spawn(my_context*, void (*)(void*),
void*)+116>: mov w0, #0x1 // #1
The call sequence to get to this point is as follows:
Breakpoint 1, my_context_spawn (c=0xaaaaab07ada8, f=0xaaaaaab38024
<mysql_real_connect_start_internal(void*)>, d=0xffffffffc648) at
libmariadb/ma_context.c:661
661 register void *stack asm("x13") = c->stack_top;
(gdb) c
Continuing.
Breakpoint 2, my_context_yield (c=0xaaaaab07ada8) at
libmariadb/ma_context.c:843
843 register const uint64_t *save asm("x19") = &c->save[0];
Continuing from here leads to the SIGILL above.
The branch that ends up causing the SIGILL is the "br x11" instruction
in my_context_yield(). This is due to the branch being to a location
that is not marked as a branch target.
The fix is to ensure that these locations in the my_context aarch64
assembler are marked with "bti j" instructions so that the locations
that will be 'br'ed to are valid to be 'br'ed to.
Since older compilers don't know about the instruction, we need an ifdef
to define a string that has the raw opcode in it.
Fixes: d2285fb830
If we are in pipeline mode (mariadb_stmt_execute_direct)
we don't need to return an error, if there is no or no more
data available: If the size of the buffer is a multiple
of 8192 packets might be already written and the buffer was
resetted afterwards.
SSL connection on Windows used retry logic initially, to "fix" MDEV-13492
This actual bug is now understood, and was fixed a while ago.
Remove the workaround now.
Some research show that X18 is mentioned as a platform-reserved
register on most non-linux platforms, including MacOS, Windows, and
FreeBSD. So only put it in the clobber list in Linux.
Note that the ma_context.c code does not itself use the X18 register
in any way. On platforms where X18 is reserved, the co-routine code
will preserve it. On platforms where co-routine code can modify X18,
it does not need to be preserved. Putting X18 in the clobber list is
only to avoid GCC itself generating code that requires that X18 is
preserved.
Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
X18 is a platform-reserved register on Android, not a callee-save
register. So it will not be touched by the spawned/resumed co-routine
and must not be included in the GCC asm clobber list on this platform.
Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
Fixed different behavior of pvio_is_alive (which was first used
with fix of CONC-589). Both for sockets and named pipe the function
now returns true if the connection is alive, otherwise false.
Increase the default stack size for co-routines to 256 kByte. It was 60
kByte, which was too small for glibc getaddrinfo() when using mdns.
Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
Also CONC-754.
Depending on compiler options (eg. -fno-dwarf2-cfi-asm), the compiler may
not output .cfi_startproc / .cfi_endproc in generated assember, and this
causes a build error on the .cfi_escape directive put in my_context_spawn()
on systems with DWARF support.
Fix by using the proper preprocessor macro __GCC_HAVE_DWARF2_CFI_ASM to test
for .cfi_escape support, rather than crafted check for various compiler
brands and versions. Though this macro is only available in clang since
version 13.0.0, so unconditionally include the .cfi_escape in earlier clang
versions.
Thanks to Rainer Orth for the suggested fix.
Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
If automatic reconnect is enabled (MYSQL_OPT_RECONNECT) it is
mandatory to check if the connection/socket is still alive before
sending a command to the server (unless the command is COM_QUIT).
Since Item_result enumerations are also used by MariaDB server, we
moved them back to mariadb_com.h.
Item_result is not used in Connector/C 3.3 and above for replication
api.
- Added TLSv1.3 ciphers to cipher map.
- Fixed retrieval of cipher suite: Since gnutls_cipher_suite_get_name
supports only TLSv1.2 (and lower) cipher suites, we have to call
gnutls_ciphersuite_get() (requires GnuTLS 3.7.4 or newer).
