1
0
mirror of https://github.com/mariadb-corporation/mariadb-connector-c.git synced 2025-08-08 14:02:17 +03:00

Error message fix:

Since TLS errors might happen not only when connecting and SSL protocol
is not longer used, errormessage for CR_SSL_CONNECTION_ERROR was replaced
by TLS/SSL error.
This commit is contained in:
Georg Richter
2022-07-27 14:52:20 +02:00
parent b9811b7c6d
commit 12722e3131
4 changed files with 5 additions and 6 deletions

View File

@@ -108,7 +108,7 @@ const char *client_errors[]=
/* 2023 */ "", /* 2023 */ "",
/* 2024 */ "", /* 2024 */ "",
/* 2025 */ "", /* 2025 */ "",
/* 2026 */ "SSL connection error: %-.100s", /* 2026 */ "TLS/SSL error1: %-.100s",
/* 2027 */ "received malformed packet", /* 2027 */ "received malformed packet",
/* 2028 */ "", /* 2028 */ "",
/* 2029 */ "", /* 2029 */ "",

View File

@@ -889,7 +889,7 @@ static void ma_tls_set_error(MYSQL *mysql, void *ssl, int ssl_errno)
alert_name= gnutls_alert_get_name(alert_desc); alert_name= gnutls_alert_get_name(alert_desc);
snprintf(ssl_error, MAX_SSL_ERR_LEN, "fatal alert received: %s", snprintf(ssl_error, MAX_SSL_ERR_LEN, "fatal alert received: %s",
alert_name); alert_name);
pvio->set_error(mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, ssl_error); pvio->set_error(mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, 0, ssl_error);
return; return;
} }

View File

@@ -52,7 +52,7 @@ void ma_schannel_set_sec_error(MARIADB_PVIO* pvio, DWORD ErrorNo)
void ma_schannel_set_win_error(MARIADB_PVIO *pvio, DWORD ErrorNo) void ma_schannel_set_win_error(MARIADB_PVIO *pvio, DWORD ErrorNo)
{ {
char buffer[256]; char buffer[256];
ma_format_win32_error(buffer, sizeof(buffer), ErrorNo, "SSL connection error: "); ma_format_win32_error(buffer, sizeof(buffer), ErrorNo, "TLS/SSL error: ");
pvio->set_error(pvio->mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, buffer); pvio->set_error(pvio->mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, buffer);
return; return;
} }
@@ -526,8 +526,7 @@ my_bool ma_schannel_verify_certs(MARIADB_TLS *ctls, BOOL verify_server_name)
end: end:
if (!ret) if (!ret)
{ {
pvio->set_error(mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, pvio->set_error(mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, 0, errmsg);
"SSL connection error: %s", errmsg);
} }
if (pServerCert) if (pServerCert)
CertFreeCertificateContext(pServerCert); CertFreeCertificateContext(pServerCert);

View File

@@ -225,7 +225,7 @@ static int ma_tls_set_client_certs(MARIADB_TLS *ctls,const CERT_CONTEXT **cert_c
*cert_ctx = schannel_create_cert_context(certfile, keyfile, errmsg, sizeof(errmsg)); *cert_ctx = schannel_create_cert_context(certfile, keyfile, errmsg, sizeof(errmsg));
if (!*cert_ctx) if (!*cert_ctx)
{ {
pvio->set_error(pvio->mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, "SSL connection error: %s", errmsg); pvio->set_error(pvio->mysql, CR_SSL_CONNECTION_ERROR, SQLSTATE_UNKNOWN, 0, errmsg);
return 1; return 1;
} }