You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-08-10 01:22:48 +03:00
b53c231ca6
This patch improves handling of NULLs in textual fields in ColumnStore. Previously empty strings were considered NULLs and it could be a problem if data scheme allows for empty strings. It was also one of major reasons of behavior difference between ColumnStore and other engines in MariaDB family. Also, this patch fixes some other bugs and incorrect behavior, for example, incorrect comparison for "column <= ''" which evaluates to constant True for all purposes before this patch.
121 lines
2.7 KiB
C++
121 lines
2.7 KiB
C++
/* Copyright (C) 2020 MariaDB Corporation.
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; version 2 of
|
|
the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#pragma once
|
|
|
|
#include <string>
|
|
#include <string.h>
|
|
#include <execinfo.h>
|
|
#include "exceptclasses.h"
|
|
|
|
namespace utils
|
|
{
|
|
class ConstString
|
|
{
|
|
protected:
|
|
const char* mStr; // it can be NULL now.
|
|
size_t mLength;
|
|
|
|
public:
|
|
ConstString(const char* str, size_t length) : mStr(str), mLength(length)
|
|
{
|
|
idbassert(mStr || mLength == 0); // nullptr mStr should have zero length.
|
|
}
|
|
explicit ConstString(const std::string& str) : mStr(str.data()), mLength(str.length())
|
|
{
|
|
}
|
|
template <typename T>
|
|
ConstString(const T* value, T nullValue, int colWidth)
|
|
{
|
|
if (*value == nullValue)
|
|
{
|
|
mStr = nullptr;
|
|
mLength = 0;
|
|
}
|
|
else
|
|
{
|
|
mStr = reinterpret_cast<const char*>(value);
|
|
mLength = colWidth;
|
|
}
|
|
}
|
|
const char* str() const
|
|
{
|
|
return mStr;
|
|
}
|
|
const char* end() const
|
|
{
|
|
// end() should be computed for non-nullptr mStrs, otherwise it is undefined behavior.
|
|
if (!mStr)
|
|
{
|
|
return nullptr;
|
|
}
|
|
return mStr + mLength;
|
|
}
|
|
size_t length() const
|
|
{
|
|
return mLength;
|
|
}
|
|
std::string toString() const
|
|
{
|
|
idbassert(mStr);
|
|
return std::string(mStr, mLength);
|
|
}
|
|
bool eq(char ch) const
|
|
{
|
|
return mLength == 1 && mStr[0] == ch;
|
|
}
|
|
bool eq(const ConstString& rhs) const
|
|
{
|
|
if (!mStr)
|
|
{
|
|
return mStr == rhs.mStr;
|
|
}
|
|
return mLength == rhs.mLength && !memcmp(mStr, rhs.mStr, mLength);
|
|
}
|
|
ConstString& rtrimZero()
|
|
{
|
|
for (; mLength && mStr[mLength - 1] == '\0'; mLength--)
|
|
{
|
|
}
|
|
return *this;
|
|
}
|
|
ConstString& rtrimSpaces()
|
|
{
|
|
for (; mLength && mStr[mLength - 1] == ' '; --mLength)
|
|
{
|
|
}
|
|
return *this;
|
|
}
|
|
void bin2hex(char* o)
|
|
{
|
|
static const char hexdig[] = {'0', '1', '2', '3', '4', '5', '6', '7',
|
|
'8', '9', 'A', 'B', 'C', 'D', 'E', 'F'};
|
|
const char* e = end();
|
|
for (const char* s = mStr; s < e; s++)
|
|
{
|
|
*o++ = hexdig[*s >> 4];
|
|
*o++ = hexdig[*s & 0xf];
|
|
}
|
|
}
|
|
bool isNull() const
|
|
{
|
|
return mStr == nullptr;
|
|
}
|
|
};
|
|
|
|
} // namespace utils
|