You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-08-10 01:22:48 +03:00
A previous commit made posix::read changed return value from bool to int. However some callers still expected bool and compared a bool<0 which is always false.
88 lines
1.9 KiB
C++
88 lines
1.9 KiB
C++
/* Copyright (C) 2019 MariaDB Corporation
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; version 2 of
|
|
the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
|
|
#include "UnlinkTask.h"
|
|
#include <errno.h>
|
|
#include "messageFormat.h"
|
|
#include "SMLogging.h"
|
|
|
|
using namespace std;
|
|
|
|
namespace storagemanager
|
|
{
|
|
|
|
UnlinkTask::UnlinkTask(int sock, uint len) : PosixTask(sock, len)
|
|
{
|
|
}
|
|
|
|
UnlinkTask::~UnlinkTask()
|
|
{
|
|
}
|
|
|
|
#define check_error(msg, ret) \
|
|
if (success<0) \
|
|
{ \
|
|
handleError(msg, errno); \
|
|
return ret; \
|
|
}
|
|
|
|
|
|
bool UnlinkTask::run()
|
|
{
|
|
SMLogging* logger = SMLogging::get();
|
|
int success;
|
|
uint8_t buf[1024] = {0};
|
|
|
|
if (getLength() > 1023) {
|
|
handleError("UnlinkTask read", ENAMETOOLONG);
|
|
return true;
|
|
}
|
|
|
|
success = read(buf, getLength());
|
|
check_error("UnlinkTask read", false);
|
|
unlink_cmd *cmd = (unlink_cmd *) buf;
|
|
|
|
#ifdef SM_TRACE
|
|
logger->log(LOG_DEBUG,"unlink %s.",cmd->filename);
|
|
#endif
|
|
int err;
|
|
|
|
try
|
|
{
|
|
err = ioc->unlink(cmd->filename);
|
|
}
|
|
catch (exception &e)
|
|
{
|
|
logger->log(LOG_DEBUG, "UnlinkTask: caught '%s'", e.what());
|
|
errno = EIO;
|
|
err = -1;
|
|
}
|
|
|
|
if (err)
|
|
{
|
|
handleError("UnlinkTask unlink", errno);
|
|
return true;
|
|
}
|
|
|
|
sm_response *resp = (sm_response *) buf;
|
|
resp->returnCode = 0;
|
|
return write(*resp, 0);
|
|
}
|
|
|
|
}
|