You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-08-10 01:22:48 +03:00
3a730a4222
A previous commit made posix::read changed return value from bool to int. However some callers still expected bool and compared a bool<0 which is always false.
112 lines
2.9 KiB
C++
112 lines
2.9 KiB
C++
/* Copyright (C) 2019 MariaDB Corporation
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; version 2 of
|
|
the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
|
|
#include "ReadTask.h"
|
|
#include "messageFormat.h"
|
|
#include "SMLogging.h"
|
|
#include <errno.h>
|
|
|
|
using namespace std;
|
|
|
|
namespace storagemanager
|
|
{
|
|
|
|
ReadTask::ReadTask(int sock, uint len) : PosixTask(sock, len)
|
|
{
|
|
}
|
|
|
|
ReadTask::~ReadTask()
|
|
{
|
|
}
|
|
|
|
#define check_error(msg, ret) \
|
|
if (success<0) \
|
|
{ \
|
|
handleError(msg, errno); \
|
|
return ret; \
|
|
}
|
|
|
|
#define max(x, y) (x > y ? x : y)
|
|
|
|
bool ReadTask::run()
|
|
{
|
|
SMLogging* logger = SMLogging::get();
|
|
uint8_t buf[1024] = {0};
|
|
|
|
// get the parameters
|
|
if (getLength() > 1023) {
|
|
handleError("ReadTask read", EFAULT);
|
|
return true;
|
|
}
|
|
|
|
int success;
|
|
success = read(buf, getLength());
|
|
check_error("ReadTask read cmd", false);
|
|
read_cmd *cmd = (read_cmd *) buf;
|
|
|
|
#ifdef SM_TRACE
|
|
logger->log(LOG_DEBUG,"read %s count %i offset %i.",cmd->filename,cmd->count,cmd->offset);
|
|
#endif
|
|
|
|
// read from IOC, write to the socket
|
|
vector<uint8_t> outbuf;
|
|
if (cmd->count > (100 << 20))
|
|
cmd->count = (100 << 20); // cap a read request at 100MB
|
|
outbuf.resize(max(cmd->count, 4) + sizeof(sm_response));
|
|
sm_response *resp = (sm_response *) &outbuf[0];
|
|
|
|
resp->returnCode = 0;
|
|
uint payloadLen = 0;
|
|
|
|
// todo: do the reading and writing in chunks
|
|
// todo: need to make this use O_DIRECT on the IOC side
|
|
ssize_t err;
|
|
while ((uint) resp->returnCode < cmd->count)
|
|
{
|
|
try
|
|
{
|
|
err = ioc->read(cmd->filename, &resp->payload[resp->returnCode], cmd->offset + resp->returnCode,
|
|
cmd->count - resp->returnCode);
|
|
}
|
|
catch (exception &e)
|
|
{
|
|
logger->log(LOG_DEBUG, "ReadTask: caught '%s'", e.what());
|
|
errno = EIO;
|
|
err = -1;
|
|
}
|
|
if (err < 0) {
|
|
if (resp->returnCode == 0) {
|
|
resp->returnCode = err;
|
|
payloadLen = 4;
|
|
*((int32_t *) resp->payload) = errno;
|
|
}
|
|
break;
|
|
}
|
|
if (err == 0)
|
|
break;
|
|
resp->returnCode += err;
|
|
}
|
|
if (resp->returnCode >= 0)
|
|
payloadLen = resp->returnCode;
|
|
return write(*resp, payloadLen);
|
|
}
|
|
|
|
|
|
|
|
}
|