mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-04-23 07:05:36 +03:00
b53c231ca6
This patch improves handling of NULLs in textual fields in ColumnStore. Previously empty strings were considered NULLs and it could be a problem if data scheme allows for empty strings. It was also one of major reasons of behavior difference between ColumnStore and other engines in MariaDB family. Also, this patch fixes some other bugs and incorrect behavior, for example, incorrect comparison for "column <= ''" which evaluates to constant True for all purposes before this patch.
352 lines
11 KiB
C++
352 lines
11 KiB
C++
/* Copyright (C) 2014 InfiniDB, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU General Public License
|
|
as published by the Free Software Foundation; version 2 of
|
|
the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
/****************************************************************************
|
|
* $Id: func_timediff.cpp 3696 2013-04-05 18:07:21Z dhall $
|
|
*
|
|
*
|
|
****************************************************************************/
|
|
|
|
#include <algorithm>
|
|
#include <cstdlib>
|
|
#include <string>
|
|
#include <sstream>
|
|
using namespace std;
|
|
|
|
#include "functor_dtm.h"
|
|
#include "funchelpers.h"
|
|
#include "functioncolumn.h"
|
|
#include "rowgroup.h"
|
|
using namespace execplan;
|
|
|
|
#include "dataconvert.h"
|
|
|
|
#include "errorcodes.h"
|
|
#include "idberrorinfo.h"
|
|
#include "errorids.h"
|
|
using namespace logging;
|
|
|
|
namespace funcexp
|
|
{
|
|
namespace helpers
|
|
{
|
|
const string timediff(int64_t time1, int64_t time2, bool isDateTime)
|
|
{
|
|
long long seconds;
|
|
long long microseconds;
|
|
int l_sign = 1;
|
|
|
|
if ((time1 < 0 && time2 >= 0) || (time2 < 0 && time1 >= 0))
|
|
l_sign = -l_sign;
|
|
|
|
if (time1 > time2)
|
|
helpers::calc_time_diff(time1, time2, l_sign, &seconds, µseconds, isDateTime);
|
|
else
|
|
helpers::calc_time_diff(time2, time1, l_sign, &seconds, µseconds, isDateTime);
|
|
|
|
long t_seconds;
|
|
int hour = seconds / 3600L;
|
|
t_seconds = seconds % 3600L;
|
|
int minute = t_seconds / 60L;
|
|
int second = t_seconds % 60L;
|
|
|
|
// Bug 5099: Standardize to mysql behavior. No timediff may be > 838:59:59
|
|
if (hour > 838)
|
|
{
|
|
hour = 838;
|
|
minute = 59;
|
|
second = 59;
|
|
}
|
|
|
|
int sign = 0;
|
|
|
|
if (time1 < time2)
|
|
sign = 1;
|
|
|
|
char buf[256];
|
|
char* ptr = buf;
|
|
string time3;
|
|
|
|
if (microseconds == 0)
|
|
sprintf(ptr, "%s%02d:%02d:%02d", sign ? "-" : "", hour, minute, second);
|
|
else
|
|
sprintf(ptr, "%s%02d:%02d:%02d:%06lld", sign ? "-" : "", hour, minute, second, microseconds);
|
|
|
|
time3 = ptr;
|
|
|
|
return time3;
|
|
}
|
|
} // namespace helpers
|
|
|
|
bool treatIntAsDatetime(const std::string& text)
|
|
{
|
|
// min used when converting into to datetime is YYYYMMDD
|
|
// note: time diffing an int perceived to be in the format YYMMDD is actually treated as HHMMSS. Same
|
|
// functionality as MDB
|
|
bool isNeg = text.find("-") == 0;
|
|
return (text.length() > 8) || (text.length() >= 8 && !isNeg);
|
|
}
|
|
|
|
CalpontSystemCatalog::ColType Func_timediff::operationType(FunctionParm& fp,
|
|
CalpontSystemCatalog::ColType& resultType)
|
|
{
|
|
return resultType;
|
|
}
|
|
|
|
string Func_timediff::getStrVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
|
|
CalpontSystemCatalog::ColType& ct)
|
|
{
|
|
int16_t type1 = parm[0]->data()->resultType().colDataType;
|
|
int16_t type2 = parm[1]->data()->resultType().colDataType;
|
|
|
|
int64_t val1 = -1, val2 = -1;
|
|
bool isDate1 = false, isDate2 = false;
|
|
bool isTime1 = false, isTime2 = false;
|
|
std::string text;
|
|
|
|
switch (type1)
|
|
{
|
|
case execplan::CalpontSystemCatalog::DATE:
|
|
val1 = parm[0]->data()->getDatetimeIntVal(row, isNull);
|
|
isDate1 = true;
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::TIME:
|
|
isTime1 = true;
|
|
/* fall through */
|
|
case execplan::CalpontSystemCatalog::DATETIME:
|
|
// Diff between time and datetime returns NULL in MariaDB
|
|
if ((type2 == execplan::CalpontSystemCatalog::TIME ||
|
|
type2 == execplan::CalpontSystemCatalog::DATETIME) &&
|
|
type1 != type2)
|
|
{
|
|
isNull = true;
|
|
break;
|
|
}
|
|
val1 = parm[0]->data()->getDatetimeIntVal(row, isNull);
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::TIMESTAMP:
|
|
{
|
|
int64_t temp = parm[0]->data()->getTimestampIntVal(row, isNull);
|
|
dataconvert::TimeStamp timestamp(temp);
|
|
int64_t seconds = timestamp.second;
|
|
dataconvert::MySQLTime time;
|
|
dataconvert::gmtSecToMySQLTime(seconds, time, ct.getTimeZone());
|
|
dataconvert::DateTime dt;
|
|
dt.year = time.year;
|
|
dt.month = time.month;
|
|
dt.day = time.day;
|
|
dt.hour = time.hour;
|
|
dt.minute = time.minute;
|
|
dt.second = time.second;
|
|
dt.msecond = timestamp.msecond;
|
|
val1 = (int64_t) * (reinterpret_cast<int64_t*>(&dt));
|
|
|
|
break;
|
|
}
|
|
|
|
case execplan::CalpontSystemCatalog::VARCHAR:
|
|
case execplan::CalpontSystemCatalog::CHAR:
|
|
case execplan::CalpontSystemCatalog::TEXT:
|
|
text = parm[0]->data()->getStrVal(row, isNull).safeString("");
|
|
|
|
if (text.length() >= 12) // datetime has length at least 12 (YYMMDDHHMMSS), convert others to time
|
|
{
|
|
val1 = dataconvert::DataConvert::stringToDatetime(text, &isDate1);
|
|
}
|
|
else
|
|
{
|
|
val1 = dataconvert::DataConvert::stringToTime(text);
|
|
isTime1 = true;
|
|
}
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::BIGINT:
|
|
case execplan::CalpontSystemCatalog::INT:
|
|
case execplan::CalpontSystemCatalog::MEDINT:
|
|
case execplan::CalpontSystemCatalog::TINYINT:
|
|
case execplan::CalpontSystemCatalog::SMALLINT:
|
|
text = parm[0]->data()->getStrVal(row, isNull).safeString("");
|
|
if (treatIntAsDatetime(text))
|
|
val1 = dataconvert::DataConvert::intToDatetime(parm[0]->data()->getIntVal(row, isNull), &isDate1);
|
|
else
|
|
{
|
|
val1 = dataconvert::DataConvert::intToTime(parm[0]->data()->getIntVal(row, isNull));
|
|
isTime1 = true;
|
|
}
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::DECIMAL:
|
|
case execplan::CalpontSystemCatalog::UDECIMAL:
|
|
if (parm[0]->data()->resultType().scale != 0)
|
|
{
|
|
isNull = true;
|
|
break;
|
|
}
|
|
else
|
|
{
|
|
text = parm[0]->data()->getStrVal(row, isNull).safeString("");
|
|
if (treatIntAsDatetime(text))
|
|
val1 = dataconvert::DataConvert::intToDatetime(parm[0]->data()->getIntVal(row, isNull), &isDate1);
|
|
else
|
|
{
|
|
val1 = dataconvert::DataConvert::intToTime(parm[0]->data()->getIntVal(row, isNull));
|
|
isTime1 = true;
|
|
}
|
|
break;
|
|
}
|
|
|
|
default: isNull = true;
|
|
}
|
|
|
|
switch (type2)
|
|
{
|
|
case execplan::CalpontSystemCatalog::DATE:
|
|
val2 = parm[1]->data()->getDatetimeIntVal(row, isNull);
|
|
isDate2 = true;
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::TIME:
|
|
isTime2 = true;
|
|
/* fall through */
|
|
case execplan::CalpontSystemCatalog::DATETIME:
|
|
val2 = parm[1]->data()->getDatetimeIntVal(row, isNull);
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::TIMESTAMP:
|
|
{
|
|
int64_t temp = parm[1]->data()->getTimestampIntVal(row, isNull);
|
|
dataconvert::TimeStamp timestamp(temp);
|
|
int64_t seconds = timestamp.second;
|
|
dataconvert::MySQLTime time;
|
|
dataconvert::gmtSecToMySQLTime(seconds, time, ct.getTimeZone());
|
|
dataconvert::DateTime dt;
|
|
dt.year = time.year;
|
|
dt.month = time.month;
|
|
dt.day = time.day;
|
|
dt.hour = time.hour;
|
|
dt.minute = time.minute;
|
|
dt.second = time.second;
|
|
dt.msecond = timestamp.msecond;
|
|
val2 = (int64_t) * (reinterpret_cast<int64_t*>(&dt));
|
|
break;
|
|
}
|
|
|
|
case execplan::CalpontSystemCatalog::VARCHAR:
|
|
case execplan::CalpontSystemCatalog::CHAR:
|
|
case execplan::CalpontSystemCatalog::TEXT:
|
|
text = parm[1]->data()->getStrVal(row, isNull).safeString("");
|
|
if (text.length() >= 12) // datetime has length at least 12 (YYMMDDHHMMSS), convert others to time
|
|
{
|
|
val2 = dataconvert::DataConvert::stringToDatetime(text, &isDate2);
|
|
}
|
|
else
|
|
{
|
|
val2 = dataconvert::DataConvert::stringToTime(text);
|
|
isTime2 = true;
|
|
}
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::BIGINT:
|
|
case execplan::CalpontSystemCatalog::INT:
|
|
case execplan::CalpontSystemCatalog::MEDINT:
|
|
case execplan::CalpontSystemCatalog::TINYINT:
|
|
case execplan::CalpontSystemCatalog::SMALLINT:
|
|
text = parm[1]->data()->getStrVal(row, isNull).safeString("");
|
|
if (treatIntAsDatetime(text))
|
|
val2 = dataconvert::DataConvert::intToDatetime(parm[1]->data()->getIntVal(row, isNull), &isDate2);
|
|
else
|
|
{
|
|
val2 = dataconvert::DataConvert::intToTime(parm[1]->data()->getIntVal(row, isNull));
|
|
isTime2 = true;
|
|
}
|
|
break;
|
|
|
|
case execplan::CalpontSystemCatalog::DECIMAL:
|
|
case execplan::CalpontSystemCatalog::UDECIMAL:
|
|
if (parm[1]->data()->resultType().scale != 0)
|
|
{
|
|
isNull = true;
|
|
break;
|
|
}
|
|
else
|
|
{
|
|
text = parm[1]->data()->getStrVal(row, isNull).safeString("");
|
|
if (treatIntAsDatetime(text))
|
|
val2 = dataconvert::DataConvert::intToDatetime(parm[1]->data()->getIntVal(row, isNull), &isDate2);
|
|
else
|
|
{
|
|
val2 = dataconvert::DataConvert::intToTime(parm[1]->data()->getIntVal(row, isNull));
|
|
isTime2 = true;
|
|
}
|
|
break;
|
|
}
|
|
|
|
default: isNull = true;
|
|
}
|
|
|
|
if (isNull || val1 == -1 || val2 == -1)
|
|
{
|
|
isNull = true;
|
|
return "";
|
|
}
|
|
|
|
// both date format or both datetime format. Diff between time and datetime returns NULL in MariaDB
|
|
if ((isDate1 && isDate2) || ((!isDate1 && !isDate2) && (isTime1 == isTime2)))
|
|
return helpers::timediff(val1, val2, !isTime1);
|
|
|
|
isNull = true;
|
|
return "";
|
|
}
|
|
|
|
int64_t Func_timediff::getDatetimeIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
|
|
CalpontSystemCatalog::ColType& ct)
|
|
{
|
|
return dataconvert::DataConvert::datetimeToInt(getStrVal(row, parm, isNull, ct));
|
|
}
|
|
|
|
int64_t Func_timediff::getTimestampIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
|
|
CalpontSystemCatalog::ColType& ct)
|
|
{
|
|
return dataconvert::DataConvert::timestampToInt(getStrVal(row, parm, isNull, ct), ct.getTimeZone());
|
|
}
|
|
|
|
int64_t Func_timediff::getTimeIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
|
|
CalpontSystemCatalog::ColType& ct)
|
|
{
|
|
return dataconvert::DataConvert::timeToInt(getStrVal(row, parm, isNull, ct));
|
|
}
|
|
|
|
int64_t Func_timediff::getIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
|
|
CalpontSystemCatalog::ColType& ct)
|
|
{
|
|
// @bug 3585
|
|
// return dataconvert::DataConvert::datetimeToInt(getStrVal(row, parm, isNull, ct));
|
|
return strtoll(getStrVal(row, parm, isNull, ct).c_str(), 0, 10);
|
|
}
|
|
|
|
double Func_timediff::getDoubleVal(rowgroup::Row& row, FunctionParm& fp, bool& isNull,
|
|
execplan::CalpontSystemCatalog::ColType& op_ct)
|
|
{
|
|
// @bug 3585
|
|
// return (double)dataconvert::DataConvert::datetimeToInt(getStrVal(row, fp, isNull, op_ct));
|
|
return atof(getStrVal(row, fp, isNull, op_ct).c_str());
|
|
}
|
|
|
|
} // namespace funcexp
|