mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-04-18 21:44:02 +03:00
This patch improves handling of NULLs in textual fields in ColumnStore. Previously empty strings were considered NULLs and it could be a problem if data scheme allows for empty strings. It was also one of major reasons of behavior difference between ColumnStore and other engines in MariaDB family. Also, this patch fixes some other bugs and incorrect behavior, for example, incorrect comparison for "column <= ''" which evaluates to constant True for all purposes before this patch.
201 lines
6.2 KiB
C++
201 lines
6.2 KiB
C++
/* c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil
|
|
* vi: set shiftwidth=4 tabstop=4 expandtab:
|
|
* :indentSize=4:tabSize=4:noTabs=true:
|
|
*
|
|
* Copyright (C) 2016 MariaDB Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; version 2 of
|
|
* the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
* MA 02110-1301, USA.
|
|
*/
|
|
|
|
#define PREFER_MY_CONFIG_H
|
|
#include "idb_mysql.h"
|
|
#include <vector>
|
|
#include <limits>
|
|
|
|
#include <boost/shared_ptr.hpp>
|
|
#include "calpontsystemcatalog.h"
|
|
#include "dataconvert.h"
|
|
#include "exceptclasses.h"
|
|
#include "is_columnstore.h"
|
|
using namespace logging;
|
|
|
|
// Required declaration as it isn't in a MairaDB include
|
|
bool schema_table_store_record(THD* thd, TABLE* table);
|
|
|
|
ST_FIELD_INFO is_columnstore_columns_fields[] = {
|
|
Show::Column("TABLE_SCHEMA", Show::Varchar(64), NOT_NULL),
|
|
Show::Column("TABLE_NAME", Show::Varchar(64), NOT_NULL),
|
|
Show::Column("COLUMN_NAME", Show::Varchar(64), NOT_NULL),
|
|
Show::Column("OBJECT_ID", Show::ULong(0), NOT_NULL),
|
|
Show::Column("DICTIONARY_OBJECT_ID", Show::ULong(0), NULLABLE),
|
|
Show::Column("LIST_OBJECT_ID", Show::ULong(0), NULLABLE),
|
|
Show::Column("TREE_OBJECT_ID", Show::ULong(0), NULLABLE),
|
|
Show::Column("DATA_TYPE", Show::Varchar(64), NOT_NULL),
|
|
Show::Column("COLUMN_LENGTH", Show::ULong(0), NOT_NULL),
|
|
Show::Column("COLUMN_POSITION", Show::ULong(0), NOT_NULL),
|
|
Show::Column("COLUMN_DEFAULT", Show::Blob(255), NULLABLE),
|
|
Show::Column("IS_NULLABLE", Show::STiny(0), NOT_NULL),
|
|
Show::Column("NUMERIC_PRECISION", Show::ULong(0), NOT_NULL),
|
|
Show::Column("NUMERIC_SCALE", Show::ULong(0), NOT_NULL),
|
|
Show::Column("IS_AUTOINCREMENT", Show::STiny(0), NOT_NULL),
|
|
Show::Column("COMPRESSION_TYPE", Show::Varchar(64), NOT_NULL),
|
|
Show::CEnd()};
|
|
|
|
static int is_columnstore_columns_fill(THD* thd, TABLE_LIST* tables, COND* cond)
|
|
{
|
|
CHARSET_INFO* cs = system_charset_info;
|
|
TABLE* table = tables->table;
|
|
InformationSchemaCond isCond;
|
|
|
|
execplan::CalpontSystemCatalog csc;
|
|
const std::vector<
|
|
std::pair<execplan::CalpontSystemCatalog::OID, execplan::CalpontSystemCatalog::TableName> >
|
|
catalog_tables = csc.getTables();
|
|
|
|
csc.identity(execplan::CalpontSystemCatalog::FE);
|
|
|
|
if (cond)
|
|
{
|
|
isCond.getCondItems(cond);
|
|
}
|
|
|
|
for (std::vector<std::pair<execplan::CalpontSystemCatalog::OID,
|
|
execplan::CalpontSystemCatalog::TableName> >::const_iterator it =
|
|
catalog_tables.begin();
|
|
it != catalog_tables.end(); ++it)
|
|
{
|
|
if (!isCond.match((*it).second.schema, (*it).second.table))
|
|
continue;
|
|
|
|
execplan::CalpontSystemCatalog::RIDList column_rid_list;
|
|
|
|
// Note a table may get dropped as you iterate over the list of tables.
|
|
// So simply ignore the dropped table.
|
|
try
|
|
{
|
|
column_rid_list = csc.columnRIDs((*it).second, true, lower_case_table_names);
|
|
}
|
|
catch (IDBExcept& ex)
|
|
{
|
|
if (ex.errorCode() == ERR_TABLE_NOT_IN_CATALOG)
|
|
{
|
|
continue;
|
|
}
|
|
else
|
|
{
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
for (size_t col_num = 0; col_num < column_rid_list.size(); col_num++)
|
|
{
|
|
execplan::CalpontSystemCatalog::TableColName tcn = csc.colName(column_rid_list[col_num].objnum);
|
|
execplan::CalpontSystemCatalog::ColType ct = csc.colType(column_rid_list[col_num].objnum);
|
|
|
|
table->field[0]->store(tcn.schema.c_str(), tcn.schema.length(), cs);
|
|
table->field[1]->store(tcn.table.c_str(), tcn.table.length(), cs);
|
|
table->field[2]->store(tcn.column.c_str(), tcn.column.length(), cs);
|
|
table->field[3]->store(column_rid_list[col_num].objnum);
|
|
|
|
if (ct.ddn.dictOID == std::numeric_limits<int32_t>::min())
|
|
{
|
|
table->field[4]->set_null();
|
|
}
|
|
else
|
|
{
|
|
table->field[4]->set_notnull();
|
|
table->field[4]->store(ct.ddn.dictOID);
|
|
}
|
|
|
|
if (ct.ddn.listOID == std::numeric_limits<int32_t>::min())
|
|
{
|
|
table->field[5]->set_null();
|
|
}
|
|
else
|
|
{
|
|
table->field[5]->set_notnull();
|
|
table->field[5]->store(ct.ddn.listOID);
|
|
}
|
|
|
|
if (ct.ddn.treeOID == std::numeric_limits<int32_t>::min())
|
|
{
|
|
table->field[6]->set_null();
|
|
}
|
|
else
|
|
{
|
|
table->field[6]->set_notnull();
|
|
table->field[6]->store(ct.ddn.treeOID);
|
|
}
|
|
|
|
std::string data_type = execplan::colDataTypeToString(ct.colDataType);
|
|
table->field[7]->store(data_type.c_str(), data_type.length(), cs);
|
|
table->field[8]->store(ct.colWidth);
|
|
table->field[9]->store(ct.colPosition);
|
|
|
|
if (ct.defaultValue.isNull())
|
|
{
|
|
table->field[10]->set_null();
|
|
}
|
|
else
|
|
{
|
|
table->field[10]->set_notnull();
|
|
table->field[10]->store(ct.defaultValue.str(), ct.defaultValue.length(), cs);
|
|
}
|
|
|
|
table->field[11]->store(ct.autoincrement);
|
|
table->field[12]->store(ct.precision);
|
|
table->field[13]->store(ct.scale);
|
|
|
|
if (ct.constraintType != execplan::CalpontSystemCatalog::NOTNULL_CONSTRAINT)
|
|
{
|
|
table->field[14]->store(true);
|
|
}
|
|
else
|
|
{
|
|
table->field[14]->store(false);
|
|
}
|
|
|
|
std::string compression_type;
|
|
|
|
switch (ct.compressionType)
|
|
{
|
|
case 0: compression_type = "None"; break;
|
|
|
|
case 2: compression_type = "Snappy"; break;
|
|
|
|
case 3: compression_type = "LZ4"; break;
|
|
|
|
default: compression_type = "Unknown"; break;
|
|
}
|
|
|
|
table->field[15]->store(compression_type.c_str(), compression_type.length(), cs);
|
|
|
|
if (schema_table_store_record(thd, table))
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int is_columnstore_columns_plugin_init(void* p)
|
|
{
|
|
ST_SCHEMA_TABLE* schema = (ST_SCHEMA_TABLE*)p;
|
|
schema->fields_info = is_columnstore_columns_fields;
|
|
schema->fill_table = is_columnstore_columns_fill;
|
|
return 0;
|
|
}
|