1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-04-23 07:05:36 +03:00
Sergey Zefirov b53c231ca6 MCOL-271 empty strings should not be NULLs (#2794)
This patch improves handling of NULLs in textual fields in ColumnStore.
Previously empty strings were considered NULLs and it could be a problem
if data scheme allows for empty strings. It was also one of major
reasons of behavior difference between ColumnStore and other engines in
MariaDB family.

Also, this patch fixes some other bugs and incorrect behavior, for
example, incorrect comparison for "column <= ''" which evaluates to
constant True for all purposes before this patch.
2023-03-30 21:18:29 +03:00

267 lines
7.3 KiB
C++

/* Copyright (C) 2014 InfiniDB, Inc.
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; version 2 of
the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
MA 02110-1301, USA. */
/****************************************************************************
* $Id: func_str_to_date.cpp 2578 2011-05-12 16:26:55Z chao $
*
*
****************************************************************************/
#include <unistd.h>
#include <cstdlib>
#include <string>
using namespace std;
#include "functor_dtm.h"
#include "funchelpers.h"
#include "functioncolumn.h"
#include "rowgroup.h"
using namespace execplan;
#include "dataconvert.h"
#define MAX_DAY_NUMBER 3652424L
#include "timeextract.h"
namespace
{
using namespace funcexp;
dataconvert::DateTime getDateTime(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct, long timeZone)
{
TimeExtractor extractor;
dataconvert::DateTime dateTime;
dateTime.year = 0;
dateTime.month = 0;
dateTime.day = 0;
dateTime.hour = 0;
dateTime.minute = 0;
dateTime.second = 0;
dateTime.msecond = 0;
int64_t val = 0;
string valStr;
const auto& formatStr = parm[1]->data()->getStrVal(row, isNull).safeString("");
int rc = 0;
switch (parm[0]->data()->resultType().colDataType)
{
case CalpontSystemCatalog::DATE:
{
val = parm[0]->data()->getIntVal(row, isNull);
valStr = dataconvert::DataConvert::dateToString(val);
rc = extractor.extractTime(valStr, formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
break;
}
case CalpontSystemCatalog::DATETIME:
{
val = parm[0]->data()->getIntVal(row, isNull);
valStr = dataconvert::DataConvert::datetimeToString(val);
rc = extractor.extractTime(valStr, formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
break;
}
case CalpontSystemCatalog::TIMESTAMP:
{
val = parm[0]->data()->getIntVal(row, isNull);
valStr = dataconvert::DataConvert::timestampToString(val, timeZone);
rc = extractor.extractTime(valStr, formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
break;
}
case CalpontSystemCatalog::CHAR:
case CalpontSystemCatalog::TEXT:
case CalpontSystemCatalog::VARCHAR:
{
const string& valref = parm[0]->data()->getStrVal(row, isNull).safeString("");
// decode with provided format
rc = extractor.extractTime(valref, formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
break;
}
case CalpontSystemCatalog::BIGINT:
case CalpontSystemCatalog::MEDINT:
case CalpontSystemCatalog::SMALLINT:
case CalpontSystemCatalog::TINYINT:
case CalpontSystemCatalog::INT:
{
val = parm[0]->data()->getIntVal(row, isNull);
// decode with provided format
rc = extractor.extractTime(helpers::intToString(val), formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
break;
}
case CalpontSystemCatalog::DECIMAL:
case CalpontSystemCatalog::UDECIMAL:
{
if (parm[0]->data()->resultType().scale == 0)
{
val = parm[0]->data()->getIntVal(row, isNull);
// decode with provided format
rc = extractor.extractTime(helpers::intToString(val), formatStr, dateTime);
if (rc < 0)
{
isNull = true;
return -1;
}
}
else
{
isNull = true;
return -1;
}
break;
}
default: isNull = true; return -1;
}
return dateTime;
}
} // namespace
namespace funcexp
{
CalpontSystemCatalog::ColType Func_str_to_date::operationType(FunctionParm& fp,
CalpontSystemCatalog::ColType& resultType)
{
return resultType;
}
string Func_str_to_date::getStrVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
string convertedDate = dataconvert::DataConvert::datetimeToString(*((long long*)&dateTime));
return convertedDate;
}
int32_t Func_str_to_date::getDateIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
int64_t time = *(reinterpret_cast<int64_t*>(&dateTime));
return ((((int32_t)(time >> 32)) & 0xFFFFFFC0) | 0x3E);
}
int64_t Func_str_to_date::getDatetimeIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
int64_t time = *(reinterpret_cast<int64_t*>(&dateTime));
return time;
}
int64_t Func_str_to_date::getTimestampIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
dataconvert::TimeStamp timestamp;
dataconvert::MySQLTime m_time;
m_time.year = dateTime.year;
m_time.month = dateTime.month;
m_time.day = dateTime.day;
m_time.hour = dateTime.hour;
m_time.minute = dateTime.minute;
m_time.second = dateTime.second;
bool isValid = true;
int64_t seconds = mySQLTimeToGmtSec(m_time, ct.getTimeZone(), isValid);
if (!isValid)
{
timestamp = -1;
isNull = true;
}
else
{
timestamp.second = seconds;
timestamp.msecond = dateTime.msecond;
}
int64_t time = *(reinterpret_cast<int64_t*>(&timestamp));
return time;
}
int64_t Func_str_to_date::getTimeIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dataconvert::Time retTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
retTime.day = 0;
retTime.is_neg = false;
retTime.hour = dateTime.hour;
retTime.minute = dateTime.minute;
retTime.second = dateTime.second;
retTime.msecond = dateTime.msecond;
int64_t time = *(reinterpret_cast<int64_t*>(&retTime));
return time;
}
int64_t Func_str_to_date::getIntVal(rowgroup::Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& ct)
{
dataconvert::DateTime dateTime;
dateTime = getDateTime(row, parm, isNull, ct, ct.getTimeZone());
int64_t time = *(reinterpret_cast<int64_t*>(&dateTime));
return time;
}
} // namespace funcexp