mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-04-23 07:05:36 +03:00
b53c231ca6
This patch improves handling of NULLs in textual fields in ColumnStore. Previously empty strings were considered NULLs and it could be a problem if data scheme allows for empty strings. It was also one of major reasons of behavior difference between ColumnStore and other engines in MariaDB family. Also, this patch fixes some other bugs and incorrect behavior, for example, incorrect comparison for "column <= ''" which evaluates to constant True for all purposes before this patch.
82 lines
1.7 KiB
C++
82 lines
1.7 KiB
C++
#include "functor_json.h"
|
|
#include "functioncolumn.h"
|
|
#include "constantcolumn.h"
|
|
using namespace execplan;
|
|
|
|
#include "rowgroup.h"
|
|
using namespace rowgroup;
|
|
|
|
#include "dataconvert.h"
|
|
using namespace dataconvert;
|
|
|
|
#include "jsonhelpers.h"
|
|
using namespace funcexp::helpers;
|
|
|
|
namespace funcexp
|
|
{
|
|
CalpontSystemCatalog::ColType Func_json_length::operationType(FunctionParm& fp,
|
|
CalpontSystemCatalog::ColType& resultType)
|
|
{
|
|
return fp[0]->data()->resultType();
|
|
}
|
|
|
|
int64_t Func_json_length::getIntVal(rowgroup::Row& row, FunctionParm& fp, bool& isNull,
|
|
execplan::CalpontSystemCatalog::ColType& op_ct)
|
|
{
|
|
const auto& js = fp[0]->data()->getStrVal(row, isNull);
|
|
if (isNull)
|
|
return 0;
|
|
|
|
json_engine_t jsEg;
|
|
int length = 0;
|
|
int err;
|
|
|
|
initJSEngine(jsEg, getCharset(fp[0]), js);
|
|
|
|
if (fp.size() > 1)
|
|
{
|
|
if (!path.parsed && parseJSPath(path, row, fp[1], false))
|
|
goto error;
|
|
|
|
if (locateJSPath(jsEg, path))
|
|
goto error;
|
|
}
|
|
|
|
if (json_read_value(&jsEg))
|
|
goto error;
|
|
|
|
if (json_value_scalar(&jsEg))
|
|
return 1;
|
|
|
|
while (!(err = json_scan_next(&jsEg)) && jsEg.state != JST_OBJ_END && jsEg.state != JST_ARRAY_END)
|
|
{
|
|
switch (jsEg.state)
|
|
{
|
|
case JST_VALUE:
|
|
case JST_KEY: length++; break;
|
|
case JST_OBJ_START:
|
|
case JST_ARRAY_START:
|
|
if (json_skip_level(&jsEg))
|
|
goto error;
|
|
break;
|
|
default: break;
|
|
};
|
|
}
|
|
|
|
if (!err)
|
|
{
|
|
// Parse to the end of the JSON just to check it's valid.
|
|
while (json_scan_next(&jsEg) == 0)
|
|
{
|
|
}
|
|
}
|
|
|
|
if (likely(!jsEg.s.error))
|
|
return length;
|
|
|
|
error:
|
|
isNull = true;
|
|
return 0;
|
|
}
|
|
} // namespace funcexp
|