mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-04-23 07:05:36 +03:00
b53c231ca6
This patch improves handling of NULLs in textual fields in ColumnStore. Previously empty strings were considered NULLs and it could be a problem if data scheme allows for empty strings. It was also one of major reasons of behavior difference between ColumnStore and other engines in MariaDB family. Also, this patch fixes some other bugs and incorrect behavior, for example, incorrect comparison for "column <= ''" which evaluates to constant True for all purposes before this patch.
75 lines
1.8 KiB
C++
75 lines
1.8 KiB
C++
#include <string_view>
|
|
#include <memory>
|
|
using namespace std;
|
|
|
|
#include "functor_json.h"
|
|
#include "functioncolumn.h"
|
|
#include "rowgroup.h"
|
|
using namespace execplan;
|
|
using namespace rowgroup;
|
|
|
|
#include "dataconvert.h"
|
|
|
|
#include "jsonhelpers.h"
|
|
using namespace funcexp::helpers;
|
|
|
|
namespace funcexp
|
|
{
|
|
CalpontSystemCatalog::ColType Func_json_equals::operationType(FunctionParm& fp,
|
|
CalpontSystemCatalog::ColType& resultType)
|
|
{
|
|
return fp[0]->data()->resultType();
|
|
}
|
|
|
|
/**
|
|
* getBoolVal API definition
|
|
*/
|
|
bool Func_json_equals::getBoolVal(Row& row, FunctionParm& fp, bool& isNull,
|
|
CalpontSystemCatalog::ColType& type)
|
|
{
|
|
// auto release the DYNAMIC_STRING
|
|
using DynamicString = unique_ptr<DYNAMIC_STRING, decltype(&dynstr_free)>;
|
|
|
|
DynamicString str1{new DYNAMIC_STRING(), dynstr_free};
|
|
if (init_dynamic_string(str1.get(), NULL, 0, 0))
|
|
{
|
|
isNull = true;
|
|
return true;
|
|
}
|
|
|
|
DynamicString str2{new DYNAMIC_STRING(), dynstr_free};
|
|
if (init_dynamic_string(str2.get(), NULL, 0, 0))
|
|
{
|
|
isNull = true;
|
|
return true;
|
|
}
|
|
|
|
const auto js1_ns = fp[0]->data()->getStrVal(row, isNull);
|
|
if (isNull)
|
|
return false;
|
|
|
|
const auto js2_ns = fp[1]->data()->getStrVal(row, isNull);
|
|
if (isNull)
|
|
return false;
|
|
|
|
const string_view js1 = js1_ns.unsafeStringRef();
|
|
const string_view js2 = js2_ns.unsafeStringRef();
|
|
|
|
bool result = false;
|
|
if (json_normalize(str1.get(), js1.data(), js1.size(), getCharset(fp[0])))
|
|
{
|
|
isNull = true;
|
|
return result;
|
|
}
|
|
|
|
if (json_normalize(str2.get(), js2.data(), js2.size(), getCharset(fp[1])))
|
|
{
|
|
isNull = true;
|
|
return result;
|
|
}
|
|
|
|
result = strcmp(str1->str, str2->str) ? false : true;
|
|
return result;
|
|
}
|
|
} // namespace funcexp
|