Ben Thompson
d0a56fd3d4
Change how makespace is called on write when new objects are created. added some inserts and comments on potential bug.
2019-05-21 14:34:25 -05:00
Patrick LeBlanc
04aaff4c2b
Undid the undoing of a fix that was OK to begin with. Cache is in fact
...
supposed to delete the new file not the old one after a flush.
2019-05-20 16:11:36 -05:00
Patrick LeBlanc
168a1dd194
Undid a bad fix I made where Cache would potentially delete the
...
wrong file on a flush.
2019-05-20 15:51:45 -05:00
Patrick LeBlanc
b8d4891a18
Added some commented debugging printouts & some assertions around
...
deletion to make sure we're deleting things.
2019-05-20 10:52:47 -05:00
Roman Nozdrin
e12a2acd53
MCOL-537 Regression test doesn't tolerate 'failed' in stderr, stdout.
...
I reformulate the messages.
Changed version in preprocessor conditions to avoid compilation
warnings in Debian 9.
Disabled sign-compare check for generated files in DML/DDL.
2019-05-20 18:30:52 +03:00
Roman Nozdrin
122038e36a
Merge pull request #767 from mariadb-corporation/develop-1.2-merge-up-20190517
...
Merge develop-1.1 into develop-1.2
2019-05-20 13:50:36 +03:00
Patrick LeBlanc
28495c7e90
Fixed a bug in sync with journal where a cloud object would
...
not be deleted after a journal merge.
2019-05-17 16:02:34 -05:00
Andrew Hutchings
ea2ff9cd11
Merge branch 'develop-1.1' into develop-1.2-merge-up-20190517
2019-05-17 20:43:49 +01:00
Andrew Hutchings
4628346746
Merge pull request #766 from mariadb-corporation/MCOL-3314-1.1
...
MCOL-3314 When setting up statistics functions for the UM, use values…
2019-05-17 20:34:26 +01:00
Andrew Hutchings
8afc3f85d3
Merge pull request #765 from mariadb-corporation/MCOL-3314
...
MCOL-3314 When setting up statistics functions for the UM, use values…
2019-05-17 20:33:55 +01:00
Patrick LeBlanc
3d67df18bf
Merge branch 'develop' of github.com:mariadb-corporation/mariadb-columnstore-engine into S3-project
2019-05-17 13:24:09 -05:00
David Hall
01ff86096a
MCOL-3314 When setting up statistics functions for the UM, use values that actually exist.
2019-05-17 12:45:09 -05:00
David Hall
750b6ea0ff
MCOL-3314 When setting up statistics functions for the UM, use values that actually exist.
2019-05-17 12:43:18 -05:00
Patrick LeBlanc
8b29e3f9ce
Fixed a bug where Cache could delete the wrong file after a flush.
2019-05-17 12:11:57 -05:00
Patrick LeBlanc
77b682f9cd
Fixed a few problems in Sync.
...
- flushObject() could wait on an element in objNames which
doesn't exist, and so it would not get processed.
- process() would not always delete its job from objNames
- Added add'l debugging printouts and a fallback case for when
syncWithJournal does not find a journal file.
- noticed a name collision between the scoped ops in syncWithJournal (harmless)
2019-05-17 09:09:24 -05:00
Patrick LeBlanc
eb3608bf70
Fixed a race in Cache usage during delete & truncate ops.
...
An object could be flushed between the existence check & the delete
done by delete() & truncate(). Made it atomic within Cache.
2019-05-17 09:07:49 -05:00
Roman Nozdrin
92d662491a
Merge pull request #761 from mariadb-corporation/develop-1.2-merge-up-20190514
...
Merge develop-1.1 into develop-1.2
2019-05-16 21:50:05 +03:00
Patrick LeBlanc
886acd8b08
Removed the LIBS=-lm from Cmakelists. For some reason not necessary
...
in this release. Also, for some reason, we are now linking dynamically
instead of statically.
2019-05-16 13:47:13 -05:00
Patrick LeBlanc
8ec7e4a9af
Fixed a couple bugs in S3Storage.
...
- there was no closing of any file descriptors (!!)
- there was the typo in the connection pruning code s.t. nothing
would get pruned.
- added -lm to the libmarias3 stuff, was getting a linker error, not sure why.
2019-05-16 13:31:00 -05:00
Patrick LeBlanc
b1478f347b
Strengthen a minor assert in SharedCloser utility.
2019-05-16 11:56:42 -05:00
Patrick LeBlanc
cd83b26d6b
Was incrementing the wrong iterator, causing infinite loop.
2019-05-16 11:55:43 -05:00
Roman Nozdrin
355e2f914f
Merge pull request #759 from mariadb-corporation/develop-merge-up-20190514
...
Merge develop-1.2 into develop
2019-05-15 11:27:53 +03:00
Roman Nozdrin
0af69944c1
Merge pull request #756 from mariadb-corporation/MCOL-3296
...
MCOL-3296
2019-05-14 23:09:38 +03:00
Andrew Hutchings
45df72a416
Fix issue during merge
2019-05-14 14:36:46 +01:00
Andrew Hutchings
ee6575b013
Merge branch 'develop-1.1' into develop-1.2-merge-up-20190514
2019-05-14 14:26:41 +01:00
Andrew Hutchings
e3fe883a9c
Fix merge issues
2019-05-14 14:18:11 +01:00
Andrew Hutchings
020b211bb7
Merge branch 'develop-1.2' into develop-merge-up-20190514
2019-05-14 13:58:33 +01:00
Patrick LeBlanc
6c4afdf18b
Merge pull request #758 from drrtuy/repair_skip_oam_init
...
Repairs develop build mode w OAM disabled.
2019-05-13 14:41:12 -05:00
Patrick LeBlanc
15dbd1eec8
Fixed a one-char type in an error msg in s3storage.
2019-05-13 12:13:59 -05:00
Patrick LeBlanc
e23051ea0c
Added a comment to IOC. We could use some noise reduction
...
in copyFile.
2019-05-13 12:13:12 -05:00
Patrick LeBlanc
aad393dd34
Fixed a bug in Sync where we were using an object through a
...
reference to a shared pointer. A deref of the shared ptr could
trigger the dtor of the object while threads are waiting. Fixed that
by properly copying the shared ptr.
2019-05-13 12:11:16 -05:00
Patrick LeBlanc
19859de510
Added a test to the s3 module, attempt to copy a non-existant file.
2019-05-13 12:10:48 -05:00
Roman Nozdrin
cdc570bf42
Repairs develop build mode w OAM disabled. Now one can use
...
-DSKIP_OAM_INIT=1 instead of using environmental variable.
2019-05-13 18:32:35 +03:00
Roman Nozdrin
f3be1db554
Merge pull request #745 from ssedov/develop-1.1
...
MCOL-2051: CS uses 'NULL' literal as NULL when UPDATEs varchar field
2019-05-12 21:29:02 +03:00
Patrick LeBlanc
2cd2c8b0a6
Fixed error reporting in s3storage. Was printing the access key,
...
not the key of the object.
2019-05-10 13:55:39 -05:00
Patrick LeBlanc
a087c85776
Add error handling for a specific error code returned by
...
libmarias3.
2019-05-10 13:49:18 -05:00
Patrick LeBlanc
53a88fdc09
Fixed a minor bug in error reporting.
2019-05-10 13:49:00 -05:00
Patrick LeBlanc
353392f98b
Update the ref on libmarias3.
2019-05-10 13:48:41 -05:00
David Hall
f98097673f
MCOL-3296 Add logging when a dml is blocked because of another dml on the same table
2019-05-10 10:04:57 -05:00
Patrick LeBlanc
0dd33c6f75
Merge pull request #751 from drrtuy/mcol-537-compiler-warnings
...
MCOL-537 Address existing compiler warnings.
2019-05-10 09:27:18 -05:00
David Hall
f2d8a33ee5
MCOL-3296 CTRL+C should not double remove from dequeue.
2019-05-09 12:42:18 -05:00
Roman Nozdrin
3c89a4bba4
MCOL-537 Preprocessor if blocks with pragmas now have else branch.
...
DMLProc exits on setupCwd failure.
2019-05-09 20:25:21 +03:00
Roman Nozdrin
e8c93e1ccb
Merge pull request #744 from davidjmott/branches/davidjmott/cxx11_stage2
...
This patch enables c++11 support.
2019-05-09 13:58:53 +03:00
Andrew Hutchings
067b1bd3d0
Merge pull request #752 from mariadb-corporation/MCOL-1495
...
MCOL-1495 DML operations created two fCatalogMap entries per session.
2019-05-09 09:44:05 +01:00
David Mott
d96eef0147
Permit build with older cmake
2019-05-08 20:14:45 -05:00
Roman Nozdrin
58828083d3
Merge pull request #755 from mariadb-corporation/CPackFix12
...
Fix for newer version of CMake/CPack
2019-05-08 20:51:59 +03:00
Roman Nozdrin
d9d1c9275b
Merge pull request #754 from mariadb-corporation/CPackFix11
...
Fix for newer version of CMake/CPack
2019-05-08 20:51:23 +03:00
Ben Thompson
99d172372d
Fix for newer version of CMake/CPack
2019-05-08 12:01:30 -05:00
Ben Thompson
c444c36da7
Fix for newer version of CMake/CPack
2019-05-08 12:00:12 -05:00
Roman Nozdrin
b2436502cb
MCOL-537 Enabled -Wno-unused-result for OAM code.
...
Fixed pragmas that disables compilation checks.
DDLProc now returns an error if it couldn't cwd.
Use either auto_ptr or unique_ptr depending on GCC version.
2019-05-08 19:44:01 +03:00