1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-08 14:22:09 +03:00
Commit Graph

1737 Commits

Author SHA1 Message Date
Roman Nozdrin
ce0311aa79 MCOL-3828 This commit replaces the method that calls JOIN::optimise()
internally(thus can remove equi-JOIN predicates) with a recursive f()
to inject equi-JOIN conditions for IN + correlated subquery Item.
This change both solves MCOL-3747 issue and remove issues I first
faced in union.sql test.

This commit also fixes a clean up for conditions pushed for table API
execution path and replaces NULL with nullptr in ha_mcs_impl.cpp.
2020-03-24 14:00:42 +00:00
Patrick LeBlanc
163b4a5bb7 MCOL-3356. code cleanup. 2020-03-19 15:31:50 -04:00
Patrick LeBlanc
17f1539f89 MCOL-3356. bit_{or,xor,and} job creation error
Checkpointing.  Found it, fixed it.  It was an extra assignment that was
messing up RowGroup creation.
2020-03-19 12:39:16 -04:00
Roman Nozdrin
3345f7a437 MCOL-3769 This commit divides create_SH in two parts: before rewrites and
after rewrites. We can safely fallback from SH to DH and table mode from
'before rewrites' part.
2020-03-18 20:24:34 +03:00
Gagan Goel
457ec0d483 Updates to plugin code based on recent changes in the server 10.5 branch. 2020-03-12 00:42:16 +00:00
Gagan Goel
b5373d227a MCOL-3777 Cleanup left-over values from a previously failed insert. 2020-03-05 02:26:58 +00:00
Patrick LeBlanc
52dec05a52 Merge pull request #1075 from pleblanc1976/2020-3-1.4-to-1.5
2020 3 1.4 to 1.5
2020-03-02 09:11:00 -06:00
Patrick LeBlanc
03a2283bac Fixed a merge error. 2020-02-28 17:11:13 -05:00
benthompson15
da32afc0b2 Merge pull request #1023 from LinuxJedi/mariadb-systemctl
MCOL-3718 Use systemd instead of mysql-Columnstore
2020-02-28 16:19:58 -05:00
Jose Rojas
61574cd00d Merge pull request #1047 from LinuxJedi/collate_warn
MCOL-3721 Fix quoting issues for COLLATE
2020-02-28 16:19:53 -05:00
Roman Nozdrin
e0cb60dcd2 Merge pull request #1024 from LinuxJedi/collate_warn
MCOL-3721 Allow collate and warn on ORDER BY
2020-02-28 16:19:36 -05:00
David.Hall
f71158601e Merge pull request #1032 from drrtuy/MCOL-3766
MCOL-3766 EXPLAIN now doesn't execute query via SH thus doesn't fail
2020-02-28 16:19:25 -05:00
David.Hall
bfe3ab14c0 Merge pull request #1030 from LinuxJedi/MCOL-3764
MCOL-3764 Fix RENAME TABLE
2020-02-28 16:19:18 -05:00
David.Hall
0db52396f9 Merge pull request #1025 from mariadb-corporation/MCOL-3747
MCOL-3747 This patch properly enables queries with IN + uncorrelated …
2020-02-28 13:58:45 -05:00
Gagan Goel
f27cb8a21f Merge pull request #1012 from dhall-MariaDB/MCOL-3662
MCOL-3662 Restore error message for multi parameter aggregates save for UDAnF and GROUP_CONCAT
2020-02-28 13:58:39 -05:00
Gagan Goel
42adfb60e5 Merge pull request #1017 from dhall-MariaDB/MCOL-3632
MCOL-3632 Restore error message for ref item type
2020-02-28 13:58:34 -05:00
benthompson15
7a16877aae Merge pull request #1016 from dhall-MariaDB/MCOL-3744
MCOL-3744 mcssystemready to work with SKIP_OAM_INIT
2020-02-28 13:58:26 -05:00
Andrew Hutchings
9e588039d5 Merge pull request #1010 from tntnatbry/MCOL-3680
MCOL-3680 mysqld will abort if Columnstore.xml is missing.
Conflicts:
	dbcon/mysql/ha_mcs.cpp
2020-02-28 13:58:00 -05:00
Patrick LeBlanc
9cc1e1c4f8 Merge pull request #1006 from LinuxJedi/change-engine
MCOL-128 Support ALTER TABLE...ENGINE=Columnstore
2020-02-28 13:54:54 -05:00
jmrojas2332
426d77b54f MCOL-3485 Fix ORDER BY not working with multiple aggregates of same type in SELECT 2020-02-27 21:26:36 +00:00
Gagan Goel
dd89943a5b MCOL-3788 Remove save/restore_group_list impl since the optimizer call
does not happen in create_SH anymore
2020-02-21 15:32:16 +00:00
David Hall
a91f7b7d6e MCOL-3812 remove call to thd_set_ha_data()
MariaDB 10.5 doesn't want us to call this.
2020-02-20 10:19:45 -06:00
Patrick LeBlanc
d5ec634136 Fixed a problem with the fix for MCOL-3769 & the default sql_mode.
It appears that STRICT_TRANS_TABLE treats these warnings as if they are
errors.  Commenting out the warnings for now.
2020-02-18 11:42:29 -05:00
Roman Nozdrin
437e8650a7 MCOL-3769 This commit divides create_SH in two parts: before rewrites and
after rewrites. We can safely fallback from SH to DH and table mode from
    'before rewrites' part. We also returns meaningful warning.
2020-02-17 17:39:43 +00:00
Patrick LeBlanc
ae515a36b8 Revert "Merge pull request #1046 from drrtuy/MCOL-3769"
This has an uninit'd var warning from the compiler.  It fixes one test
and breaks 2 others in test001.

This reverts commit cf668897ef, reversing
changes made to 25084d0020.
2020-02-14 18:23:54 -05:00
Gagan Goel
6d98de3922 Use const_cast to assign to field_length due to
change in server 10.4 commit 1394216e3db67152a1356fddd8ddcd563b4f38c3
2020-02-14 01:00:50 +00:00
Gagan Goel
cf668897ef Merge pull request #1046 from drrtuy/MCOL-3769
MCOL-3769 This commit refactors create_SH() to return an early error
2020-02-12 12:09:50 -05:00
benthompson15
25084d0020 Merge pull request #1023 from LinuxJedi/mariadb-systemctl
MCOL-3718 Use systemd instead of mysql-Columnstore
2020-02-12 10:01:26 -06:00
Jose Rojas
7941dce141 Merge pull request #1047 from LinuxJedi/collate_warn
MCOL-3721 Fix quoting issues for COLLATE
2020-02-12 09:59:55 -06:00
Andrew Hutchings
e43d9be05b MCOL-3721 Fix quoting issues for COLLATE 2020-02-12 09:14:07 +00:00
Roman Nozdrin
0c13c40201 MCOL-3769 This commit refactors create_SH() to return an early error
if any of optimizer rewrites fails.
2020-02-12 08:01:01 +00:00
Roman Nozdrin
3eed0aaae4 Merge pull request #1035 from dhall-MariaDB/MCOL-3663-1.4
MCOL-3663 revert to using posix regex for LIKE
2020-02-11 20:43:01 +03:00
Roman Nozdrin
72dc3c4396 Merge pull request #1024 from LinuxJedi/collate_warn
MCOL-3721 Allow collate and warn on ORDER BY
2020-02-11 19:28:07 +03:00
David Hall
d051482e94 MCOL-3663 revert to using posix regex for LIKE 2020-02-10 13:37:42 -06:00
David Hall
b7156eb244 MCOL-3663 revert to using posix regex for LIKE 2020-02-10 11:29:31 -06:00
Andrew Hutchings
c334a6fb1e Also add support for collate in column definitions 2020-02-10 16:24:02 +00:00
Roman Nozdrin
4d528cc6b8 MCOL-3766 EXPLAIN now doesn't execute query via SH thus doesn't fail
every other run.
2020-02-10 10:20:03 +00:00
Andrew Hutchings
cd5e742a2a MCOL-3764 Fix RENAME TABLE
When ALTER TABLE ... ENGINE= is called the following happens:

1. A temporary table is created in the new engine with the real table
   name but a temporary file name supplied
2. A bulk insert is started from old to new table
3. The old table is dropped
4. The new table is renamed

For #1 we use the real table name instead of the temporary file name
(otherwise step #2 breaks), we were therefore trying to skip #4.
This broke regular RENAME TABLE commands.

With this patch we detect if the rename is for a temporary to real table
and skip it. Since this is the only instance where we support temporary
tables.

This patch also fixes issues with extracting table names from file
names and some other irrelevant stuff.

Longer term if we want to support temporary tables we need to store the
provided filename in our metadata since it could be different from table
name.
2020-02-06 11:52:38 +00:00
Andrew Hutchings
6cf6519019 MCOL-3718 Use systemd instead of mysql-Columnstore
MariaDB server is now managed using systemd instead of our own
mysql-Columnstore script. This means that MariaDB server can be stopped
/ started independently of ColumnStore
2020-02-06 07:47:44 +00:00
David Hall
f9f7b79a2b MCOL-3749 Assertion on error
Correct error code return stops assertion
2020-02-05 11:10:54 -06:00
jmrojas2332
979d2bcd03 MCOL-2139 syntax update 2020-02-04 20:44:31 +00:00
jmrojas2332
7c358957dc MCOL-2139 syntax update based on feedback 2020-02-04 20:44:06 +00:00
jmrojas2332
009a4aea1d MCOL 2139 Fix subquery not being filtered when using view 2020-02-04 20:43:46 +00:00
David.Hall
4116d3b2d7 Merge pull request #1025 from mariadb-corporation/MCOL-3747
MCOL-3747 This patch properly enables queries with IN + uncorrelated …
2020-02-04 09:41:12 -06:00
Roman Nozdrin
608fba77fd MCOL-3747 This patch properly enables queries with IN + uncorrelated subquery
processing that was broken after vtable had been removed.
Before this patch IN-INTO-EXISTS rewrite doesn't add equi-JOIN predicate when
IN+subquery was in a nested subquery.
2020-02-04 08:26:15 +00:00
jmrojas2332
aa1d8944ce MCOL-2139 syntax update 2020-02-03 20:49:02 +00:00
jmrojas2332
9fbfb63b85 MCOL-2139 syntax update based on feedback 2020-02-03 20:13:55 +00:00
jmrojas2332
f1285dd79e MCOL 2139 Fix subquery not being filtered when using view 2020-02-03 15:42:57 +00:00
Andrew Hutchings
acc87f4cfc MCOL-3721 Allow collate and warn on ORDER BY
COLLATE is now allowed but ignored on DDL and ORDER BY. For an ORDER BY
query a note is generated.
2020-02-01 16:02:03 +01:00
Gagan Goel
8c24353cbb Merge pull request #1012 from dhall-MariaDB/MCOL-3662
MCOL-3662 Restore error message for multi parameter aggregates save for UDAnF and GROUP_CONCAT
2020-01-31 13:43:28 -05:00