1
0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-08 14:22:09 +03:00
Commit Graph

1040 Commits

Author SHA1 Message Date
David Hall
a91f7b7d6e MCOL-3812 remove call to thd_set_ha_data()
MariaDB 10.5 doesn't want us to call this.
2020-02-20 10:19:45 -06:00
Patrick LeBlanc
d5ec634136 Fixed a problem with the fix for MCOL-3769 & the default sql_mode.
It appears that STRICT_TRANS_TABLE treats these warnings as if they are
errors.  Commenting out the warnings for now.
2020-02-18 11:42:29 -05:00
Roman Nozdrin
437e8650a7 MCOL-3769 This commit divides create_SH in two parts: before rewrites and
after rewrites. We can safely fallback from SH to DH and table mode from
    'before rewrites' part. We also returns meaningful warning.
2020-02-17 17:39:43 +00:00
Patrick LeBlanc
ae515a36b8 Revert "Merge pull request #1046 from drrtuy/MCOL-3769"
This has an uninit'd var warning from the compiler.  It fixes one test
and breaks 2 others in test001.

This reverts commit cf668897ef, reversing
changes made to 25084d0020.
2020-02-14 18:23:54 -05:00
Gagan Goel
6d98de3922 Use const_cast to assign to field_length due to
change in server 10.4 commit 1394216e3db67152a1356fddd8ddcd563b4f38c3
2020-02-14 01:00:50 +00:00
Gagan Goel
cf668897ef Merge pull request #1046 from drrtuy/MCOL-3769
MCOL-3769 This commit refactors create_SH() to return an early error
2020-02-12 12:09:50 -05:00
benthompson15
25084d0020 Merge pull request #1023 from LinuxJedi/mariadb-systemctl
MCOL-3718 Use systemd instead of mysql-Columnstore
2020-02-12 10:01:26 -06:00
Roman Nozdrin
0c13c40201 MCOL-3769 This commit refactors create_SH() to return an early error
if any of optimizer rewrites fails.
2020-02-12 08:01:01 +00:00
Roman Nozdrin
72dc3c4396 Merge pull request #1024 from LinuxJedi/collate_warn
MCOL-3721 Allow collate and warn on ORDER BY
2020-02-11 19:28:07 +03:00
Roman Nozdrin
4d528cc6b8 MCOL-3766 EXPLAIN now doesn't execute query via SH thus doesn't fail
every other run.
2020-02-10 10:20:03 +00:00
Andrew Hutchings
cd5e742a2a MCOL-3764 Fix RENAME TABLE
When ALTER TABLE ... ENGINE= is called the following happens:

1. A temporary table is created in the new engine with the real table
   name but a temporary file name supplied
2. A bulk insert is started from old to new table
3. The old table is dropped
4. The new table is renamed

For #1 we use the real table name instead of the temporary file name
(otherwise step #2 breaks), we were therefore trying to skip #4.
This broke regular RENAME TABLE commands.

With this patch we detect if the rename is for a temporary to real table
and skip it. Since this is the only instance where we support temporary
tables.

This patch also fixes issues with extracting table names from file
names and some other irrelevant stuff.

Longer term if we want to support temporary tables we need to store the
provided filename in our metadata since it could be different from table
name.
2020-02-06 11:52:38 +00:00
Andrew Hutchings
6cf6519019 MCOL-3718 Use systemd instead of mysql-Columnstore
MariaDB server is now managed using systemd instead of our own
mysql-Columnstore script. This means that MariaDB server can be stopped
/ started independently of ColumnStore
2020-02-06 07:47:44 +00:00
David Hall
f9f7b79a2b MCOL-3749 Assertion on error
Correct error code return stops assertion
2020-02-05 11:10:54 -06:00
jmrojas2332
979d2bcd03 MCOL-2139 syntax update 2020-02-04 20:44:31 +00:00
jmrojas2332
7c358957dc MCOL-2139 syntax update based on feedback 2020-02-04 20:44:06 +00:00
jmrojas2332
009a4aea1d MCOL 2139 Fix subquery not being filtered when using view 2020-02-04 20:43:46 +00:00
David.Hall
4116d3b2d7 Merge pull request #1025 from mariadb-corporation/MCOL-3747
MCOL-3747 This patch properly enables queries with IN + uncorrelated …
2020-02-04 09:41:12 -06:00
Roman Nozdrin
608fba77fd MCOL-3747 This patch properly enables queries with IN + uncorrelated subquery
processing that was broken after vtable had been removed.
Before this patch IN-INTO-EXISTS rewrite doesn't add equi-JOIN predicate when
IN+subquery was in a nested subquery.
2020-02-04 08:26:15 +00:00
jmrojas2332
aa1d8944ce MCOL-2139 syntax update 2020-02-03 20:49:02 +00:00
jmrojas2332
9fbfb63b85 MCOL-2139 syntax update based on feedback 2020-02-03 20:13:55 +00:00
jmrojas2332
f1285dd79e MCOL 2139 Fix subquery not being filtered when using view 2020-02-03 15:42:57 +00:00
Andrew Hutchings
acc87f4cfc MCOL-3721 Allow collate and warn on ORDER BY
COLLATE is now allowed but ignored on DDL and ORDER BY. For an ORDER BY
query a note is generated.
2020-02-01 16:02:03 +01:00
Gagan Goel
8c24353cbb Merge pull request #1012 from dhall-MariaDB/MCOL-3662
MCOL-3662 Restore error message for multi parameter aggregates save for UDAnF and GROUP_CONCAT
2020-01-31 13:43:28 -05:00
Gagan Goel
36907a84e0 Merge pull request #1017 from dhall-MariaDB/MCOL-3632
MCOL-3632 Restore error message for ref item type
2020-01-31 12:30:17 -05:00
benthompson15
6453168480 Merge pull request #1016 from dhall-MariaDB/MCOL-3744
MCOL-3744 mcssystemready to work with SKIP_OAM_INIT
2020-01-30 14:29:30 -06:00
David Hall
fc4f0e4f97 MCOL-3749 Return error when update truncates 2020-01-29 16:26:41 -06:00
David Hall
275b1db857 MCOL-3632 Restore error message for ref item type
Function or Operator with sub query on the SELECT clause is currently not supported.
2020-01-28 11:16:18 -06:00
Andrew Hutchings
70f5c12279 Merge pull request #1010 from tntnatbry/MCOL-3680
MCOL-3680 mysqld will abort if Columnstore.xml is missing.
2020-01-28 15:26:05 +00:00
David Hall
2c814bd3ed MCOL-3744 mcssystemready to work with SKIP_OAM_INIT 2020-01-24 12:33:03 -06:00
Patrick LeBlanc
092994d00d Merge pull request #1006 from LinuxJedi/change-engine
MCOL-128 Support ALTER TABLE...ENGINE=Columnstore
2020-01-24 09:26:13 -06:00
Andrew Hutchings
4b86890cf7 MCOL-128 Support ALTER TABLE...ENGINE=Columnstore
Also implements:

* ALTER TABLE from Columnstore to another engine
* MCOL-3349 CREATE TABLE ... AS SELECT.
2020-01-23 21:12:33 +00:00
David Hall
57bf5303f1 MCOL-3662 Restore error message for multi parameter aggregates save for UDAnF and GROUP_CONCAT 2020-01-23 14:10:15 -06:00
Gagan Goel
d0ffede135 MCOL-3680 mysqld will abort if Columnstore.xml is missing
Add try-catch blocks in the plugin code to prevent mysqld
from aborting if configcpp cannot access Columnstore.xml.
2020-01-23 17:41:02 +00:00
Roman Nozdrin
c6aaa3f227 This commit fixes MDB crash that happens when table lock timeout fires
with multiply DML run in separate transactions.

This commit also fixes GCC unused variable warning.
2020-01-21 16:48:15 -05:00
Patrick LeBlanc
b6dfdd6e99 Merge pull request #1000 from drrtuy/MCOL-1734_2
MCOL-1734 CS now behaves similar to MDB in case of NOT IN + correlated subquery if the subquery returns empty set.
2020-01-21 16:45:24 -05:00
Andrew Hutchings
cd80b0ace5 Merge pull request #1003 from mariadb-corporation/fix-doUpdateDelete
This commit fixes MDB crash that happens when table lock timeout fires
2020-01-17 08:25:44 -08:00
Roman Nozdrin
f21998eff3 Merge pull request #1002 from LinuxJedi/10.5-compatible
MariaDB 10.5 Compatibility
2020-01-15 19:10:49 -08:00
Roman Nozdrin
f178f2c22f This commit fixes MDB crash that happens when table lock timeout fires
with multiply DML run in separate transactions.

This commit also fixes GCC unused variable warning.
2020-01-14 22:44:35 +00:00
Andrew Hutchings
a959aad92d MariaDB 10.5 Compatibility
Several changes have happened in MariaDB 10.5, most notably:

* Information Schema table definitions have changed
* More things use LEX_CSTRING

This fixes all the compile issues
2020-01-13 10:47:14 -08:00
drrtuy
8595fa0226 MCOL-1734 CS now behaves similar to MDB in case of
NOT IN + correlated subquery if the subquery returns empty set.
CS now returns full outer record set.

gcc 8.2 complains about unused variable in ha_mcs_impl.cc
2020-01-07 17:23:17 +03:00
Andrew Hutchings
de4ab3e294 MCOL-3702 Fix replication config file changes
log_bin is missing from columnstore.cnf. This causes a search for the
master log file to fail and replication doesn't apply.

This patch adds a commented out log_bin which is enabled as needed.

It also fixes an error message.
2020-01-03 10:08:52 +00:00
Andrew Hutchings
bd592aa714 Merge pull request #984 from LinuxJedi/fix-engineid
MCOL-3673 Fix legacy db type
2019-12-20 07:44:14 +02:00
Andrew Hutchings
bf944c4ce4 Merge pull request #991 from mariadb-corporation/MENT-513
fixes for MENT-513
2019-12-20 07:40:49 +02:00
Patrick LeBlanc
b0248c665c Re-added commit 5eb050f3af with a one-char modification that fixes
an odd access denied error when running a select stmt.
2019-12-19 18:40:57 -05:00
Patrick LeBlanc
dbc8cbaca9 Revert "Merge pull request #989 from LinuxJedi/set-maturity"
This reverts commit 5eb050f3af, reversing
changes made to 0be00a3a73.
2019-12-19 18:08:49 -05:00
Sergei Golubchik
96adf535ae don't create a ResourceManager to initialize a global variable
this is executed when ha_columnstore is loaded, at dlopen time
before any initialization code is run and crashes any dlopen
attemps.

Crashes - because a missing config file is a crashing offence,
but it's an issue for another day
2019-12-19 19:42:38 +01:00
Sergei Golubchik
9cc92fda91 compilation failure
#define likely clashes with

static bool likely(const string_type& str)

in /usr/include/boost/date_time/special_values_parser.hpp
2019-12-19 18:15:16 +01:00
Andrew Hutchings
76f25045d9 Make plugin maturity definable at compile time. 2019-12-19 07:30:22 +02:00
Patrick LeBlanc
d8e763655c MCOL-3654: Fix row-based repl detection
if 0'd the row-based repl checks for now to prevent ruling out
stmts we should be able to process.
2019-12-17 13:26:18 -05:00
Patrick LeBlanc
e02302908b MCOL-3674: Fix row-based replication detection
Changed the row-based repl detection mechanism so stmt-based repl works
again, however, the detection mechanism is still wrong somehow.  What it
should be is currently unknown.
2019-12-17 13:15:58 -05:00