database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-07 03:22:57 +03:00
Code Activity

Merge pull request #503 from drrtuy/MCOL-1457

Browse Source 
MCOL-1457 GROUP BY handler supports aliases of projected columns in ORDER BY list.
This commit is contained in:
Andrew Hutchings
2018-07-10 09:23:53 +01:00
committed by GitHub
parent bd641301da f650db2d10
commit fc0a8b1043
1 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
dbcon/mysql/ha_calpont_execplan.cpp
View File

@@ -8118,9 +8118,9 @@ int cp_get_group_plan(THD* thd, SCSEP& csep, cal_impl_if::cal_group_info& gi)
gwi.thd = thd; gwi.thd = thd;
int status = getGroupPlan(gwi, select_lex, csep, gi); int status = getGroupPlan(gwi, select_lex, csep, gi);
// cerr << "---------------- cp_get_group_plan EXECUTION PLAN ----------------" << endl; cerr << "---------------- cp_get_group_plan EXECUTION PLAN ----------------" << endl;
// cerr << *csep << endl ; cerr << *csep << endl ;
// cerr << "-------------- EXECUTION PLAN END --------------\n" << endl; cerr << "-------------- EXECUTION PLAN END --------------\n" << endl;
if (status > 0) if (status > 0)
return ER_INTERNAL_ERROR; return ER_INTERNAL_ERROR;
@@ -9527,6 +9527,7 @@ int getGroupPlan(gp_walk_info& gwi, SELECT_LEX& select_lex, SCSEP& csep, cal_gro
else else
{ {
Item* ord_item = *(ordercol->item); Item* ord_item = *(ordercol->item);
bool nonAggField = true;
// ignore not_used column on order by. // ignore not_used column on order by.
if (ord_item->type() == Item::INT_ITEM && ord_item->full_name() && string(ord_item->full_name()) == "Not_used") if (ord_item->type() == Item::INT_ITEM && ord_item->full_name() && string(ord_item->full_name()) == "Not_used")
@@ -9535,11 +9536,36 @@ int getGroupPlan(gp_walk_info& gwi, SELECT_LEX& select_lex, SCSEP& csep, cal_gro
rc = gwi.returnedCols[((Item_int*)ord_item)->val_int() - 1]->clone(); rc = gwi.returnedCols[((Item_int*)ord_item)->val_int() - 1]->clone();
else if (ord_item->type() == Item::SUBSELECT_ITEM) else if (ord_item->type() == Item::SUBSELECT_ITEM)
gwi.fatalParseError = true; gwi.fatalParseError = true;
else if (ordercol->in_field_list && ord_item->type() == Item::FIELD_ITEM)
{
rc = buildReturnedColumn(ord_item, gwi, gwi.fatalParseError);
Item_field* ifp = static_cast<Item_field*>(ord_item);
// The item must be an alias for a projected column
// and extended SELECT list must contain a proper rc
// either aggregation or a field.
if (!rc && ifp->name_length)
{
gwi.fatalParseError = false;
execplan::CalpontSelectExecutionPlan::ReturnedColumnList::iterator iter = gwi.returnedCols.begin();
AggregateColumn* ac = NULL;
for ( ; iter != gwi.returnedCols.end(); iter++ )
{
if ( (*iter).get()->alias() == ord_item->name )
{
rc = (*iter).get()->clone();
nonAggField = rc->hasAggregate() ? false : true;
break;
}
}
}
}
else else
rc = buildReturnedColumn(ord_item, gwi, gwi.fatalParseError); rc = buildReturnedColumn(ord_item, gwi, gwi.fatalParseError);
// Looking for a match for this item in GROUP BY list. // Looking for a match for this item in GROUP BY list.
if ( rc && ord_item->type() == Item::FIELD_ITEM ) if ( rc && ord_item->type() == Item::FIELD_ITEM && nonAggField)
{ {
execplan::CalpontSelectExecutionPlan::ReturnedColumnList::iterator iter = gwi.groupByCols.begin(); execplan::CalpontSelectExecutionPlan::ReturnedColumnList::iterator iter = gwi.groupByCols.begin();