database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

MCOL-807 HOUR() is always positive

Browse Source 
It is undocumented but when MariaDB gets a negative time in the HOUR()
function it always returns a positive value. This does the same for us.
This commit is contained in:
Andrew Hutchings
2018-06-04 15:17:56 +01:00
parent 51afdc98fc
commit f850f8b0d0
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
utils/funcexp/func_hour.cpp
View File

@ -127,22 +127,13 @@ int64_t Func_hour::getIntVal(rowgroup::Row& row,
if (isTime) if (isTime)
{ {
// If negative, mask so it doesn't turn positive // HOUR() is always positive in MariaDB, even for negative time
bool isNeg = false;
int64_t mask = 0; int64_t mask = 0;
if ((val >> 40) & 0x800) if ((val >> 40) & 0x800)
mask = 0xfffffffffffff000; mask = 0xfffffffffffff000;
if (!mask && (val >> 63)) val = abs(mask | ((val >> 40) & 0xfff));
{
isNeg = true;
}
val = mask | ((val >> 40) & 0xfff);
if (isNeg)
val *= -1;
} }
else else
{ {