database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Replace underlying type for avg and sum for int types from long double to wide decimal

Browse Source
This commit is contained in:
Leonid Fedorov
2021-04-13 21:15:33 +00:00
parent 123d602296
commit f81f743282
5 changed files with 159 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
datatypes/mcs_datatype.h
View File

@ -361,7 +361,6 @@ static inline bool isWideDecimalType(const datatypes::SystemCatalog::ColDataType
dt == SystemCatalog::UDECIMAL);
}
/** convenience function to determine if column type is a char
* type
*/
@ -480,27 +479,18 @@ inline bool isSignedInteger(const datatypes::SystemCatalog::ColDataType type)
}
}
/**
@brief Returns true if all arguments have a DECIMAL/UDECIMAL type
@brief The method netects whether type sum and avg aggregate will have
wide decimal underlying type
*/
static inline bool isDecimalOperands(const SystemCatalog::ColDataType resultDataType,
const SystemCatalog::ColDataType leftColDataType,
const SystemCatalog::ColDataType rightColDataType)
inline bool hasUnderlyingWideDecimalForSumAndAvg(datatypes::SystemCatalog::ColDataType type)
{
return ((resultDataType == SystemCatalog::DECIMAL ||
resultDataType == SystemCatalog::UDECIMAL) &&
(leftColDataType == SystemCatalog::DECIMAL ||
leftColDataType == SystemCatalog::UDECIMAL) &&
(rightColDataType == SystemCatalog::DECIMAL ||
rightColDataType == SystemCatalog::UDECIMAL));
return datatypes::isSignedInteger(type) || datatypes::isUnsigned(type);
}
} // end of namespace datatypes
namespace datatypes
{
@ -1957,7 +1947,7 @@ public:
MinMaxInfo widenMinMaxInfo(const SystemCatalog::TypeAttributesStd &attr,
const MinMaxInfo &a,
const MinMaxInfo &b) const override
{
{
return MinMaxInfo::widenSInt64(a, b);
}
MinMaxPartitionInfo getExtentPartitionInfo(const SystemCatalog::TypeAttributesStd &attr,
@ -2038,7 +2028,7 @@ public:
MinMaxInfo widenMinMaxInfo(const SystemCatalog::TypeAttributesStd &attr,
const MinMaxInfo &a,
const MinMaxInfo &b) const override
{
{
return MinMaxInfo::widenSInt64(a, b);
}
MinMaxPartitionInfo getExtentPartitionInfo(const SystemCatalog::TypeAttributesStd &attr,
@ -2123,7 +2113,7 @@ public:
MinMaxInfo widenMinMaxInfo(const SystemCatalog::TypeAttributesStd &attr,
const MinMaxInfo &a,
const MinMaxInfo &b) const override
{
{
return MinMaxInfo::widenSInt128(a, b);
}
MinMaxPartitionInfo getExtentPartitionInfo(const SystemCatalog::TypeAttributesStd &attr,
@ -2202,7 +2192,7 @@ public:
MinMaxInfo widenMinMaxInfo(const SystemCatalog::TypeAttributesStd &attr,
const MinMaxInfo &a,
const MinMaxInfo &b) const override
{
{
return MinMaxInfo::widenSInt128(a, b);
}
MinMaxPartitionInfo getExtentPartitionInfo(const SystemCatalog::TypeAttributesStd &attr,