database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4643 dev 5 reset valOut after processing UDAF

Browse Source 
After a UDAF result has been inserted in the output stream, the valOut object needs to be reset to empty in preparation for the next value. Failing to do so may cause what should be a NULL value to erroneously take the last value inserted.
This commit is contained in:
David Hall
2021-04-30 10:57:40 -05:00
parent 7f7fa74dce
commit f4e6939139
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
utils/rowgroup/rowaggregation.cpp
View File

@ -3029,6 +3029,8 @@ void RowAggregationUM::SetUDAFValue(static_any::any& valOut, int64_t colOut)
// This handles the mismatch
SetUDAFAnyValue(valOut, colOut);
}
// reset valOut to be ready for the next value
valOut.reset();
}
void RowAggregationUM::SetUDAFAnyValue(static_any::any& valOut, int64_t colOut)
@ -3298,7 +3300,6 @@ void RowAggregationUM::calculateUDAFColumns()
// Set the returned value into the output row
SetUDAFValue(valOut, colOut);
valOut.reset();
}
fRGContext.setUserData(NULL);