database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-5385 set data extermination [develop-23.02] (#2813)

Browse Source 
* Delete RowGroup::setData and make Pointer ctor explicit

* some push_backs replaced with emplace_backs

* Fixes of review notes
This commit is contained in:
Leonid Fedorov
2023-04-16 15:57:39 +03:00
committed by GitHub
parent 2f153184c3
commit f1697c261e
13 changed files with 37 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
utils/joiner/tuplejoiner.cpp
View File

@ -574,7 +574,7 @@ void TupleJoiner::match(rowgroup::Row& largeSideRow, uint32_t largeRowIndex, uin
return;
for (; range.first != range.second; ++range.first)
matches->push_back(range.first->second);
matches->emplace_back(rowgroup::Row::Pointer(range.first->second));
}
}
else
@ -615,7 +615,7 @@ void TupleJoiner::match(rowgroup::Row& largeSideRow, uint32_t largeRowIndex, uin
pair<iterator, iterator> range = h[bucket]->equal_range(nullVal);
for (; range.first != range.second; ++range.first)
matches->push_back(range.first->second);
matches->emplace_back(rowgroup::Row::Pointer(range.first->second));
}
else
{
@ -648,7 +648,7 @@ void TupleJoiner::match(rowgroup::Row& largeSideRow, uint32_t largeRowIndex, uin
for (uint i = 0; i < bucketCount; i++)
for (it = h[i]->begin(); it != h[i]->end(); ++it)
matches->push_back(it->second);
matches->emplace_back(rowgroup::Row::Pointer(it->second));
}
else
{
@ -747,7 +747,7 @@ void TupleJoiner::doneInserting()
{
while (hit == h[bucket]->end())
hit = h[++bucket]->begin();
smallRow.setPointer(hit->second);
smallRow.setPointer(rowgroup::Row::Pointer(hit->second));
++hit;
}
else
@ -1033,10 +1033,10 @@ void TupleJoiner::getUnmarkedRows(vector<Row::Pointer>* out)
for (uint i = 0; i < bucketCount; i++)
for (it = h[i]->begin(); it != h[i]->end(); ++it)
{
smallR.setPointer(it->second);
smallR.setPointer(rowgroup::Row::Pointer(it->second));
if (!smallR.isMarked())
out->push_back(it->second);
out->emplace_back(rowgroup::Row::Pointer(it->second));
}
}
else