database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4030: first commit of warning removals unneed const and missing virtual dtors.

Browse Source
This commit is contained in:
benthompson15
2020-06-23 13:51:36 -05:00
parent 410cf29ff2
commit eac7dab096
64 changed files with 169 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
utils/messageqcpp/compressed_iss.h
View File

@ -42,6 +42,7 @@ class CompressedInetStreamSocket : public InetStreamSocket
{
public:
CompressedInetStreamSocket();
virtual ~CompressedInetStreamSocket(){};
virtual Socket* clone() const;
virtual const SBS read(const struct timespec* timeout = 0, bool* isTimeOut = NULL,

2
utils/messageqcpp/inetstreamsocket.cpp
View File

@ -1105,7 +1105,7 @@ const string InetStreamSocket::addr2String() const
return s;
}
const bool InetStreamSocket::isSameAddr(const Socket* rhs) const
bool InetStreamSocket::isSameAddr(const Socket* rhs) const
{
const InetStreamSocket* issp = dynamic_cast<const InetStreamSocket*>(rhs);

8
utils/messageqcpp/inetstreamsocket.h
View File

@ -105,7 +105,7 @@ public:
/** test if this socket is open
*
*/
inline virtual const bool isOpen() const;
inline virtual bool isOpen() const;
/** read a message from the socket
*
@ -180,7 +180,7 @@ public:
fSyncProto = use;
}
const int getConnectionNum() const
int getConnectionNum() const
{
return fSocketParms.sd();
}
@ -199,7 +199,7 @@ public:
/** compare 2 addresses
*
*/
virtual const bool isSameAddr(const Socket* rhs) const;
virtual bool isSameAddr(const Socket* rhs) const;
/** ping an ip address
*
@ -255,7 +255,7 @@ private:
void doCopy(const InetStreamSocket& rhs);
};
inline const bool InetStreamSocket::isOpen() const
inline bool InetStreamSocket::isOpen() const
{
return (fSocketParms.sd() >= 0);
}

10
utils/messageqcpp/iosocket.h
View File

@ -119,7 +119,7 @@ public:
/** test if the socket is open
*
*/
inline virtual const bool isOpen() const;
inline virtual bool isOpen() const;
/** get the socket params
*
@ -150,7 +150,7 @@ public:
fSocket->syncProto(use);
}
EXPORT virtual const int getConnectionNum() const;
EXPORT virtual int getConnectionNum() const;
// Debug
EXPORT void setSockID(uint32_t id)
@ -175,7 +175,7 @@ public:
/**
* @brief compare 2 addresses
*/
virtual const bool isSameAddr(const IOSocket* rhs) const
virtual bool isSameAddr(const IOSocket* rhs) const
{
return fSocket->isSameAddr(rhs->fSocket);
}
@ -235,7 +235,7 @@ inline void IOSocket::close()
{
if (fSocket) fSocket->close();
}
inline const bool IOSocket::isOpen() const
inline bool IOSocket::isOpen() const
{
return (fSocket && fSocket->isOpen());
}
@ -274,7 +274,7 @@ inline void IOSocket::setSocketImpl(Socket* socket)
delete fSocket;
fSocket = socket;
}
inline const int IOSocket::getConnectionNum() const
inline int IOSocket::getConnectionNum() const
{
return fSocket->getConnectionNum();
}

6
utils/messageqcpp/messagequeue.h
View File

@ -237,7 +237,7 @@ public:
{
return fOtherEnd;
}
EXPORT const bool isAvailable() const
EXPORT bool isAvailable() const
{
return fIsAvailable;
}
@ -267,7 +267,7 @@ public:
/**
* @brief compare the addresses of 2 MessageQueueClient
*/
inline const bool isSameAddr(const MessageQueueClient& rhs) const;
inline bool isSameAddr(const MessageQueueClient& rhs) const;
bool isConnected()
{
@ -316,7 +316,7 @@ inline const std::string MessageQueueClient::addr2String() const
{
return fClientSock.addr2String();
}
inline const bool MessageQueueClient::isSameAddr(const MessageQueueClient& rhs) const
inline bool MessageQueueClient::isSameAddr(const MessageQueueClient& rhs) const
{
return fClientSock.isSameAddr(&rhs.fClientSock);
}

6
utils/messageqcpp/socket.h
View File

@ -126,7 +126,7 @@ public:
/** test if this socket is open
*
*/
virtual const bool isOpen() const = 0;
virtual bool isOpen() const = 0;
/** get the SocketParms
*
@ -158,7 +158,7 @@ public:
*/
virtual void syncProto(bool use) = 0;
virtual const int getConnectionNum() const = 0;
virtual int getConnectionNum() const = 0;
/** return the address as a string
*
@ -168,7 +168,7 @@ public:
/** compare 2 addresses
*
*/
virtual const bool isSameAddr(const Socket* rhs) const = 0;
virtual bool isSameAddr(const Socket* rhs) const = 0;
virtual bool isConnected() const = 0;
virtual bool hasData() const = 0;