database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-4030: first commit of warning removals unneed const and missing virtual dtors.

Browse Source
This commit is contained in:
benthompson15
2020-06-23 13:51:36 -05:00
parent 410cf29ff2
commit eac7dab096
64 changed files with 169 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
primitives/blockcache/blockcacheclient.h
View File

@ -80,7 +80,7 @@ public:
/**
* @brief retrieve the Disk Block at lbid, ver from the Disk Block Buffer Cache
**/
inline const int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, FileBuffer& fb)
inline int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, FileBuffer& fb)
{
return fBCCBrp->read(lbid, ver, fb);
}
@ -88,12 +88,12 @@ public:
/**
* @brief retrieve the Disk Block at lbid, ver from the Disk Block Buffer Cache
**/
inline const int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, void* bufferPtr)
inline int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, void* bufferPtr)
{
return fBCCBrp->read(lbid, ver, bufferPtr);
}
inline const int getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, const BRM::VER_t txn, const int compType,
inline int getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, const BRM::VER_t txn, const int compType,
void* bufferPtr, bool flg, bool& wasCached, bool* wasVersioned = NULL, bool insertIntoCache = true,
bool readFromCache = true)
{

2
primitives/blockcache/blockrequestprocessor.cpp
View File

@ -210,7 +210,7 @@ int BlockRequestProcessor::check(BRM::LBID_t lbid, const BRM::QueryContext& ver,
}
}
const int BlockRequestProcessor::getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, BRM::VER_t txn,
int BlockRequestProcessor::getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, BRM::VER_t txn,
int compType, void* bufferPtr, bool vbFlg, bool& wasCached, bool* versioned, bool insertIntoCache,
bool readFromCache)
{

6
primitives/blockcache/blockrequestprocessor.h
View File

@ -90,7 +90,7 @@ public:
return fbMgr.findPtr(HashObject_t(lbid, ver, flg));
}
inline const int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, FileBuffer& fb)
inline int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, FileBuffer& fb)
{
return (fbMgr.find(HashObject_t(lbid, ver, 0), fb) ? 1 : 0);
}
@ -98,12 +98,12 @@ public:
/**
* @brief retrieve the lbid@ver disk block from the block cache
**/
inline const int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, void* bufferPtr)
inline int read(const BRM::LBID_t& lbid, const BRM::VER_t& ver, void* bufferPtr)
{
return (fbMgr.find(HashObject_t(lbid, ver, 0), bufferPtr) ? 1 : 0);
}
const int getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, BRM::VER_t txn, int compType,
int getBlock(const BRM::LBID_t& lbid, const BRM::QueryContext& ver, BRM::VER_t txn, int compType,
void* bufferPtr, bool flg, bool& wasCached, bool* wasVersioned, bool insertIntoCache,
bool readFromCache);

6
primitives/blockcache/filebuffer.h
View File

@ -103,7 +103,7 @@ public:
return fByteData;
}
inline const uint32_t datLen() const
inline uint32_t datLen() const
{
return fDataLen;
}
@ -136,7 +136,7 @@ public:
/**
* @brief return the lbid value of disk bloc
**/
inline const BRM::LBID_t Lbid() const
inline BRM::LBID_t Lbid() const
{
return fLbid;
}
@ -148,7 +148,7 @@ public:
/**
* @brief return the version of this disk block. ignored for range retrievals
**/
inline const BRM::VER_t Verid() const
inline BRM::VER_t Verid() const
{
return fVerid;
}

2
primitives/blockcache/filebuffermgr.h
View File

@ -201,7 +201,7 @@ public:
}
void setReportingFrequency(const uint32_t d);
const uint32_t ReportingFrequency() const
uint32_t ReportingFrequency() const
{
return fReportFrequency;
}

14
primitives/blockcache/filerequest.h
View File

@ -130,7 +130,7 @@ public:
/**
* @brief lbid requested
**/
const BRM::LBID_t Lbid() const
BRM::LBID_t Lbid() const
{
return fLBID;
}
@ -146,17 +146,17 @@ public:
/**
* @brief VBBM flag of the LBID/Ver
**/
const bool Flg() const
bool Flg() const
{
return fFlg;
}
const BRM::VER_t Txn() const
BRM::VER_t Txn() const
{
return fTxn;
}
const int CompType() const
int CompType() const
{
return fCompType;
}
@ -164,7 +164,7 @@ public:
/**
* @brief number of blocks requested
**/
const uint32_t BlocksRequested() const
uint32_t BlocksRequested() const
{
return fLength;
}
@ -180,11 +180,11 @@ public:
/**
* @brief number of blocks read from disk
**/
const uint32_t BlocksRead() const
uint32_t BlocksRead() const
{
return fblksRead;
}
const uint32_t BlocksLoaded() const
uint32_t BlocksLoaded() const
{
return fblksLoaded;
}

2
primitives/blockcache/iomanager.cpp
View File

@ -1368,7 +1368,7 @@ void ioManager::buildOidFileName(const BRM::OID_t oid, uint16_t dbRoot, const ui
fFileOp.getFileNameForPrimProc(oid, file_name, dbRoot, partNum, segNum);
}
const int ioManager::localLbidLookup(BRM::LBID_t lbid,
int ioManager::localLbidLookup(BRM::LBID_t lbid,
BRM::VER_t verid,
bool vbFlag,
BRM::OID_t& oid,

4
primitives/blockcache/iomanager.h
View File

@ -73,7 +73,7 @@ public:
return fConfig;
}
const int localLbidLookup(BRM::LBID_t lbid,
int localLbidLookup(BRM::LBID_t lbid,
BRM::VER_t verid,
bool vbFlag,
BRM::OID_t& oid,
@ -88,7 +88,7 @@ public:
const uint16_t segNum,
char* file_name);
const uint32_t getExtentRows()
uint32_t getExtentRows()
{
return fdbrm.getExtentRows();
}