From df636239775cb935c662c192e384df1a88af8c81 Mon Sep 17 00:00:00 2001 From: mariadb-KristinaPavlova Date: Thu, 17 Jul 2025 13:20:12 +0300 Subject: [PATCH] add reference to config entry in err msg --- dbcon/ddlpackageproc/altertableprocessor.cpp | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/dbcon/ddlpackageproc/altertableprocessor.cpp b/dbcon/ddlpackageproc/altertableprocessor.cpp index 38e60a902..55de9ca42 100644 --- a/dbcon/ddlpackageproc/altertableprocessor.cpp +++ b/dbcon/ddlpackageproc/altertableprocessor.cpp @@ -739,7 +739,7 @@ void AlterTableProcessor::addColumn(uint32_t sessionID, execplan::CalpontSystemC if(tableTooBig(inTableName)) { result.result = ALTER_ERROR; - err += "Table too big - statement may take eternity"; + err = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; throw std::runtime_error(err); } try @@ -1645,7 +1645,7 @@ void AlterTableProcessor::dropColumns(uint32_t sessionID, execplan::CalpontSyste if(tableTooBig(fTableName)) { result.result = ALTER_ERROR; - err += "Table too big - statement may take eternity"; + err = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; DETAIL_INFO("dropColumns::dropColumn failed"); return; } @@ -1731,7 +1731,8 @@ void AlterTableProcessor::setColumnDefault(uint32_t sessionID, execplan::Calpont ByteStream::byte rc = 0; if(tableTooBig(fTableName)) { - throw std::runtime_error("Table too big - statement may take eternity"); + errorMsg = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; + throw std::runtime_error(errorMsg); } // Find out where syscolumns rc = fDbrm->getSysCatDBRoot(sysOid, dbRoot); @@ -1824,7 +1825,8 @@ void AlterTableProcessor::dropColumnDefault(uint32_t sessionID, execplan::Calpon ByteStream::byte rc = 0; if(tableTooBig(fTableName)) { - throw std::runtime_error("Table too big - statement may take eternity"); + errorMsg = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; + throw std::runtime_error(errorMsg); } // Find out where syscolumn is rc = fDbrm->getSysCatDBRoot(sysOid, dbRoot); @@ -2005,7 +2007,7 @@ void AlterTableProcessor::renameTable(uint32_t sessionID, execplan::CalpontSyste roPair.objnum = 0; if(tableTooBig(fTableName)) { - throw std::runtime_error("Table too big - statement may take eternity"); + throw std::runtime_error("Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"); } try { @@ -2174,7 +2176,8 @@ void AlterTableProcessor::tableComment(uint32_t sessionID, execplan::CalpontSyst rc = fDbrm->getSysCatDBRoot(sysOid, dbRoot); if(tableTooBig(fTableName)) { - throw std::runtime_error("Table too big - statement may take eternity"); + errorMsg = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; + throw std::runtime_error(errorMsg); } OamCache* oamcache = OamCache::makeOamCache(); boost::shared_ptr > dbRootPMMap = oamcache->getDBRootToPMMap(); @@ -2394,7 +2397,8 @@ void AlterTableProcessor::renameColumn(uint32_t sessionID, execplan::CalpontSyst ByteStream::byte rc = 0; if(tableTooBig(fTableName)) { - throw std::runtime_error("Table too big - statement may take eternity"); + errorMsg = "Table too big - statement may take eternity. Look SystemConfig.MaxRowSizeAlter in Columnstore.xml"; + throw std::runtime_error(errorMsg); } // Find out where systable is rc = fDbrm->getSysCatDBRoot(sysOid, dbRoot);