database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

fix(rowgroup): RGData now uses uint64_t counter for the fixed sizes columns data buf.

Browse Source 
The buffer can utilize > 4GB RAM that is necessary for PM side join.
	RGData ctor uses uint32_t allocating data buffer.
 	This fact causes implicit heap overflow.
This commit is contained in:
drrtuy
2024-08-24 19:13:58 +00:00
committed by Leonid Fedorov
parent ca6c35abdd
commit dc03621e9d
8 changed files with 78 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/windowfunction/idborderby.cpp
View File

@ -753,7 +753,7 @@ void IdbOrderBy::initialize(const RowGroup& rg)
// initialize rows
IdbCompare::initialize(rg);
uint64_t newSize = rg.getSizeWithStrings(fRowsPerRG);
auto newSize = rg.getSizeWithStrings(fRowsPerRG);
if (fRm && !fRm->getMemory(newSize, fSessionMemLimit))
{
cerr << IDBErrorInfo::instance()->errorMsg(fErrorCode) << " @" << __FILE__ << ":" << __LINE__;