database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

fix(rowgroup): RGData now uses uint64_t counter for the fixed sizes columns data buf.

Browse Source 
The buffer can utilize > 4GB RAM that is necessary for PM side join.
	RGData ctor uses uint32_t allocating data buffer.
 	This fact causes implicit heap overflow.
This commit is contained in:
drrtuy
2024-08-24 19:13:58 +00:00
committed by Leonid Fedorov
parent ca6c35abdd
commit dc03621e9d
8 changed files with 78 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
utils/rowgroup/rowstorage.cpp
View File

@ -635,6 +635,7 @@ class RowGroupStorage
if (fRGDatas[rgid])
{
fRowGroupOut->setData(fRGDatas[rgid].get());
// An implicit s2u type cast.
int64_t memSz = fRowGroupOut->getSizeWithStrings(fMaxRows);
if (!fMM->acquire(memSz))
{
@ -792,7 +793,7 @@ class RowGroupStorage
while (rgid >= fRGDatas.size())
{
int64_t memSz = fRowGroupOut->getSizeWithStrings(fMaxRows);
auto memSz = fRowGroupOut->getSizeWithStrings(fMaxRows);
if (!fMM->acquire(memSz))
{
throw logging::IDBExcept(