database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

Fix a few cppcheck issues

Browse Source 
Found the following:

* Potential stack explosions with alloca() usage on potentially large
strings
* Memory leaks in WriteEngineServer
* Stack usage out of scope in dataconvert
* A typo in an 'if' statement in dataconvert
This commit is contained in:
Andrew Hutchings
2019-11-20 11:49:46 +00:00
parent 0f86a3ab14
commit dba7220ad3
22 changed files with 110 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
writeengine/bulk/we_colbuf.cpp
View File

@ -133,7 +133,7 @@ int ColumnBuffer::writeToFile(int startOffset, int writeSize, bool fillUpWEmptie
if (nitems != 1)
{
delete newBuf;
delete [] newBuf;
return ERR_FILE_WRITE;
}
@ -141,7 +141,7 @@ int ColumnBuffer::writeToFile(int startOffset, int writeSize, bool fillUpWEmptie
Stats::stopParseEvent(WE_STATS_WRITE_COL);
#endif
delete newBuf;
delete [] newBuf;
return NO_ERROR;
}

1
writeengine/bulk/we_columninfocompressed.cpp
View File

@ -411,6 +411,7 @@ int ColumnInfoCompressed::truncateDctnryStore(
fLog->logMsg( oss.str(), rc, MSGLVL_ERROR );
fTruncateDctnryFileOp.closeFile( dFile );
delete [] pointerHdr;
return rc;
}