database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

Fix a few cppcheck issues

Browse Source 
Found the following:

* Potential stack explosions with alloca() usage on potentially large
strings
* Memory leaks in WriteEngineServer
* Stack usage out of scope in dataconvert
* A typo in an 'if' statement in dataconvert
This commit is contained in:
Andrew Hutchings
2019-11-20 11:49:46 +00:00
parent 0f86a3ab14
commit dba7220ad3
22 changed files with 110 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
utils/funcexp/func_repeat.cpp
View File

@ -81,8 +81,7 @@ std::string Func_repeat::getStrVal(rowgroup::Row& row,
int size = str.length() * count;
//allocate memory
char* result = NULL;
result = (char*) alloca(size * sizeof(char) + 1);
char* result = new char[size + 1];
if (result == NULL)
{
@ -97,7 +96,9 @@ std::string Func_repeat::getStrVal(rowgroup::Row& row,
return "";
}
return result;
std::string res(result);
delete [] result;
return res;
}