database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

Fix a few cppcheck issues

Browse Source 
Found the following:

* Potential stack explosions with alloca() usage on potentially large
strings
* Memory leaks in WriteEngineServer
* Stack usage out of scope in dataconvert
* A typo in an 'if' statement in dataconvert
This commit is contained in:
Andrew Hutchings
2019-11-20 11:49:46 +00:00
parent 0f86a3ab14
commit dba7220ad3
22 changed files with 110 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
utils/dataconvert/dataconvert.cpp
View File

@ -2011,7 +2011,7 @@ int64_t DataConvert::convertColumnTimestamp(
unsigned int dataOrgLen,
const std::string& timeZone )
{
char tmbuf[64];
std::string dataOrgTemp = dataOrg;
if (dataOrgTemp.substr(0, 19) == "0000-00-00 00:00:00")
{
@ -2023,7 +2023,6 @@ int64_t DataConvert::convertColumnTimestamp(
if (strcmp(dataOrg, "current_timestamp() ON UPDATE current_timestamp()") == 0)
{
struct timeval tv;
char tmbuf[64];
gettimeofday(&tv, 0);
MySQLTime time;
gmtSecToMySQLTime(tv.tv_sec, time, timeZone);