MCOL-4234 and MCOL 5772 cherry-picked into [stable 23.10] (#3226)

* MCOL-4234: improve GROUP BY and ORDER BY interaction (#3194)

This patch fixes the problem in MCOL-4234 and also generally improves
behavior of GROUP BY.

It does so by introducing a "dummy" aggregate and by wrapping columns
into it. This allows for columns that are not in GROUP BY to be used
more freely, for example, in SELECT * FROM tbl GROUP BY col - all
columns that are not "col" will be wrapped into an aggregate and query
will proceed to execution.

The dummy aggregate itself does nothing more than remember last value
passed into it.

There also an additional error message that tries to explain what types
of expressions can be wrapped into an aggregate.

* MCOL-5772: incorrect ORDER BY ordering for a columns not in GROUP BY (#3214)

When ORDER BY column is not in GROUP BY, is not an aggregate and there
is a SELECT column that is also not an aggregate, there was a problem:
ordering happened on the SELECTed column, not ORDERed one.

This patch fixes that particular problem and also performs some tidying
around newly added aggregate.

---------

Co-authored-by: Leonid Fedorov <79837786+mariadb-LeonidFedorov@users.noreply.github.com>

mysql-test/columnstore/basic/t/MCOL-5772-hidden-order-by.test

@@ -0,0 +1,28 @@
+# Order by a column that is not in GROUP BY and SELECT parts
+# should be correct.
+--disable_warnings
+DROP DATABASE IF EXISTS MCOL5772;
+--enable_warnings
+
+CREATE DATABASE MCOL5772;
+
+USE MCOL5772;
+
+CREATE TABLE products (
+product_id INT,
+product_name VARCHAR(100),
+category VARCHAR(50),
+unit_price DECIMAL(10, 2),
+stock_quantity INT
+) ENGINE=Columnstore;
+
+INSERT INTO products VALUES
+(1, 'Laptop', 'Electronics', 1200.00, 50),
+(2, 'Smartphone', 'Electronics', 800.00, 100),
+(3, 'Coffee Maker', 'Appliances', 50.00, 30),
+(4, 'Backpack', 'Fashion', 40.00, 80),
+(5, 'Desk Chair', 'Furniture', 150.00, 20);
+
+SELECT product_name, SUM(stock_quantity) AS total_stock FROM products GROUP BY category ORDER BY stock_quantity;
+
+DROP DATABASE MCOL5772;

mysql-test/columnstore/basic/t/mcol-4525.test

@@ -85,7 +85,6 @@ INSERT INTO t1 VALUES(10,'bob',10);
 SET columnstore_select_handler=ON;
 --error 1178
 SELECT SUM(col1) AS col2 FROM t1 GROUP BY col2;
---error 1815
 SELECT col1 c FROM t1 ORDER BY AVG(col1);
 SET columnstore_select_handler=AUTO;
 SELECT SUM(col1) AS col2 FROM t1 GROUP BY col2;

mysql-test/columnstore/basic/t/mcs35_select_group_by.test

@@ -52,7 +52,7 @@ INSERT INTO t1  VALUES(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NUL
 --sorted_result
 SELECT * FROM t1;
 #Without aggregate function
---error 1815
+--sorted_result
 SELECT * FROM t1 GROUP BY t1_tinyint;
 
 --sorted_result

mysql-test/columnstore/basic/t/mcs36_select_order_by_group_by.test

@@ -60,8 +60,7 @@ SELECT t1.spID, t2.userid, MIN(t1.score)
  FROM t1, t2 WHERE t1.userID=t2.userID GROUP BY t2.userid, t1.spID ORDER BY t1.spID, t2.userid;
 
 # columns in ORDER BY clause not included in the GROUP BY clause.
-#Suspected bug. Innodb succeeds.
---error 1815
+--sorted_result
 SELECT t1.spID, t2.userid, MIN(t1.score) 
  FROM t1, t2 WHERE t1.userID=t2.userID GROUP BY t2.userid, t1.spID ORDER BY t1.date;
 
@@ -76,10 +75,13 @@ SELECT t2.userid, MIN(t1.score)
  FROM t1, t2 WHERE t1.userID=t2.userID GROUP BY t2.userid ORDER BY unknown;
 
 # order by null
-#Suspected bug. Innodb succeeds.
---error 1815
+# Innodb succeeds - it is a workaround to speed up GROUP BY.
+--sorted_result
 SELECT t2.userid, MIN(t1.score)
  FROM t1, t2 WHERE t1.userID=t2.userID GROUP BY t2.userid ORDER BY NULL;
 
+SELECT * FROM t1 GROUP BY spID, userID ORDER BY score ASC, spID, userID;
+SELECT * FROM t1 GROUP BY spID, userID ORDER BY score DESC, spID, userID;
+
 #Clean up
 DROP DATABASE IF EXISTS mcs36_db1;

mysql-test/columnstore/basic/t/mcs76_having.test

@@ -18,7 +18,7 @@ SELECT col2 FROM t1 GROUP BY col2 HAVING col2 LIKE '%o%' ORDER BY col2;
 SELECT col1 FROM t1 GROUP BY col1 HAVING col1 > 1 ORDER BY col1;
 SELECT col1, col2 FROM t1 GROUP BY col1, col2 HAVING col1 > 1 AND col2 LIKE '%o%' ORDER BY col1;
 SELECT col1, col2 FROM t1 GROUP BY col1, col2 HAVING col1 > 1 OR col2 LIKE '%o%' ORDER BY col1;
---error ER_INTERNAL_ERROR
+--sorted_result
 SELECT col1, col2, SUM(LENGTH(col2)) FROM t1 GROUP BY col1 HAVING col1 > 1 AND col2 LIKE '%o%' ORDER BY col1;
 
 CREATE TABLE t2(col1 INT, col2 DATETIME)ENGINE=Columnstore;