database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

chore(): another cleanup round

Browse Source
This commit is contained in:
drrtuy
2025-03-20 12:43:24 +00:00
parent b649af5a0c
commit db2c82519d
4 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -262,8 +262,8 @@ ENDIF()
MY_CHECK_AND_SET_COMPILER_FLAG("-Wno-deprecated-copy" DEBUG RELEASE RELWITHDEBINFO MINSIZEREL) MY_CHECK_AND_SET_COMPILER_FLAG("-Wno-deprecated-copy" DEBUG RELEASE RELWITHDEBINFO MINSIZEREL)
MY_CHECK_AND_SET_COMPILER_FLAG("-Wno-deprecated-declarations" DEBUG RELEASE RELWITHDEBINFO MINSIZEREL) MY_CHECK_AND_SET_COMPILER_FLAG("-Wno-deprecated-declarations" DEBUG RELEASE RELWITHDEBINFO MINSIZEREL)
MY_CHECK_AND_SET_COMPILER_FLAG("-Werror -Wall -Wextra") MY_CHECK_AND_SET_COMPILER_FLAG("-Werror -Wall -Wextra")
SET (ENGINE_LDFLAGS "-Wl,--no-as-needed -Wl,--add-needed") SET (ENGINE_LDFLAGS "-Wl,--no-as-needed -Wl,--add-needed")
SET (ENGINE_DT_LIB datatypes) SET (ENGINE_DT_LIB datatypes)
SET (ENGINE_COMMON_LIBS messageqcpp loggingcpp configcpp idbboot boost_thread xml2 pthread rt ${ENGINE_DT_LIB}) SET (ENGINE_COMMON_LIBS messageqcpp loggingcpp configcpp idbboot boost_thread xml2 pthread rt ${ENGINE_DT_LIB})

1
primitives/blockcache/stats.cpp
View File

@ -176,7 +176,6 @@ class StatMon
sigset_t sigset; sigset_t sigset;
sigemptyset(&sigset); sigemptyset(&sigset);
sigaddset(&sigset, SIGPIPE); sigaddset(&sigset, SIGPIPE);
// sigaddset(&sigset, SIGUSR1);
sigaddset(&sigset, SIGUSR2); sigaddset(&sigset, SIGUSR2);
pthread_sigmask(SIG_BLOCK, &sigset, 0); pthread_sigmask(SIG_BLOCK, &sigset, 0);
} }

7
tests/CMakeLists.txt
View File

@ -29,6 +29,7 @@ if (WITH_UNITTESTS)
#GoogleTest tests #GoogleTest tests
add_executable(rowgroup_tests rowgroup-tests.cpp) add_executable(rowgroup_tests rowgroup-tests.cpp)
target_compile_options(rowgroup_tests PRIVATE -Wno-sign-compare)
add_dependencies(rowgroup_tests googletest) add_dependencies(rowgroup_tests googletest)
target_link_libraries(rowgroup_tests ${ENGINE_LDFLAGS} ${GTEST_LIBRARIES} ${ENGINE_EXEC_LIBS}) target_link_libraries(rowgroup_tests ${ENGINE_LDFLAGS} ${GTEST_LIBRARIES} ${ENGINE_EXEC_LIBS})
gtest_add_tests(TARGET rowgroup_tests TEST_PREFIX columnstore:) gtest_add_tests(TARGET rowgroup_tests TEST_PREFIX columnstore:)
@ -75,14 +76,14 @@ if (WITH_UNITTESTS)
target_link_libraries(fair_threadpool_test ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES} processor dbbc) target_link_libraries(fair_threadpool_test ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES} processor dbbc)
gtest_add_tests(TARGET fair_threadpool_test TEST_PREFIX columnstore:) gtest_add_tests(TARGET fair_threadpool_test TEST_PREFIX columnstore:)
set_source_files_properties(counting_allocator.cpp PROPERTIES COMPILE_FLAGS "-Wno-sign-compare")
add_executable(counting_allocator counting_allocator.cpp) add_executable(counting_allocator counting_allocator.cpp)
target_compile_options(counting_allocator PRIVATE -Wno-sign-compare)
add_dependencies(counting_allocator googletest) add_dependencies(counting_allocator googletest)
target_link_libraries(counting_allocator ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES}) target_link_libraries(counting_allocator ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES})
gtest_add_tests(TARGET counting_allocator TEST_PREFIX columnstore:) gtest_add_tests(TARGET counting_allocator TEST_PREFIX columnstore:)
set_source_files_properties(poolallocator.cpp PROPERTIES COMPILE_FLAGS "-Wno-sign-compare")
add_executable(poolallocator poolallocator.cpp) add_executable(poolallocator poolallocator.cpp)
target_compile_options(poolallocator PRIVATE -Wno-sign-compare)
add_dependencies(poolallocator googletest) add_dependencies(poolallocator googletest)
target_link_libraries(poolallocator ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES}) target_link_libraries(poolallocator ${ENGINE_LDFLAGS} ${ENGINE_WRITE_LIBS} ${GTEST_LIBRARIES})
gtest_add_tests(TARGET poolallocator TEST_PREFIX columnstore:) gtest_add_tests(TARGET poolallocator TEST_PREFIX columnstore:)
@ -101,7 +102,7 @@ if (WITH_UNITTESTS)
add_test(NAME columnstore:brm_em_standalone COMMAND brm_em_standalone) add_test(NAME columnstore:brm_em_standalone COMMAND brm_em_standalone)
set_tests_properties(columnstore:brm_em_standalone PROPERTIES DISABLED True) set_tests_properties(columnstore:brm_em_standalone PROPERTIES DISABLED True)
endif() endif()
# -Werror=sign-compare
if (WITH_MICROBENCHMARKS AND (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")) if (WITH_MICROBENCHMARKS AND (NOT CMAKE_BUILD_TYPE STREQUAL "Debug"))
find_package(benchmark REQUIRED) find_package(benchmark REQUIRED)
add_executable(primitives_scan_bench primitives_scan_bench.cpp) add_executable(primitives_scan_bench primitives_scan_bench.cpp)

1
utils/messageqcpp/bytestream.cpp
View File

@ -606,7 +606,6 @@ void ByteStream::swap(ByteStream& rhs)
std::swap(allocator, rhs.allocator); std::swap(allocator, rhs.allocator);
} }
// WIP use allocator
ifstream& operator>>(ifstream& ifs, ByteStream& bs) ifstream& operator>>(ifstream& ifs, ByteStream& bs)
{ {
int ifs_len; int ifs_len;