From d47df1b6dd471786aec01c2fc07a3c809ae3be2b Mon Sep 17 00:00:00 2001 From: Patrick LeBlanc Date: Fri, 3 Jan 2020 17:29:39 -0500 Subject: [PATCH] Noticed another deadlock possibility in PoolAllocator. Also currently not a problem. --- utils/common/poolallocator.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/utils/common/poolallocator.cpp b/utils/common/poolallocator.cpp index 170eb2e56..04f31121c 100644 --- a/utils/common/poolallocator.cpp +++ b/utils/common/poolallocator.cpp @@ -71,16 +71,11 @@ void * PoolAllocator::allocOOB(uint64_t size) bool _false = false; OOBMemInfo memInfo; - if (useLock) - while (!lock.compare_exchange_weak(_false, true, std::memory_order_acquire)) - _false = false; memUsage += size; memInfo.mem.reset(new uint8_t[size]); memInfo.size = size; void *ret = (void*) memInfo.mem.get(); oob[ret] = memInfo; - if (useLock) - lock.store(false, std::memory_order_release); return ret; }