database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

MCOL-98: Added error message for functions returning out of range values.

Browse Source
This commit is contained in:
Ben Thompson
2016-10-10 16:52:47 -05:00
parent 9606375939
commit d0e9cde782
5 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
utils/funcexp/func_div.cpp
View File

@ -34,6 +34,11 @@ using namespace std;
#include "rowgroup.h"
using namespace execplan;
#include "errorcodes.h"
#include "idberrorinfo.h"
#include "errorids.h"
using namespace logging;
#include "dataconvert.h"
namespace funcexp
@ -55,7 +60,7 @@ int64_t Func_div::getIntVal(rowgroup::Row& row,
if (int_val2 == 0)
{
isNull = true;
return 0;
return NULL;
}
int64_t int_val1 = (int64_t)(val1 > 0 ? val1 + 0.5 : val1 - 0.5);
// MCOL-176 If abs(int_val2) is small enough (like -1), then, this may cause overflow.
@ -78,7 +83,7 @@ uint64_t Func_div::getUintVal(rowgroup::Row& row,
if (val2 == 0)
{
isNull = true;
return 0;
return NULL;
}
return val1 / val2;
}