database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-5708 Calculate precision and scale for constant decimal.

Browse Source 
This patch calculates precision and scale for constant decimal
value for SUM aggregation function.
This commit is contained in:
Denis Khalikov
2024-06-11 14:47:24 +00:00
parent e5722b0f02
commit ccb7ba5914
5 changed files with 90 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
datatypes/mcs_datatype.cpp
View File

@ -66,6 +66,41 @@ int128_t TypeAttributesStd::decimal128FromString(const utils::NullString& value,
return decimal128FromString(value.unsafeStringRef(), saturate);
}
// SQL parser checks that given `value` is in a valid format.
// The first symbol can be `-`. The `value` can contain `.` symbol.
void decimalPrecisionAndScale(const utils::NullString& value, int& precision, int& scale)
{
if (value.isNull())
{
scale = 0;
precision = -1;
return;
}
const auto strValue = value.unsafeStringRef();
if (strValue.empty())
{
scale = 0;
precision = -1;
return;
}
const int len = strValue.size();
const auto dotIndex = strValue.find('.');
const int minExists = strValue.front() == '-' ? 1 : 0;
if (dotIndex == std::string::npos)
{
scale = 0;
precision = len - minExists;
}
else
{
scale = len - dotIndex - 1;
precision = len - 1 - minExists;
}
}
const string& TypeHandlerSInt8::name() const
{
static const string xname = "TINYINT";

2
datatypes/mcs_datatype.h
View File

@ -125,6 +125,8 @@ struct WidthToSIntegralType<16> : _WidthToSIntegralType<16, int128_t>
{
};
void decimalPrecisionAndScale(const utils::NullString& value, int &precision, int &scale);
// XXX: It is assumed here that ALL TYPES have width, scale and precision.
// XXX: And then some of them have the type tag itself.
// XXX: But, all types have type tag, some need explicit width (decimals, for example)