database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

Snapshotting the changes so far, we'll have to come back to it later.

Browse Source
This commit is contained in:
Patrick LeBlanc
2020-05-22 18:39:30 -04:00
parent faa35ebeeb
commit c2c23b8098
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
storage-manager/src/IOCoordinator.cpp
View File

@ -1061,6 +1061,10 @@ int IOCoordinator::copyFile(const char *_filename1, const char *_filename2)
for (const auto &object : objects) for (const auto &object : objects)
{ {
bf::path journalFile = journalPath/firstDir1/(object.key + ".journal"); bf::path journalFile = journalPath/firstDir1/(object.key + ".journal");
// XXXPAT: There is a risk from using the length in the key here. If SM got killed
// in the middle of a write, it will have the _intended_ length of the object, not the
// actual length.
// see MCOL-3459
metadataObject newObj = meta2.addMetadataObject(filename2, MetadataFile::getLengthFromKey(object.key)); metadataObject newObj = meta2.addMetadataObject(filename2, MetadataFile::getLengthFromKey(object.key));
assert(newObj.offset == object.offset); assert(newObj.offset == object.offset);
err = cs->copyObject(object.key, newObj.key); err = cs->copyObject(object.key, newObj.key);
@ -1081,6 +1085,7 @@ int IOCoordinator::copyFile(const char *_filename1, const char *_filename2)
ostringstream oss; ostringstream oss;
oss << "CopyFile: found a size mismatch in " << cachedObjPath << oss << "CopyFile: found a size mismatch in " << cachedObjPath <<
" real size = " << bf::file_size(cachedObjPath); " real size = " << bf::file_size(cachedObjPath);
// XXXPAT: get a new key here
logger->log(LOG_ERR, oss.str().c_str()); logger->log(LOG_ERR, oss.str().c_str());
} }