database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-02 17:22:27 +03:00
Code Activity

Took out the cache repopulate idea. Now we will only have warnings

Browse Source 
of problems.

I realized we can't reliably tell how big the cache is while the system
is running.  There's a window where write/append has added / is adding
a journal file but hasn't told Cache about it yet.  This capability will
have to wait for now.

This shouldn't be a problem because in theory, we will no longer have
data whose size is not consistent with metadata stored outside of the file.
If we do, it means there was either a hard failure, or SM was killed.
Either way, SM will be restarted and the cache will populate its meta
fresh then.
This commit is contained in:
Patrick LeBlanc
2020-05-22 08:06:04 -04:00
parent 3497191d0c
commit c29050899d
5 changed files with 11 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
storage-manager/src/Synchronizer.cpp
View File

@ -706,10 +706,8 @@ void Synchronizer::synchronizeWithJournal(const string &sourceFile, list<string>
ostringstream oss;
oss << "Synchronizer::synchronizeWithJournal(): detected a mismatch between file size and " <<
"length stored in the object name. object name = " << cloudKey << " length-in-name = " <<
MetadataFile::getLengthFromKey(cloudKey) << " real-length = " << bf::file_size(oldCachePath)
<< ". Reloading cache metadata, this will pause IO activity briefly.";
MetadataFile::getLengthFromKey(cloudKey) << " real-length = " << bf::file_size(oldCachePath);
logger->log(LOG_WARNING, oss.str().c_str());
cache->repopulate(prefix);
}
}