database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

MCOL-4823 WHERE char_col<varchar_col returns a wrong result of a large table (#2060)

Browse Source 
SCommand StrFilterCmd::duplicate() missed these two lines:

    filterCmd->leftColType = leftColType;
    filterCmd->rightColType = rightColType;

which exist in the parent's FilterCommand::duplicate().

Rewriting the code to avoid duplication by using more inherited
methods/constructors. This reduces the probability of similar bugs
in the future.
This commit is contained in:
Alexander Barkov
2021-08-03 12:53:05 +04:00
committed by GitHub
parent dffef34c78
commit c16b0f6ad7
10 changed files with 161 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
primitives/primproc/rtscommand.cpp
View File

@ -205,7 +205,7 @@ SCommand RTSCommand::duplicate()
rts->col.reset(ColumnCommandFabric::duplicate(col));
rts->dict = dict;
rts->Command::duplicate(this);
rts->Command::operator=(*this);
return ret;
}