database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

fix(datatypes, funcexp): Overflow detection for MCOL-5568 use case (and some other) (#2987)

Browse Source 
We add intermediate calculations in int128_t when target is UBIGINT and
check for overflow before converting into the UBIGINT. This is so
because we can overflow on addition and multiplication, with (some)
signed operands or both unsigned.
This commit is contained in:
Sergey Zefirov
2023-10-16 16:55:02 +03:00
committed by Leonid Fedorov
parent 441cd9d34f
commit b826fc1fd6
4 changed files with 217 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
dbcon/mysql/ha_mcs_execplan.cpp
View File

@ -3656,6 +3656,7 @@ ArithmeticColumn* buildArithmeticColumn(Item_func* item, gp_walk_info& gwi, bool
if (rc)
lhs = new ParseTree(rc);
}
rhs = new ParseTree(buildReturnedColumn(sfitempp[1], gwi, nonSupport));
if (!rhs->data() && (sfitempp[1]->type() == Item::FUNC_ITEM))