database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-01 06:46:55 +03:00
Code Activity

Revert "fix(aggregation, disk-based) MCOL-5691 distinct aggregate disk based (#3145)"

Browse Source 
This reverts commit c7caa4374f.
This commit is contained in:
Roman Nozdrin
2024-07-07 13:09:56 +00:00
parent ae20481aed
commit a5c12b98d7
7 changed files with 145 additions and 419 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
utils/rowgroup/rowaggregation.h
View File

@ -681,17 +681,6 @@ class RowAggregationUM : public RowAggregation
*/
bool nextRowGroup();
/** @brief Returns aggregated rows in a RowGroup as long as there are still not returned result RowGroups.
*
* This function should be called repeatedly until false is returned (meaning end of data).
* Returns data from in-memory storage, as well as spilled data from disk. If disk-based aggregation is
* happening, finalAggregation() should be called before returning result RowGroups to finalize the used
* RowAggStorages, merge different spilled generations and obtain correct aggregation results.
*
* @returns True if there are more result RowGroups, else false if all results have been returned.
*/
bool nextOutputRowGroup();
/** @brief Add an aggregator for DISTINCT aggregation
*/
void distinctAggregator(const boost::shared_ptr<RowAggregation>& da)