database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

chore(build): fixes to satisfy clang19 warnings

Browse Source
This commit is contained in:
Leonid Fedorov
2025-05-08 15:26:36 +00:00
committed by Leonid Fedorov
parent 9fd7f342a7
commit a0bee173f6
334 changed files with 3062 additions and 3323 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
writeengine/wrapper/we_colop.cpp
View File

@ -675,7 +675,7 @@ int ColumnOp::createColumn(Column& column, int colNo, int colWidth,
*
* @return
*/
int ColumnOp::fillColumn(const TxnID& txnid, Column& column, Column& refCol, void* defaultVal, Dctnry* dctnry,
int ColumnOp::fillColumn(const TxnID& /*txnid*/, Column& column, Column& refCol, void* defaultVal, Dctnry* dctnry,
ColumnOp* refColOp, const OID dictOid, const int dictColWidth,
const string defaultValStr, bool autoincrement)
{

2
writeengine/wrapper/we_colopcompress.cpp
View File

@ -63,7 +63,7 @@ ColumnOpCompress0::~ColumnOpCompress0()
IDBDataFile* ColumnOpCompress0::openFile(const Column& column, const uint16_t dbRoot,
const uint32_t partition, const uint16_t segment,
std::string& segFile, bool useTmpSuffix, const char* mode,
const int ioBuffSize, bool isReadOnly) const
const int /*ioBuffSize*/, bool /*isReadOnly*/) const
{
return FileOp::openFile(column.dataFile.fid, dbRoot, partition, segment, segFile, mode, column.colWidth,
useTmpSuffix);

14
writeengine/wrapper/writeengine.cpp
View File

@ -181,7 +181,7 @@ WriteEngineWrapper::~WriteEngineWrapper()
* NO_ERROR if success
* others if something wrong in the checking process
***********************************************************/
int WriteEngineWrapper::checkValid(const TxnID& txnid, const ColStructList& colStructList,
int WriteEngineWrapper::checkValid(const TxnID& /*txnid*/, const ColStructList& colStructList,
const ColValueList& colValueList, const RIDList& ridList) const
{
ColTupleList curTupleList;
@ -343,7 +343,7 @@ bool updateRangeCheckForInvalidity(ExtCPInfo* maxMin, InternalType value, Intern
* both arrays are present (update).
*/
void WriteEngineWrapper::updateMaxMinRange(const size_t totalNewRow, const size_t totalOldRow,
const execplan::CalpontSystemCatalog::ColType& cscColType,
const execplan::CalpontSystemCatalog::ColType& /*cscColType*/,
const ColType colType, const void* valArrayVoid,
const void* oldValArrayVoid, ExtCPInfo* maxMin,
bool canStartWithInvalidRange)
@ -1105,7 +1105,7 @@ inline void allocateValArray(void*& valArray, ColTupleList::size_type totalRow,
}
}
int WriteEngineWrapper::deleteBadRows(const TxnID& txnid, ColStructList& colStructs, RIDList& ridList,
int WriteEngineWrapper::deleteBadRows(const TxnID& /*txnid*/, ColStructList& colStructs, RIDList& ridList,
DctnryStructList& dctnryStructList)
{
/* Need to scan all files including dictionary store files to check whether there is any bad chunks
@ -1218,7 +1218,7 @@ static void log_this(const char *message,
/** @brief Determine whether we may update a column's ranges (by type) and return nullptr if we can't */
static ExtCPInfo* getCPInfoToUpdateForUpdatableType(const ColStruct& colStruct, ExtCPInfo* currentCPInfo,
OpType optype)
OpType /*optype*/)
{
if (colStruct.tokenFlag)
{
@ -6108,7 +6108,7 @@ int WriteEngineWrapper::tokenize(const TxnID& txnid, DctnryStruct& dctnryStruct,
* ERR_FILE_EXIST if file exists
* ERR_FILE_CREATE if something wrong in creating the file
***********************************************************/
int WriteEngineWrapper::createDctnry(const TxnID& txnid, const OID& dctnryOid, int colWidth, uint16_t dbRoot,
int WriteEngineWrapper::createDctnry(const TxnID& /*txnid*/, const OID& dctnryOid, int colWidth, uint16_t dbRoot,
uint32_t partiotion, uint16_t segment, int compressionType)
{
BRM::LBID_t startLbid;
@ -6198,7 +6198,7 @@ int WriteEngineWrapper::bulkRollback(OID tableOid, uint64_t lockID, const std::s
return rc;
}
int WriteEngineWrapper::rollbackCommon(const TxnID& txnid, int sessionId)
int WriteEngineWrapper::rollbackCommon(const TxnID& txnid, int /*sessionId*/)
{
// Remove the unwanted tmp files and recover compressed chunks.
string prefix;
@ -6588,7 +6588,7 @@ void WriteEngineWrapper::AddDictToList(const TxnID txnid, std::vector<BRM::LBID_
}
// Get CPInfo for given starting LBID and column description structure.
int WriteEngineWrapper::GetLBIDRange(const BRM::LBID_t startingLBID, const ColStruct& colStruct,
int WriteEngineWrapper::GetLBIDRange(const BRM::LBID_t startingLBID, const ColStruct& /*colStruct*/,
ExtCPInfo& cpInfo)
{
int rtn;

28
writeengine/wrapper/writeengine.h
View File

@ -124,9 +124,9 @@ class WriteEngineWrapper : public WEObj
* @brief Build a index from an oid file (NOTE: this is write engine internal used function, just for test
* purpose and not for generic use
*/
int buildIndex(const OID& colOid, const OID& treeOid, const OID& listOid,
execplan::CalpontSystemCatalog::ColDataType colDataType, int width, int hwm, bool resetFile,
uint64_t& totalRows, int maxRow = IDX_DEFAULT_READ_ROW)
int buildIndex(const OID& /*colOid*/, const OID& /*treeOid*/, const OID& /*listOid*/,
execplan::CalpontSystemCatalog::ColDataType /*colDataType*/, int /*width*/, int /*hwm*/, bool /*resetFile*/,
uint64_t& /*totalRows*/, int /*maxRow*/ = IDX_DEFAULT_READ_ROW)
{
return -1;
}
@ -134,10 +134,10 @@ class WriteEngineWrapper : public WEObj
/**
* @brief Build a index from a file
*/
int buildIndex(const std::string& sourceFileName, const OID& treeOid, const OID& listOid,
execplan::CalpontSystemCatalog::ColDataType colDataType, int width, int hwm, bool resetFile,
uint64_t& totalRows, const std::string& indexName, Log* pLogger,
int maxRow = IDX_DEFAULT_READ_ROW)
int buildIndex(const std::string& /*sourceFileName*/, const OID& /*treeOid*/, const OID& /*listOid*/,
execplan::CalpontSystemCatalog::ColDataType /*colDataType*/, int /*width*/, int /*hwm*/, bool /*resetFile*/,
uint64_t& /*totalRows*/, const std::string& /*indexName*/, Log* /*pLogger*/,
int /*maxRow*/ = IDX_DEFAULT_READ_ROW)
{
return -1;
}
@ -152,7 +152,7 @@ class WriteEngineWrapper : public WEObj
/**
* @brief Close a dictionary
*/
int closeDctnry(const TxnID& txnid, int i, bool realClose = true)
int closeDctnry(const TxnID& /*txnid*/, int i, bool realClose = true)
{
return m_dctnry[op(i)]->closeDctnry(realClose);
}
@ -220,7 +220,7 @@ class WriteEngineWrapper : public WEObj
* @param treeOid index tree file object id
* @param listOid index list file object id
*/
int createIndex(const TxnID& txnid, const OID& treeOid, const OID& listOid)
int createIndex(const TxnID& /*txnid*/, const OID& /*treeOid*/, const OID& /*listOid*/)
{
int rc = -1;
return rc;
@ -268,7 +268,7 @@ class WriteEngineWrapper : public WEObj
* @brief Drop a column, include object ids for column data file
* @param dataOid column datafile object id
*/
int dropColumn(const TxnID& txnid, const OID dataOid)
int dropColumn(const TxnID& /*txnid*/, const OID dataOid)
{
return m_colOp[0]->dropColumn((FID)dataOid);
}
@ -277,7 +277,7 @@ class WriteEngineWrapper : public WEObj
* @brief Drop files
* @param dataOids column and dictionary datafile object id
*/
int dropFiles(const TxnID& txnid, const std::vector<int32_t>& dataOids)
int dropFiles(const TxnID& /*txnid*/, const std::vector<int32_t>& dataOids)
{
return m_colOp[0]->dropFiles(dataOids);
}
@ -291,7 +291,7 @@ class WriteEngineWrapper : public WEObj
return m_colOp[0]->dropPartitions(dataOids, partitions);
}
int deleteOIDsFromExtentMap(const TxnID& txnid, const std::vector<int32_t>& dataOids)
int deleteOIDsFromExtentMap(const TxnID& /*txnid*/, const std::vector<int32_t>& dataOids)
{
return m_colOp[0]->deleteOIDsFromExtentMap(dataOids);
}
@ -301,7 +301,7 @@ class WriteEngineWrapper : public WEObj
* @param treeOid index tree file object id
* @param listOid index list file object id
*/
int dropIndex(const TxnID& txnid, const OID& treeOid, const OID& listOid)
int dropIndex(const TxnID& /*txnid*/, const OID& /*treeOid*/, const OID& /*listOid*/)
{
return -1;
}
@ -312,7 +312,7 @@ class WriteEngineWrapper : public WEObj
* @param treeOid dictionary tree file object id
* @param listOid index list file object id
*/
int dropDctnry(const TxnID& txnid, const OID& dctnryOid, const OID& treeOid, const OID& listOid)
int dropDctnry(const TxnID& /*txnid*/, const OID& dctnryOid, const OID& /*treeOid*/, const OID& /*listOid*/)
{
return m_dctnry[0]->dropDctnry(dctnryOid);
}