You've already forked mariadb-columnstore-engine
mirror of
https://github.com/mariadb-corporation/mariadb-columnstore-engine.git
synced 2025-07-30 19:23:07 +03:00
chore(build): fixes to satisfy clang19 warnings
This commit is contained in:
Leonid Fedorov
committed by
Leonid Fedorov
Leonid Fedorov
parent
9fd7f342a7
commit
a0bee173f6
@ -24,7 +24,7 @@
|
||||
#include <cerrno>
|
||||
#include <string>
|
||||
#include <map>
|
||||
//#define NDEBUG
|
||||
// #define NDEBUG
|
||||
#include <cassert>
|
||||
#include <algorithm>
|
||||
#include <unistd.h>
|
||||
@ -92,7 +92,7 @@ struct fileInfoCompare // lt operator
|
||||
|
||||
return false;
|
||||
} // operator
|
||||
}; // struct
|
||||
}; // struct
|
||||
|
||||
typedef std::map<File, IDBDataFile*, fileInfoCompare> FileOpenMap;
|
||||
|
||||
@ -563,7 +563,7 @@ int BRMWrapper::getBrmRc(bool reset)
|
||||
|
||||
#define MAX_VERSION_BUFFER_SIZE 1024
|
||||
|
||||
int BRMWrapper::copyVBBlock(IDBDataFile* pSourceFile, const OID sourceOid, IDBDataFile* pTargetFile,
|
||||
int BRMWrapper::copyVBBlock(IDBDataFile* pSourceFile, const OID /*sourceOid*/, IDBDataFile* pTargetFile,
|
||||
const OID targetOid, const std::vector<uint32_t>& fboList,
|
||||
const BRM::VBRange& freeList, size_t& nBlocksProcessed, DbFileOp* pFileOp,
|
||||
const size_t fboCurrentOffset)
|
||||
@ -713,7 +713,7 @@ int BRMWrapper::copyVBBlock(IDBDataFile* pSourceFile, const OID sourceOid, IDBDa
|
||||
}
|
||||
|
||||
int BRMWrapper::copyVBBlock(IDBDataFile* pSourceFile, IDBDataFile* pTargetFile, const uint64_t sourceFbo,
|
||||
const uint64_t targetFbo, DbFileOp* fileOp, const Column& column)
|
||||
const uint64_t targetFbo, DbFileOp* fileOp, const Column& /*column*/)
|
||||
{
|
||||
size_t rwSize;
|
||||
unsigned char buf[BYTE_PER_BLOCK];
|
||||
@ -731,14 +731,14 @@ int BRMWrapper::copyVBBlock(IDBDataFile* pSourceFile, IDBDataFile* pTargetFile,
|
||||
return NO_ERROR;
|
||||
}
|
||||
|
||||
uint8_t BRMWrapper::newCpimportJob(uint32_t &jobId)
|
||||
uint8_t BRMWrapper::newCpimportJob(uint32_t& jobId)
|
||||
{
|
||||
return blockRsltnMgrPtr->newCpimportJob(jobId);
|
||||
}
|
||||
|
||||
void BRMWrapper::finishCpimportJob(uint32_t jobId)
|
||||
{
|
||||
if (finishReported.exchange(true)) // get old and set to true; if old is true, do nothing.
|
||||
if (finishReported.exchange(true)) // get old and set to true; if old is true, do nothing.
|
||||
{
|
||||
return;
|
||||
}
|
||||
@ -1423,7 +1423,7 @@ cleanup:
|
||||
return rc;
|
||||
}
|
||||
|
||||
int BRMWrapper::rollBackVersion(const VER_t transID, int sessionId)
|
||||
int BRMWrapper::rollBackVersion(const VER_t transID, int /*sessionId*/)
|
||||
{
|
||||
std::vector<LBID_t> lbidList;
|
||||
std::vector<LBIDRange> lbidRangeList;
|
||||
|
||||
@ -169,9 +169,8 @@ void BulkRollbackFile::truncateSegmentFile(OID columnOID, uint32_t dbRoot, uint3
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error truncating column extents from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error truncating column extents from DB for" << ": OID-" << columnOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -264,9 +263,8 @@ void BulkRollbackFile::reInitTruncColumnExtent(OID columnOID, uint32_t dbRoot, u
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error rolling back HWM column extent from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error rolling back HWM column extent from DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -364,9 +362,9 @@ void BulkRollbackFile::reInitTruncDctnryExtent(OID dStoreOID, uint32_t dbRoot, u
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error rolling back HWM dictionary store extent from DB for"
|
||||
<< ": OID-" << dStoreOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error rolling back HWM dictionary store extent from DB for" << ": OID-" << dStoreOID
|
||||
<< "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; "
|
||||
<< ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -399,8 +397,8 @@ void BulkRollbackFile::reInitTruncDctnryExtent(OID dStoreOID, uint32_t dbRoot, u
|
||||
// class can override this functionality, and return true or false depending
|
||||
// on whether the HWM chunk was modified and backed up to disk.
|
||||
//------------------------------------------------------------------------------
|
||||
bool BulkRollbackFile::doWeReInitExtent(OID columnOID, uint32_t dbRoot, uint32_t partNum,
|
||||
uint32_t segNum) const
|
||||
bool BulkRollbackFile::doWeReInitExtent(OID /*columnOID*/, uint32_t /*dbRoot*/, uint32_t /*partNum*/,
|
||||
uint32_t /*segNum*/) const
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
@ -103,9 +103,8 @@ void BulkRollbackFileCompressed::truncateSegmentFile(OID columnOID, uint32_t dbR
|
||||
if (rc != NO_ERROR)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error reading compressed column ptr headers from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << errMsg;
|
||||
oss << "Error reading compressed column ptr headers from DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << errMsg;
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -121,9 +120,8 @@ void BulkRollbackFileCompressed::truncateSegmentFile(OID columnOID, uint32_t dbR
|
||||
if (!fCompressor)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error, wrong compression type for segment file"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << ";";
|
||||
oss << "Error, wrong compression type for segment file" << ": OID-" << columnOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << ";";
|
||||
throw WeException(oss.str(), ERR_COMP_WRONG_COMP_TYPE);
|
||||
}
|
||||
|
||||
@ -159,9 +157,8 @@ void BulkRollbackFileCompressed::truncateSegmentFile(OID columnOID, uint32_t dbR
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error writing compressed column headers to DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error writing compressed column headers to DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -174,9 +171,8 @@ void BulkRollbackFileCompressed::truncateSegmentFile(OID columnOID, uint32_t dbR
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error truncating compressed column extents from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error truncating compressed column extents from DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -211,9 +207,9 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
long long startOffset = startOffsetBlk * BYTE_PER_BLOCK;
|
||||
|
||||
std::ostringstream msgText1;
|
||||
msgText1 << "Reinit HWM compressed column extent in db file"
|
||||
<< ": dbRoot-" << dbRoot << "; part#-" << partNum << "; seg#-" << segNum << "; rawOffset(bytes)-"
|
||||
<< startOffset << "; rawFreeBlks-" << nBlocks;
|
||||
msgText1 << "Reinit HWM compressed column extent in db file" << ": dbRoot-" << dbRoot << "; part#-"
|
||||
<< partNum << "; seg#-" << segNum << "; rawOffset(bytes)-" << startOffset << "; rawFreeBlks-"
|
||||
<< nBlocks;
|
||||
fMgr->logAMessage(logging::LOG_TYPE_INFO, logging::M0075, columnOID, msgText1.str());
|
||||
|
||||
std::string segFile;
|
||||
@ -239,9 +235,8 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
if (rc != NO_ERROR)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error reading compressed column ptr headers from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << errMsg;
|
||||
oss << "Error reading compressed column ptr headers from DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << errMsg;
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -257,9 +252,8 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
if (!fCompressor)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error, wrong compression type for segment file"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << ";";
|
||||
oss << "Error, wrong compression type for segment file" << ": OID-" << columnOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << ";";
|
||||
throw WeException(oss.str(), ERR_COMP_WRONG_COMP_TYPE);
|
||||
}
|
||||
|
||||
@ -279,9 +273,9 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
if (rc != NO_ERROR)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error restoring HWM chunk for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; blkoff-" << blockOffset << "; " << errMsg;
|
||||
oss << "Error restoring HWM chunk for" << ": OID-" << columnOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << "; blkoff-" << blockOffset << "; "
|
||||
<< errMsg;
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -392,9 +386,8 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error writing compressed column headers to DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error writing compressed column headers to DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -407,9 +400,8 @@ void BulkRollbackFileCompressed::reInitTruncColumnExtent(OID columnOID, uint32_t
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error truncating compressed column extents from DB for"
|
||||
<< ": OID-" << columnOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error truncating compressed column extents from DB for" << ": OID-" << columnOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -510,9 +502,8 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
if (rc != NO_ERROR)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error reading compressed dctnry ptr headers from DB for"
|
||||
<< ": OID-" << dStoreOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << errMsg;
|
||||
oss << "Error reading compressed dctnry ptr headers from DB for" << ": OID-" << dStoreOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << errMsg;
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -528,9 +519,8 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
if (!fCompressor)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error, wrong compression type for segment file"
|
||||
<< ": OID-" << dStoreOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << ";";
|
||||
oss << "Error, wrong compression type for segment file" << ": OID-" << dStoreOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << ";";
|
||||
throw WeException(oss.str(), ERR_COMP_WRONG_COMP_TYPE);
|
||||
}
|
||||
|
||||
@ -547,8 +537,8 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
if (rc == ERR_FILE_NOT_EXIST)
|
||||
{
|
||||
std::ostringstream msgText3;
|
||||
msgText3 << "No restore needed to Compressed dictionary file"
|
||||
<< ": dbRoot-" << dbRoot << "; part#-" << partNum << "; seg#-" << segNum;
|
||||
msgText3 << "No restore needed to Compressed dictionary file" << ": dbRoot-" << dbRoot << "; part#-"
|
||||
<< partNum << "; seg#-" << segNum;
|
||||
fMgr->logAMessage(logging::LOG_TYPE_INFO, logging::M0075, dStoreOID, msgText3.str());
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
@ -558,9 +548,9 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
if (rc != NO_ERROR)
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Error restoring HWM chunk for"
|
||||
<< ": OID-" << dStoreOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; blkoff-" << blockOffset << "; " << errMsg;
|
||||
oss << "Error restoring HWM chunk for" << ": OID-" << dStoreOID << "; DbRoot-" << dbRoot
|
||||
<< "; partition-" << partNum << "; segment-" << segNum << "; blkoff-" << blockOffset << "; "
|
||||
<< errMsg;
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -590,8 +580,8 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
if (bAbbreviatedExtent) // log adjusted nBlock count for abbrev extent
|
||||
msgText2 << "; rawFreeBlks-" << nBlocks << " (abbrev)";
|
||||
|
||||
msgText2 << "; restoredChunk-" << restoredChunkLen << " bytes"
|
||||
<< "; truncated to " << fileSizeBytes << " bytes";
|
||||
msgText2 << "; restoredChunk-" << restoredChunkLen << " bytes" << "; truncated to " << fileSizeBytes
|
||||
<< " bytes";
|
||||
fMgr->logAMessage(logging::LOG_TYPE_INFO, logging::M0075, dStoreOID, msgText2.str());
|
||||
|
||||
// Initialize the remainder of the extent after the HWM chunk
|
||||
@ -653,9 +643,8 @@ void BulkRollbackFileCompressed::reInitTruncDctnryExtent(OID dStoreOID, uint32_t
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error writing compressed dictionary headers to DB for"
|
||||
<< ": OID-" << dStoreOID << "; DbRoot-" << dbRoot << "; partition-" << partNum << "; segment-"
|
||||
<< segNum << "; " << ec.errorString(rc);
|
||||
oss << "Error writing compressed dictionary headers to DB for" << ": OID-" << dStoreOID << "; DbRoot-"
|
||||
<< dbRoot << "; partition-" << partNum << "; segment-" << segNum << "; " << ec.errorString(rc);
|
||||
|
||||
fDbFile.closeFile(pFile);
|
||||
throw WeException(oss.str(), rc);
|
||||
@ -838,8 +827,8 @@ int BulkRollbackFileCompressed::restoreHWMChunk(IDBDataFile* pFile, OID columnOI
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error setting column file offset"
|
||||
<< "; offset-" << fileOffsetByteForRestoredChunk << "; " << ec.errorString(rc);
|
||||
oss << "Error setting column file offset" << "; offset-" << fileOffsetByteForRestoredChunk << "; "
|
||||
<< ec.errorString(rc);
|
||||
errMsg = oss.str();
|
||||
|
||||
delete backupFile;
|
||||
@ -877,9 +866,8 @@ int BulkRollbackFileCompressed::restoreHWMChunk(IDBDataFile* pFile, OID columnOI
|
||||
{
|
||||
WErrorCodes ec;
|
||||
std::ostringstream oss;
|
||||
oss << "Error writing to column file"
|
||||
<< "; offset-" << fileOffsetByteForRestoredChunk << "; bytes-" << restoredChunkLen << "; "
|
||||
<< ec.errorString(rc);
|
||||
oss << "Error writing to column file" << "; offset-" << fileOffsetByteForRestoredChunk << "; bytes-"
|
||||
<< restoredChunkLen << "; " << ec.errorString(rc);
|
||||
errMsg = oss.str();
|
||||
|
||||
delete backupFile;
|
||||
@ -898,7 +886,7 @@ int BulkRollbackFileCompressed::restoreHWMChunk(IDBDataFile* pFile, OID columnOI
|
||||
// the backup file is not found, we assume that it's because one was not created
|
||||
// and thus not needed.
|
||||
//------------------------------------------------------------------------------
|
||||
bool BulkRollbackFileCompressed::doWeReInitExtent(OID columnOID, uint32_t dbRoot, uint32_t partNum,
|
||||
bool BulkRollbackFileCompressed::doWeReInitExtent(OID columnOID, uint32_t /*dbRoot*/, uint32_t partNum,
|
||||
uint32_t segNum) const
|
||||
{
|
||||
std::ostringstream oss;
|
||||
|
||||
@ -98,15 +98,15 @@ void BulkRollbackFileCompressedHdfs::truncateSegmentFile(OID columnOID, uint32_t
|
||||
void BulkRollbackFileCompressedHdfs::reInitTruncColumnExtent(OID columnOID, uint32_t dbRoot, uint32_t partNum,
|
||||
uint32_t segNum, long long startOffsetBlk,
|
||||
int nBlocks,
|
||||
CalpontSystemCatalog::ColDataType colType,
|
||||
uint32_t colWidth, bool restoreHwmChk)
|
||||
CalpontSystemCatalog::ColDataType /*colType*/,
|
||||
uint32_t /*colWidth*/, bool /*restoreHwmChk*/)
|
||||
{
|
||||
long long startOffset = startOffsetBlk * BYTE_PER_BLOCK;
|
||||
|
||||
std::ostringstream msgText;
|
||||
msgText << "Reinit HWM compressed column extent in HDFS db file"
|
||||
<< ": dbRoot-" << dbRoot << "; part#-" << partNum << "; seg#-" << segNum << "; rawOffset(bytes)-"
|
||||
<< startOffset << "; rawFreeBlks-" << nBlocks;
|
||||
msgText << "Reinit HWM compressed column extent in HDFS db file" << ": dbRoot-" << dbRoot << "; part#-"
|
||||
<< partNum << "; seg#-" << segNum << "; rawOffset(bytes)-" << startOffset << "; rawFreeBlks-"
|
||||
<< nBlocks;
|
||||
fMgr->logAMessage(logging::LOG_TYPE_INFO, logging::M0075, columnOID, msgText.str());
|
||||
|
||||
restoreFromBackup("column", columnOID, dbRoot, partNum, segNum);
|
||||
@ -146,8 +146,8 @@ void BulkRollbackFileCompressedHdfs::reInitTruncDctnryExtent(OID dStoreOID, uint
|
||||
// Let ConfirmHdfsDbFile later determine when/if/how to restore from any
|
||||
// existing backup file.
|
||||
//------------------------------------------------------------------------------
|
||||
bool BulkRollbackFileCompressedHdfs::doWeReInitExtent(OID columnOID, uint32_t dbRoot, uint32_t partNum,
|
||||
uint32_t segNum) const
|
||||
bool BulkRollbackFileCompressedHdfs::doWeReInitExtent(OID /*columnOID*/, uint32_t /*dbRoot*/,
|
||||
uint32_t /*partNum*/, uint32_t /*segNum*/) const
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
@ -116,7 +116,7 @@ class Cache
|
||||
/**
|
||||
* @brief Get the cache key
|
||||
*/
|
||||
static CacheKey getCacheKey(const OID oid, const uint64_t lbid)
|
||||
static CacheKey getCacheKey(const OID /*oid*/, const uint64_t lbid)
|
||||
{
|
||||
CacheKey key = lbid; /*Convertor::int2Str( oid ) + "|" + Convertor::int2Str(lbid)*/
|
||||
;
|
||||
|
||||
@ -360,7 +360,7 @@ CompFileData* ChunkManager::getFileDataByName(const std::string& filename, const
|
||||
|
||||
|
||||
CompFileData* ChunkManager::getFileData_(const FileID& fileID, const string& filename, const char* mode,
|
||||
int size, const CalpontSystemCatalog::ColDataType colDataType,
|
||||
const int /*size*/, const CalpontSystemCatalog::ColDataType colDataType,
|
||||
int colWidth, bool useTmpSuffix, bool dctnry, bool isReadOnly) const
|
||||
{
|
||||
CompFileData* fileData = new CompFileData(fileID, fileID.fFid, colDataType, colWidth, isReadOnly);
|
||||
@ -433,7 +433,7 @@ CompFileData* ChunkManager::getFileData_(const FileID& fileID, const string& fil
|
||||
//------------------------------------------------------------------------------
|
||||
IDBDataFile* ChunkManager::createDctnryFile(const FID& fid, int64_t width, uint16_t root, uint32_t partition,
|
||||
uint16_t segment, const char* filename, const char* mode,
|
||||
int size, BRM::LBID_t lbid)
|
||||
const int /*size*/, BRM::LBID_t lbid)
|
||||
{
|
||||
FileID fileID(fid, root, partition, segment);
|
||||
CompFileData* fileData = new CompFileData(fileID, fid, CalpontSystemCatalog::VARCHAR, width);
|
||||
|
||||
@ -248,7 +248,7 @@ const std::string Convertor::int2Str(int val)
|
||||
******************************************************************************/
|
||||
/* static */
|
||||
|
||||
long long Convertor::convertDecimalString(const char* field, int fieldLength, int scale)
|
||||
long long Convertor::convertDecimalString(const char* field, int /*fieldLength*/, int scale)
|
||||
{
|
||||
long double dval = strtold(field, nullptr);
|
||||
long long ret = 0;
|
||||
|
||||
@ -304,7 +304,7 @@ int DbFileOp::writeDBFileNoVBCache(CommBlock& cb, const unsigned char* writeBuf,
|
||||
* Core function for writing data w/o using VB cache
|
||||
* (bulk load dictionary store inserts)
|
||||
***********************************************************/
|
||||
int DbFileOp::writeDBFileNoVBCache(IDBDataFile* pFile, const unsigned char* writeBuf, const int fbo,
|
||||
int DbFileOp::writeDBFileNoVBCache(IDBDataFile* pFile, const unsigned char* writeBuf, const int /*fbo*/,
|
||||
const int numOfBlock)
|
||||
{
|
||||
#ifdef PROFILE
|
||||
|
||||
@ -321,7 +321,7 @@ int DBRootExtentTracker::selectFirstSegFile(DBRootExtentInfo& dbRootExtent, bool
|
||||
// Mutex lock not needed in this function as it is only called from main thread
|
||||
// before processing threads are spawned.
|
||||
//------------------------------------------------------------------------------
|
||||
int DBRootExtentTracker::selectFirstSegFileForEmptyPM(std::string& errMsg)
|
||||
int DBRootExtentTracker::selectFirstSegFileForEmptyPM(std::string& /*errMsg*/)
|
||||
{
|
||||
fEmptyOrDisabledPM = true;
|
||||
|
||||
|
||||
@ -114,7 +114,7 @@ void FileOp::closeFile(IDBDataFile* pFile) const
|
||||
* RETURN:
|
||||
* NO_ERROR if success, otherwise if fail
|
||||
***********************************************************/
|
||||
int FileOp::createDir(const char* dirName, mode_t mode) const
|
||||
int FileOp::createDir(const char* dirName, mode_t /*mode*/) const
|
||||
{
|
||||
boost::mutex::scoped_lock lk(m_mkdirMutex);
|
||||
int rc = IDBPolicy::mkdir(dirName);
|
||||
@ -378,7 +378,7 @@ int FileOp::deleteFiles(const std::vector<int32_t>& fids) const
|
||||
* NO_ERROR if success
|
||||
* ERR_DM_CONVERT_OID if error occurs converting OID to file name
|
||||
***********************************************************/
|
||||
int FileOp::deletePartitions(const std::vector<OID>& fids,
|
||||
int FileOp::deletePartitions(const std::vector<OID>& /*fids*/,
|
||||
const std::vector<BRM::PartitionInfo>& partitions) const
|
||||
{
|
||||
char tempFileName[FILE_NAME_SIZE];
|
||||
@ -578,9 +578,9 @@ int FileOp::extendFile(OID oid, const uint8_t* emptyVal, int width,
|
||||
if (isDebug(DEBUG_1) && getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Opening existing column file (extendFile)"
|
||||
<< ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment
|
||||
<< "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
oss << "Opening existing column file (extendFile)" << ": OID-" << oid << "; DBRoot-" << dbRoot
|
||||
<< "; part-" << partition << "; seg-" << segment << "; LBID-" << startLbid << "; hwm-" << hwm
|
||||
<< "; file-" << segFile;
|
||||
getLogger()->logMsg(oss.str(), MSGLVL_INFO2);
|
||||
}
|
||||
|
||||
@ -637,9 +637,9 @@ int FileOp::extendFile(OID oid, const uint8_t* emptyVal, int width,
|
||||
if (getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "FileOp::extendFile: error padding partial compressed extent for "
|
||||
<< "column OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-"
|
||||
<< segment << "; hwm-" << hwm << " " << failedTask.c_str();
|
||||
oss << "FileOp::extendFile: error padding partial compressed extent for " << "column OID-" << oid
|
||||
<< "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment << "; hwm-" << hwm
|
||||
<< " " << failedTask.c_str();
|
||||
getLogger()->logMsg(oss.str(), rc, MSGLVL_CRITICAL);
|
||||
}
|
||||
|
||||
@ -690,9 +690,9 @@ int FileOp::extendFile(OID oid, const uint8_t* emptyVal, int width,
|
||||
if (getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "FileOp::extendFile: error padding partial uncompressed extent for "
|
||||
<< "column OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-"
|
||||
<< segment << "; hwm-" << hwm;
|
||||
oss << "FileOp::extendFile: error padding partial uncompressed extent for " << "column OID-"
|
||||
<< oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment << "; hwm-"
|
||||
<< hwm;
|
||||
getLogger()->logMsg(oss.str(), rc, MSGLVL_CRITICAL);
|
||||
}
|
||||
|
||||
@ -723,9 +723,8 @@ int FileOp::extendFile(OID oid, const uint8_t* emptyVal, int width,
|
||||
if (isDebug(DEBUG_1) && getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Opening new column file"
|
||||
<< ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment
|
||||
<< "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
oss << "Opening new column file" << ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition
|
||||
<< "; seg-" << segment << "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
getLogger()->logMsg(oss.str(), MSGLVL_INFO2);
|
||||
}
|
||||
|
||||
@ -818,9 +817,9 @@ int FileOp::addExtentExactFile(OID oid, const uint8_t* emptyVal, int width, int&
|
||||
if (isDebug(DEBUG_1) && getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Opening existing column file"
|
||||
<< ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment
|
||||
<< "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
oss << "Opening existing column file" << ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-"
|
||||
<< partition << "; seg-" << segment << "; LBID-" << startLbid << "; hwm-" << hwm << "; file-"
|
||||
<< segFile;
|
||||
getLogger()->logMsg(oss.str(), MSGLVL_INFO2);
|
||||
}
|
||||
|
||||
@ -848,9 +847,8 @@ int FileOp::addExtentExactFile(OID oid, const uint8_t* emptyVal, int width, int&
|
||||
if (isDebug(DEBUG_1) && getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Opening new column file"
|
||||
<< ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment
|
||||
<< "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
oss << "Opening new column file" << ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition
|
||||
<< "; seg-" << segment << "; LBID-" << startLbid << "; hwm-" << hwm << "; file-" << segFile;
|
||||
getLogger()->logMsg(oss.str(), MSGLVL_INFO2);
|
||||
}
|
||||
|
||||
@ -1290,9 +1288,9 @@ int FileOp::fillCompColumnExtentEmptyChunks(OID oid, int colWidth, const uint8_t
|
||||
if (getLogger())
|
||||
{
|
||||
std::ostringstream oss;
|
||||
oss << "Converting abbreviated partial extent to full extent for"
|
||||
<< ": OID-" << oid << "; DBRoot-" << dbRoot << "; part-" << partition << "; seg-" << segment
|
||||
<< "; file-" << segFile << "; wid-" << colWidth << "; oldBlkCnt-" << blkCount << "; newBlkCnt-"
|
||||
oss << "Converting abbreviated partial extent to full extent for" << ": OID-" << oid << "; DBRoot-"
|
||||
<< dbRoot << "; part-" << partition << "; seg-" << segment << "; file-" << segFile << "; wid-"
|
||||
<< colWidth << "; oldBlkCnt-" << blkCount << "; newBlkCnt-"
|
||||
<< ((ROWS_PER_EXTENT * colWidth) / BYTE_PER_BLOCK);
|
||||
getLogger()->logMsg(oss.str(), MSGLVL_INFO2);
|
||||
}
|
||||
@ -1652,7 +1650,7 @@ int FileOp::writeHeaders(IDBDataFile* pFile, const char* controlHdr, const char*
|
||||
* else returns NO_ERROR.
|
||||
***********************************************************/
|
||||
int FileOp::initDctnryExtent(IDBDataFile* pFile, uint16_t dbRoot, int nBlocks, unsigned char* blockHdrInit,
|
||||
int blockHdrInitSize, bool bExpandExtent, bool bOptExtension, int64_t lbid)
|
||||
int blockHdrInitSize, bool /*bExpandExtent*/, bool bOptExtension, int64_t lbid)
|
||||
{
|
||||
// @bug5769 Don't initialize extents or truncate db files on HDFS
|
||||
if (idbdatafile::IDBPolicy::useHdfs())
|
||||
@ -2628,17 +2626,17 @@ void FileOp::setBulkFlag(bool isBulkLoad)
|
||||
m_isBulk = isBulkLoad;
|
||||
}
|
||||
|
||||
int FileOp::flushFile(int rc, std::map<FID, FID>& oids)
|
||||
int FileOp::flushFile(int /*rc*/, std::map<FID, FID>& /*oids*/)
|
||||
{
|
||||
return NO_ERROR;
|
||||
}
|
||||
|
||||
int FileOp::updateColumnExtent(IDBDataFile* pFile, int nBlocks, int64_t lbid)
|
||||
int FileOp::updateColumnExtent(IDBDataFile* /*pFile*/, int /*nBlocks*/, int64_t /*lbid*/)
|
||||
{
|
||||
return NO_ERROR;
|
||||
}
|
||||
|
||||
int FileOp::updateDctnryExtent(IDBDataFile* pFile, int nBlocks, int64_t lbid)
|
||||
int FileOp::updateDctnryExtent(IDBDataFile* /*pFile*/, int /*nBlocks*/, int64_t /*lbid*/)
|
||||
{
|
||||
return NO_ERROR;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user