database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

chore(build): fixes to satisfy clang19 warnings

Browse Source
This commit is contained in:
Leonid Fedorov
2025-05-08 15:26:36 +00:00
committed by Leonid Fedorov
parent 9fd7f342a7
commit a0bee173f6
334 changed files with 3062 additions and 3323 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
versioning/BRM/blockresolutionmanager.cpp
View File

@ -61,20 +61,10 @@ BlockResolutionManager::BlockResolutionManager(bool ronly) throw()
}
}
BlockResolutionManager::BlockResolutionManager(const BlockResolutionManager& brm)
{
throw logic_error("BRM: Don't use the copy constructor.");
}
BlockResolutionManager::~BlockResolutionManager() throw()
{
}
BlockResolutionManager& BlockResolutionManager::operator=(const BlockResolutionManager& brm)
{
throw logic_error("BRM: Don't use the = operator.");
}
int BlockResolutionManager::loadExtentMap(const string& filename, bool fixFL)
{
em.load(filename, fixFL);

5
versioning/BRM/blockresolutionmanager.h
View File

@ -107,8 +107,9 @@ class BlockResolutionManager
EXPORT int saveState(std::string filename) throw();
private:
explicit BlockResolutionManager(const BlockResolutionManager& brm);
BlockResolutionManager& operator=(const BlockResolutionManager& brm);
explicit BlockResolutionManager(const BlockResolutionManager&) = delete;
BlockResolutionManager& operator=(const BlockResolutionManager&) = delete;
MasterSegmentTable mst;
ExtentMap em;
VBBM vbbm;

4
versioning/BRM/brmshmimpl.cpp
View File

@ -343,7 +343,7 @@ int BRMManagedShmImpl::grow(off_t newSize)
}
// Dummy method that has no references in the code.
int BRMManagedShmImpl::clear(unsigned newKey, off_t newSize)
int BRMManagedShmImpl::clear(unsigned /*newKey*/, off_t /*newSize*/)
{
return 0;
}
@ -471,7 +471,7 @@ int32_t BRMManagedShmImplRBTree::grow(unsigned key, off_t incSize)
}
// Dummy method that has no references in the code.
int BRMManagedShmImplRBTree::clear(unsigned newKey, off_t newSize)
int BRMManagedShmImplRBTree::clear(unsigned /*newKey*/, off_t /*newSize*/)
{
return 0;
}

10
versioning/BRM/dbrm.cpp
View File

@ -95,22 +95,12 @@ DBRM::DBRM(bool noBRMinit) : fDebug(false)
#endif
}
DBRM::DBRM(const DBRM& brm)
{
throw logic_error("DBRM: Don't use the copy constructor.");
}
DBRM::~DBRM()
{
if (msgClient != NULL)
MessageQueueClientPool::releaseInstance(msgClient);
}
DBRM& DBRM::operator=(const DBRM& brm)
{
throw logic_error("DBRM: Don't use the = operator.");
}
int DBRM::saveState() throw()
{
#ifdef BRM_INFO

6
versioning/BRM/dbrm.h
View File

@ -1000,8 +1000,8 @@ class DBRM
size_t EMIndexShmemFree();
private:
DBRM(const DBRM& brm);
DBRM& operator=(const DBRM& brm);
DBRM(const DBRM& brm) = delete;
DBRM& operator=(const DBRM& brm) = delete;
int8_t send_recv(const messageqcpp::ByteStream& in, messageqcpp::ByteStream& out) throw();
void deleteAISequence(uint32_t OID); // called as part of deleteOID & deleteOIDs
@ -1015,7 +1015,7 @@ class DBRM
std::string masterName;
boost::mutex mutex;
config::Config* config;
bool fDebug;
[[maybe_unused]]bool fDebug;
};
} // namespace BRM

13
versioning/BRM/extentmap.cpp
View File

@ -812,7 +812,7 @@ int ExtentMap::markInvalid(const vector<LBID_t>& lbids,
// TODO MCOL-641 Not adding support here since this function appears to be unused anywhere.
int ExtentMap::setMaxMin(const LBID_t lbid, const int64_t max, const int64_t min, const int32_t seqNum,
bool firstNode)
bool /*firstNode*/)
{
#ifdef BRM_INFO
@ -884,7 +884,7 @@ int ExtentMap::setMaxMin(const LBID_t lbid, const int64_t max, const int64_t min
// @bug 1970. Added updateExtentsMaxMin function.
// @note - The key passed in the map must the the first LBID in the extent.
void ExtentMap::setExtentsMaxMin(const CPMaxMinMap_t& cpMap, bool firstNode, bool useLock)
void ExtentMap::setExtentsMaxMin(const CPMaxMinMap_t& cpMap, bool /*firstNode*/, bool useLock)
{
CPMaxMinMap_t::const_iterator it;
@ -1580,7 +1580,6 @@ void ExtentMap::loadVersion4or5(T* in, bool upgradeV4ToV5)
cout << "Expected EM entries:" << emNumElements << endl;
cout << "Expected free list entries:" << flNumElements << endl;
if (nbytes != (2 * sizeof(uint32_t)))
{
log_errno("ExtentMap::loadVersion4or5(): read ");
@ -1700,7 +1699,7 @@ void ExtentMap::loadVersion4or5(T* in, bool upgradeV4ToV5)
fEMRBTreeShminfo->currentSize = (emNumElements * EM_RB_TREE_NODE_SIZE) + EM_RB_TREE_EMPTY_SIZE;
}
void ExtentMap::load(const string& filename, bool fixFL)
void ExtentMap::load(const string& filename, bool /*fixFL*/)
{
#ifdef BRM_INFO
@ -4783,8 +4782,8 @@ HWM_t ExtentMap::getLocalHWM(int OID, uint32_t partitionNum, uint16_t segmentNum
// (per segment file).
// Used for dictionary or column OIDs to set the HWM for specific segment file.
//------------------------------------------------------------------------------
void ExtentMap::setLocalHWM(int OID, uint32_t partitionNum, uint16_t segmentNum, HWM_t newHWM, bool firstNode,
bool uselock)
void ExtentMap::setLocalHWM(int OID, uint32_t partitionNum, uint16_t segmentNum, HWM_t newHWM,
bool /*firstNode*/, bool uselock)
{
#ifdef BRM_INFO
@ -4945,7 +4944,7 @@ void ExtentMap::bulkUpdateDBRoot(const vector<BulkUpdateDBRootArg>& args)
}
}
void ExtentMap::getExtents(int OID, vector<struct EMEntry>& entries, bool sorted, bool notFoundErr,
void ExtentMap::getExtents(int OID, vector<struct EMEntry>& entries, bool sorted, bool /*notFoundErr*/,
bool incOutOfService)
{
#ifdef BRM_INFO

11
versioning/BRM/lbidresourcegraph.cpp
View File

@ -35,11 +35,6 @@ LBIDResourceGraph::LBIDResourceGraph() : color(0)
{
}
LBIDResourceGraph::LBIDResourceGraph(const LBIDResourceGraph& r)
{
throw logic_error("Don't do that");
}
LBIDResourceGraph::~LBIDResourceGraph()
{
std::map<VER_t, TransactionNode*>::iterator tnit;
@ -69,12 +64,6 @@ LBIDResourceGraph::~LBIDResourceGraph()
resources.erase(rit++);
}
}
LBIDResourceGraph& LBIDResourceGraph::operator=(const LBIDResourceGraph& r)
{
throw logic_error("Don't do that");
}
void LBIDResourceGraph::connectResources(LBID_t start, LBID_t end, TransactionNode* txnNode)
{
vector<ResourceNode*> intersection, reserveList;

4
versioning/BRM/lbidresourcegraph.h
View File

@ -58,8 +58,8 @@ class LBIDResourceGraph
private:
uint64_t color;
LBIDResourceGraph(const LBIDResourceGraph&);
LBIDResourceGraph& operator=(const LBIDResourceGraph&);
LBIDResourceGraph(const LBIDResourceGraph&) = delete;
LBIDResourceGraph& operator=(const LBIDResourceGraph&) = delete;
void connectResources(LBID_t start, LBID_t end, TransactionNode* txnNode);
bool checkDeadlock(TransactionNode&);

28
versioning/BRM/masterdbrmnode.cpp
View File

@ -115,16 +115,6 @@ MasterDBRMNode::~MasterDBRMNode()
finalCleanup();
}
MasterDBRMNode::MasterDBRMNode(const MasterDBRMNode& m)
{
throw logic_error("Don't use the MasterDBRMNode copy constructor");
}
MasterDBRMNode& MasterDBRMNode::operator=(const MasterDBRMNode& m)
{
throw logic_error("Don't use the MasterDBRMNode = operator");
}
void MasterDBRMNode::initMsgQueues(config::Config* config)
{
std::string methodName("MasterDBRMNode::initMsgQueues()");
@ -1307,7 +1297,7 @@ void MasterDBRMNode::doReload(messageqcpp::IOSocket* sock)
}
}
void MasterDBRMNode::doVerID(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doVerID(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
QueryContext context;
@ -1329,7 +1319,7 @@ void MasterDBRMNode::doVerID(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doGetSystemCatalog(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doGetSystemCatalog(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
@ -1403,7 +1393,7 @@ void MasterDBRMNode::doGetSystemCatalog(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doSysCatVerID(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doSysCatVerID(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
QueryContext context;
@ -1708,7 +1698,7 @@ void MasterDBRMNode::doGetTxnID(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doSIDTIDMap(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doSIDTIDMap(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
int len, i;
@ -1885,7 +1875,7 @@ void MasterDBRMNode::doGetUncommittedLbids(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doGetUniqueUint32(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doGetUniqueUint32(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
uint32_t ret;
@ -1924,7 +1914,7 @@ void MasterDBRMNode::doGetUniqueUint32(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doGetUniqueUint64(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doGetUniqueUint64(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
uint64_t ret;
@ -1963,7 +1953,7 @@ void MasterDBRMNode::doGetUniqueUint64(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doGetSystemState(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doGetSystemState(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
uint32_t ss = 0;
@ -2092,7 +2082,7 @@ void MasterDBRMNode::doClearSystemState(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doSessionManagerReset(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doSessionManagerReset(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
@ -2191,7 +2181,7 @@ void MasterDBRMNode::doReturnOIDs(ByteStream& msg, ThreadParams* p)
}
}
void MasterDBRMNode::doOidmSize(ByteStream& msg, ThreadParams* p)
void MasterDBRMNode::doOidmSize(ByteStream& /*msg*/, ThreadParams* p)
{
ByteStream reply;
int ret;

4
versioning/BRM/masterdbrmnode.h
View File

@ -165,8 +165,8 @@ class MasterDBRMNode
boost::thread* t;
};
MasterDBRMNode(const MasterDBRMNode& m);
MasterDBRMNode& operator=(const MasterDBRMNode& m);
MasterDBRMNode(const MasterDBRMNode& m) = delete;
MasterDBRMNode& operator=(const MasterDBRMNode& m) = delete;
void initMsgQueues(config::Config* config);
void msgProcessor();

4
versioning/BRM/masternode.cpp
View File

@ -83,7 +83,7 @@ class ServiceControllerNode : public Service, public Opt
}
};
void stop(int num)
void stop(int /*num*/)
{
#ifdef BRM_VERBOSE
std::cerr << "stopping..." << std::endl;
@ -94,7 +94,7 @@ void stop(int num)
m->stop();
}
void restart(int num)
void restart(int /*num*/)
{
#ifdef BRM_VERBOSE
std::cerr << "stopping this instance..." << std::endl;

4
versioning/BRM/oidserver.cpp
View File

@ -722,7 +722,9 @@ int OIDServer::allocOIDs(int num)
return bestMatchBegin;
}
void OIDServer::returnOIDs(int start, int end) const
// FIXME: Not implemented
void OIDServer::returnOIDs(int /*start*/, int /*end*/) const
{
//@Bug 1412. Do not reuse oids for now.
/* struct FEntry freelist[FreeListEntries];

12
versioning/BRM/slavedbrmnode.cpp
View File

@ -57,20 +57,10 @@ SlaveDBRMNode::SlaveDBRMNode() throw()
locked[2] = false;
}
SlaveDBRMNode::SlaveDBRMNode(const SlaveDBRMNode& brm)
{
throw logic_error("WorkerDBRMNode: Don't use the copy constructor.");
}
SlaveDBRMNode::~SlaveDBRMNode() throw()
{
}
SlaveDBRMNode& SlaveDBRMNode::operator=(const SlaveDBRMNode& brm)
{
throw logic_error("WorkerDBRMNode: Don't use the = operator.");
}
int SlaveDBRMNode::lookup(OID_t oid, LBIDRange_v& lbidList) throw()
{
try
@ -713,7 +703,7 @@ int SlaveDBRMNode::beginVBCopy(VER_t transID, uint16_t vbOID, const LBIDRange_v&
}
}
int SlaveDBRMNode::endVBCopy(VER_t transID, const LBIDRange_v& ranges) throw()
int SlaveDBRMNode::endVBCopy(VER_t /*transID*/, const LBIDRange_v& ranges) throw()
{
LBIDRange_v::const_iterator it;

4
versioning/BRM/slavedbrmnode.h
View File

@ -462,8 +462,8 @@ class SlaveDBRMNode
EXPORT const std::atomic<bool>* getVSSLockStatus();
private:
explicit SlaveDBRMNode(const SlaveDBRMNode& brm);
SlaveDBRMNode& operator=(const SlaveDBRMNode& brm);
explicit SlaveDBRMNode(const SlaveDBRMNode& brm) = delete;
SlaveDBRMNode& operator=(const SlaveDBRMNode& brm) = delete;
int lookup(OID_t oid, LBIDRange_v& lbidList) throw();
MasterSegmentTable mst;

16
versioning/BRM/slavenode.cpp
View File

@ -84,7 +84,7 @@ class ServiceWorkerNode : public Service, public Opt
}
};
void stop(int sig)
void stop(int /*sig*/)
{
if (!die)
{
@ -94,7 +94,7 @@ void stop(int sig)
}
}
void reset(int sig)
void reset(int /*sig*/)
{
comm->reset();
}
@ -140,10 +140,14 @@ int ServiceWorkerNode::Child()
}
/* Start 4 threads to monitor write lock state */
monitorThreads.create_thread(RWLockMonitor(&die, comm->getSlaveNode().getEMFLLockStatus(), keys.KEYRANGE_EMFREELIST_BASE));
monitorThreads.create_thread(RWLockMonitor(&die, comm->getSlaveNode().getEMLockStatus(), keys.KEYRANGE_EXTENTMAP_BASE));
monitorThreads.create_thread(RWLockMonitor(&die, comm->getSlaveNode().getVBBMLockStatus(), keys.KEYRANGE_VBBM_BASE));
monitorThreads.create_thread(RWLockMonitor(&die, comm->getSlaveNode().getVSSLockStatus(), keys.KEYRANGE_VSS_BASE));
monitorThreads.create_thread(
RWLockMonitor(&die, comm->getSlaveNode().getEMFLLockStatus(), keys.KEYRANGE_EMFREELIST_BASE));
monitorThreads.create_thread(
RWLockMonitor(&die, comm->getSlaveNode().getEMLockStatus(), keys.KEYRANGE_EXTENTMAP_BASE));
monitorThreads.create_thread(
RWLockMonitor(&die, comm->getSlaveNode().getVBBMLockStatus(), keys.KEYRANGE_VBBM_BASE));
monitorThreads.create_thread(
RWLockMonitor(&die, comm->getSlaveNode().getVSSLockStatus(), keys.KEYRANGE_VSS_BASE));
monitorThreads.create_thread(
RWLockMonitor(&die, comm->getSlaveNode().getEMIndexLockStatus(), keys.KEYRANGE_EXTENTMAP_INDEX_BASE));

2
versioning/BRM/vss.cpp
View File

@ -1127,7 +1127,7 @@ void VSS::clear()
}
// read lock
int VSS::checkConsistency(const VBBM& vbbm, ExtentMap& em) const
int VSS::checkConsistency(const VBBM& vbbm, ExtentMap& /*em*/) const
{
/*
1. Every valid entry in the VSS has an entry either in the VBBM or in the