database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-29 08:21:15 +03:00
Code Activity

chore(build): fixes to satisfy clang19 warnings

Browse Source
This commit is contained in:
Leonid Fedorov
2025-05-08 15:26:36 +00:00
committed by Leonid Fedorov
parent 9fd7f342a7
commit a0bee173f6
334 changed files with 3062 additions and 3323 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
utils/udfsdk/allnull.cpp
View File

@ -26,7 +26,7 @@ struct allnull_data
};
#define OUT_TYPE int64_t
mcsv1_UDAF::ReturnCode allnull::init(mcsv1Context* context, ColumnDatum* colTypes)
mcsv1_UDAF::ReturnCode allnull::init(mcsv1Context* context, ColumnDatum* /*colTypes*/)
{
context->setUserDataSize(sizeof(allnull_data));
@ -51,7 +51,7 @@ mcsv1_UDAF::ReturnCode allnull::reset(mcsv1Context* context)
return mcsv1_UDAF::SUCCESS;
}
mcsv1_UDAF::ReturnCode allnull::nextValue(mcsv1Context* context, ColumnDatum* valsIn)
mcsv1_UDAF::ReturnCode allnull::nextValue(mcsv1Context* context, ColumnDatum* /*valsIn*/)
{
struct allnull_data* data = (struct allnull_data*)context->getUserData()->data;

2
utils/udfsdk/distinct_count.cpp
View File

@ -26,7 +26,7 @@ struct distinct_count_data
};
#define OUT_TYPE int64_t
mcsv1_UDAF::ReturnCode distinct_count::init(mcsv1Context* context, ColumnDatum* colTypes)
mcsv1_UDAF::ReturnCode distinct_count::init(mcsv1Context* context, ColumnDatum* /*colTypes*/)
{
context->setUserDataSize(sizeof(distinct_count_data));
if (context->getParameterCount() != 1)

12
utils/udfsdk/mcsv1_udaf.h
View File

@ -601,7 +601,10 @@ class mcsv1_UDAF
* dropValue() will not be called for unbounded/current row type
* frames, as those are already optimized.
*/
virtual ReturnCode dropValue(mcsv1Context* context, ColumnDatum* valsDropped);
virtual ReturnCode dropValue(mcsv1Context* /*context*/, ColumnDatum* /*valsDropped*/)
{
return NOT_IMPLEMENTED;
}
/**
* createUserData()
@ -623,7 +626,7 @@ class mcsv1_UDAF
* create.
*
*/
virtual ReturnCode createUserData(UserData*& userdata, int32_t& length);
virtual ReturnCode createUserData(UserData*& userData, int32_t& length);
protected:
double toDouble(ColumnDatum& datum) const
@ -998,11 +1001,6 @@ inline uint32_t mcsv1Context::getCharsetNumber()
return fCharsetNumber;
}
inline mcsv1_UDAF::ReturnCode mcsv1_UDAF::dropValue(mcsv1Context* context, ColumnDatum* valsDropped)
{
return NOT_IMPLEMENTED;
}
inline mcsv1_UDAF::ReturnCode mcsv1_UDAF::createUserData(UserData*& userData, int32_t& length)
{
userData = new UserData(length);

92
utils/udfsdk/udfmysql.cpp
View File

@ -55,7 +55,7 @@ extern "C"
/**
* MCS_ADD connector stub
*/
my_bool mcs_add_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool mcs_add_init(UDF_INIT* /*initid*/, UDF_ARGS* args, char* message)
{
if (args->arg_count != 2)
{
@ -66,11 +66,11 @@ extern "C"
return 0;
}
void mcs_add_deinit(UDF_INIT* initid)
void mcs_add_deinit(UDF_INIT* /*initid*/)
{
}
double mcs_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* error)
double mcs_add(UDF_INIT* /*initid*/, UDF_ARGS* args, char* /*is_null*/, char* /*error*/)
{
double op1, op2;
@ -84,7 +84,7 @@ extern "C"
* MCS_ISNULL connector stub
*/
my_bool mcs_isnull_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool mcs_isnull_init(UDF_INIT* /*initid*/, UDF_ARGS* args, char* message)
{
if (args->arg_count != 1)
{
@ -95,11 +95,11 @@ extern "C"
return 0;
}
void mcs_isnull_deinit(UDF_INIT* initid)
void mcs_isnull_deinit(UDF_INIT* /*initid*/)
{
}
long long mcs_isnull(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* error)
long long mcs_isnull(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
return 0;
}
@ -113,7 +113,7 @@ extern "C"
ulonglong totalNulls;
};
my_bool allnull_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool allnull_init(UDF_INIT* initid, UDF_ARGS* /*args*/, char* message)
{
struct allnull_data* data;
// if (args->arg_count != 1)
@ -136,27 +136,25 @@ extern "C"
return 0;
}
void allnull_deinit(UDF_INIT* initid)
void allnull_deinit(UDF_INIT* initid)
{
free(initid->ptr);
}
long long allnull(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long allnull(UDF_INIT* initid, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
struct allnull_data* data = (struct allnull_data*)initid->ptr;
return data->totalQuantity > 0 && data->totalNulls == data->totalQuantity;
}
void allnull_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void allnull_clear(UDF_INIT* initid, char* /*is_null*/, char* /*message*/)
{
struct allnull_data* data = (struct allnull_data*)initid->ptr;
data->totalQuantity = 0;
data->totalNulls = 0;
}
void allnull_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* message __attribute__((unused)))
void allnull_add(UDF_INIT* initid, UDF_ARGS* args, char* /*is_null*/, char* /*message*/)
{
struct allnull_data* data = (struct allnull_data*)initid->ptr;
const char* word = args->args[0];
@ -176,7 +174,7 @@ extern "C"
double sumsq;
};
my_bool ssq_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool ssq_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
{
struct ssq_data* data;
@ -198,27 +196,25 @@ extern "C"
return 0;
}
void ssq_deinit(UDF_INIT* initid)
void ssq_deinit(UDF_INIT* initid)
{
free(initid->ptr);
}
void ssq_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void ssq_clear(UDF_INIT* initid, char* /*is_null*/, char* /*message*/)
{
struct ssq_data* data = (struct ssq_data*)initid->ptr;
data->sumsq = 0;
}
void ssq_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* message __attribute__((unused)))
void ssq_add(UDF_INIT* initid, UDF_ARGS* args, char* /*is_null*/, char* /*message*/)
{
struct ssq_data* data = (struct ssq_data*)initid->ptr;
double val = cvtArgToDouble(args->arg_type[0], args->args[0]);
data->sumsq = val * val;
}
long long ssq(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long ssq(UDF_INIT* initid, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
struct ssq_data* data = (struct ssq_data*)initid->ptr;
return data->sumsq;
@ -229,7 +225,7 @@ extern "C"
/**
* MEDIAN connector stub
*/
my_bool median_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool median_init(UDF_INIT* /*initid*/, UDF_ARGS* args, char* message)
{
if (args->arg_count != 1)
{
@ -250,27 +246,25 @@ extern "C"
return 0;
}
void median_deinit(UDF_INIT* initid)
void median_deinit(UDF_INIT* /*initid*/)
{
// free(initid->ptr);
}
void median_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void median_clear(UDF_INIT* /*initid*/, char* /*is_null*/, char* /*message*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// data->sumsq = 0;
}
void median_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* message __attribute__((unused)))
void median_add(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*message*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// double val = cvtArgToDouble(args->arg_type[0], args->args[0]);
// data->sumsq = val*val;
}
long long median(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long median(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// return data->sumsq;
@ -280,7 +274,7 @@ extern "C"
/**
* avg_mode connector stub
*/
my_bool avg_mode_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool avg_mode_init(UDF_INIT* /*initid*/, UDF_ARGS* args, char* message)
{
if (args->arg_count != 1)
{
@ -301,28 +295,25 @@ extern "C"
return 0;
}
void avg_mode_deinit(UDF_INIT* initid)
void avg_mode_deinit(UDF_INIT* /*initid*/)
{
// free(initid->ptr);
}
void avg_mode_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void avg_mode_clear(UDF_INIT* /*initid*/, char* /*is_null*/, char* /*message*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// data->sumsq = 0;
}
void avg_mode_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null,
char* message __attribute__((unused)))
void avg_mode_add(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*message*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// double val = cvtArgToDouble(args->arg_type[0], args->args[0]);
// data->sumsq = val*val;
}
long long avg_mode(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long avg_mode(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
// struct ssq_data* data = (struct ssq_data*)initid->ptr;
// return data->sumsq;
@ -342,7 +333,7 @@ extern "C"
int64_t cnt;
};
my_bool avgx_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
my_bool avgx_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
{
struct avgx_data* data;
if (args->arg_count != 1)
@ -363,20 +354,19 @@ extern "C"
return 0;
}
void avgx_deinit(UDF_INIT* initid)
void avgx_deinit(UDF_INIT* initid)
{
free(initid->ptr);
}
void avgx_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void avgx_clear(UDF_INIT* initid, char* /*is_null*/, char* /*message*/)
{
struct avgx_data* data = (struct avgx_data*)initid->ptr;
data->sumx = 0;
data->cnt = 0;
}
void avgx_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null, char* message __attribute__((unused)))
void avgx_add(UDF_INIT* initid, UDF_ARGS* args, char* /*is_null*/, char* /*message*/)
{
// TODO test for NULL in x and y
struct avgx_data* data = (struct avgx_data*)initid->ptr;
@ -385,17 +375,16 @@ extern "C"
data->sumx += xval;
}
long long avgx(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long avgx(UDF_INIT* initid, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
struct avgx_data* data = (struct avgx_data*)initid->ptr;
return data->sumx / data->cnt;
}
/**
* distinct_count connector stub
*/
my_bool distinct_count_init(UDF_INIT* initid, UDF_ARGS* args, char* message)
/**
* distinct_count connector stub
*/
my_bool distinct_count_init(UDF_INIT* /*initid*/, UDF_ARGS* args, char* message)
{
if (args->arg_count != 1)
{
@ -406,23 +395,20 @@ extern "C"
return 0;
}
void distinct_count_deinit(UDF_INIT* initid)
void distinct_count_deinit(UDF_INIT* /*initid*/)
{
// free(initid->ptr);
}
void distinct_count_clear(UDF_INIT* initid, char* is_null __attribute__((unused)),
char* message __attribute__((unused)))
void distinct_count_clear(UDF_INIT* /*initid*/, char* /*is_null*/, char* /*message*/)
{
}
void distinct_count_add(UDF_INIT* initid, UDF_ARGS* args, char* is_null,
char* message __attribute__((unused)))
void distinct_count_add(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*message*/)
{
}
long long distinct_count(UDF_INIT* initid, UDF_ARGS* args __attribute__((unused)), char* is_null,
char* error __attribute__((unused)))
long long distinct_count(UDF_INIT* /*initid*/, UDF_ARGS* /*args*/, char* /*is_null*/, char* /*error*/)
{
return 0;
}

10
utils/udfsdk/udfsdk.cpp
View File

@ -78,7 +78,7 @@ FuncMap UDFSDK::UDFMap() const
* OperationType() definition
*/
CalpontSystemCatalog::ColType MCS_add::operationType(FunctionParm& fp,
CalpontSystemCatalog::ColType& resultType)
CalpontSystemCatalog::ColType& /*resultType*/)
{
// operation type of MCS_add is determined by the argument types
assert(fp.size() == 2);
@ -242,8 +242,8 @@ IDB_Decimal MCS_add::getDecimalVal(Row& row, FunctionParm& parm, bool& isNull,
* either not implement this API and an MCS5001 error will be thrown,
* or throw a customized exception here.
*/
int32_t MCS_add::getDateIntVal(Row& row, FunctionParm& parm, bool& isNull,
CalpontSystemCatalog::ColType& op_ct)
int32_t MCS_add::getDateIntVal(Row& /*row*/, FunctionParm& /*parm*/, bool& /*isNull*/,
CalpontSystemCatalog::ColType& /*op_ct*/)
{
throw logic_error("Invalid API called for MCS_ADD");
}
@ -260,7 +260,7 @@ int64_t MCS_add::getDatetimeIntVal(Row& row, FunctionParm& parm, bool& isNull,
return (int64_t)getDoubleVal(row, parm, isNull, op_ct);
}
bool MCS_add::getBoolVal(Row& row, FunctionParm& parm, bool& isNull, CalpontSystemCatalog::ColType& op_ct)
bool MCS_add::getBoolVal(Row& /*row*/, FunctionParm& /*parm*/, bool& /*isNull*/, CalpontSystemCatalog::ColType& /*op_ct*/)
{
return false;
}
@ -271,7 +271,7 @@ bool MCS_add::getBoolVal(Row& row, FunctionParm& parm, bool& isNull, CalpontSyst
* OperationType() definition
*/
CalpontSystemCatalog::ColType MCS_isnull::operationType(FunctionParm& fp,
CalpontSystemCatalog::ColType& resultType)
CalpontSystemCatalog::ColType& /*resultType*/)
{
// operation type of MCS_isnull should be the same as the argument type
assert(fp.size() == 1);