database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-07-30 19:23:07 +03:00
Code Activity

chore(build): fixes to satisfy clang19 warnings

Browse Source
This commit is contained in:
Leonid Fedorov
2025-05-08 15:26:36 +00:00
committed by Leonid Fedorov
parent 9fd7f342a7
commit a0bee173f6
334 changed files with 3062 additions and 3323 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dbcon/execplan/arithmeticcolumn.h
View File

@ -274,7 +274,7 @@ class ArithmeticColumn : public ReturnedColumn
private:
ParseTree* fExpression = nullptr;
using TreeNode::evaluate;
void evaluate(rowgroup::Row& row)
void evaluate(rowgroup::Row& /*row*/)
{
}
};

244
dbcon/execplan/calpontsystemcatalog.cpp
View File

@ -75,7 +75,6 @@ using namespace rowgroup;
#include <boost/thread/mutex.hpp>
#include <boost/version.hpp>
#undef BAIL_IF_0
#if 1
// We are unlikely to ever get anything more out of this connection, so bail out
@ -341,14 +340,14 @@ bool CalpontSystemCatalog::TableAliasName::operator<(const TableAliasName& rhs)
else if (view == rhs.view)
{
if (partitions < rhs.partitions)
{
{
return true;
}
if (partitions == rhs.partitions)
{
}
if (partitions == rhs.partitions)
{
if (fisColumnStore < rhs.fisColumnStore)
return true;
}
}
}
}
}
@ -853,7 +852,7 @@ void CalpontSystemCatalog::getSysData(CalpontSelectExecutionPlan& csep, NJLSysDa
}
void CalpontSystemCatalog::getSysData_EC(CalpontSelectExecutionPlan& csep, NJLSysDataList& sysDataList,
const string& sysTableName)
const string& /*sysTableName*/)
{
DEBUG << "Enter getSysData_EC " << fSessionID << endl;
@ -3236,7 +3235,8 @@ const CalpontSystemCatalog::RIDList CalpontSystemCatalog::columnRIDs(const Table
for (int i = 0; i < (*it)->dataCount(); i++)
{
TableColName tcn = make_tcn(aTableName.schema, aTableName.table, (*it)->GetStringData(i).safeString(""));
TableColName tcn =
make_tcn(aTableName.schema, aTableName.table, (*it)->GetStringData(i).safeString(""));
fOIDmap[tcn] = rl[i].objnum;
if (fIdentity == EC)
@ -3681,15 +3681,11 @@ CalpontSystemCatalog::OID CalpontSystemCatalog::tableAUXColumnOID(const TableNam
CalpontSelectExecutionPlan::FilterTokenList filterTokenList;
CalpontSelectExecutionPlan::ColumnMap colMap;
static const std::string sysCatSchemaTablePrefix =
CALPONT_SCHEMA + "." + SYSTABLE_TABLE + ".";
static const std::string sysCatSchemaTablePrefix = CALPONT_SCHEMA + "." + SYSTABLE_TABLE + ".";
SimpleColumn* c1 =
new SimpleColumn(sysCatSchemaTablePrefix + AUXCOLUMNOID_COL, fSessionID);
SimpleColumn* c2 =
new SimpleColumn(sysCatSchemaTablePrefix + SCHEMA_COL, fSessionID);
SimpleColumn* c3 =
new SimpleColumn(sysCatSchemaTablePrefix + TABLENAME_COL, fSessionID);
SimpleColumn* c1 = new SimpleColumn(sysCatSchemaTablePrefix + AUXCOLUMNOID_COL, fSessionID);
SimpleColumn* c2 = new SimpleColumn(sysCatSchemaTablePrefix + SCHEMA_COL, fSessionID);
SimpleColumn* c3 = new SimpleColumn(sysCatSchemaTablePrefix + TABLENAME_COL, fSessionID);
SRCP srcp;
srcp.reset(c1);
@ -3793,13 +3789,10 @@ CalpontSystemCatalog::OID CalpontSystemCatalog::isAUXColumnOID(const OID& oid)
CalpontSelectExecutionPlan::FilterTokenList filterTokenList;
CalpontSelectExecutionPlan::ColumnMap colMap;
static const std::string sysCatSchemaTablePrefix =
CALPONT_SCHEMA + "." + SYSTABLE_TABLE + ".";
static const std::string sysCatSchemaTablePrefix = CALPONT_SCHEMA + "." + SYSTABLE_TABLE + ".";
SimpleColumn* c1 =
new SimpleColumn(sysCatSchemaTablePrefix + OBJECTID_COL, fSessionID);
SimpleColumn* c2 =
new SimpleColumn(sysCatSchemaTablePrefix + AUXCOLUMNOID_COL, fSessionID);
SimpleColumn* c1 = new SimpleColumn(sysCatSchemaTablePrefix + OBJECTID_COL, fSessionID);
SimpleColumn* c2 = new SimpleColumn(sysCatSchemaTablePrefix + AUXCOLUMNOID_COL, fSessionID);
SRCP srcp;
srcp.reset(c1);
colMap.insert(CMVT_(sysCatSchemaTablePrefix + OBJECTID_COL, srcp));
@ -3820,8 +3813,7 @@ CalpontSystemCatalog::OID CalpontSystemCatalog::isAUXColumnOID(const OID& oid)
csep.filterTokenList(filterTokenList);
ostringstream oss;
oss << "select objectid from systable where auxcolumnoid='" << oid
<< "' --isAUXColumnOID/";
oss << "select objectid from systable where auxcolumnoid='" << oid << "' --isAUXColumnOID/";
if (fIdentity == EC)
oss << "EC";
@ -5961,122 +5953,146 @@ void CalpontSystemCatalog::buildSysColinfomap()
DictOID notDict;
// @bug 4433 - Increase object width from 64 to 128 for schema names, table names, and column names.
fColinfomap[OID_SYSTABLE_TABLENAME] = ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSTABLE_TABLENAME, LISTOID_SYSTABLE_TABLENAME, TREEOID_SYSTABLE_TABLENAME, compressionType),
colPosition++, compressionType, OID_SYSTABLE_TABLENAME, VARCHAR);
fColinfomap[OID_SYSTABLE_TABLENAME] =
ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSTABLE_TABLENAME, LISTOID_SYSTABLE_TABLENAME, TREEOID_SYSTABLE_TABLENAME,
compressionType),
colPosition++, compressionType, OID_SYSTABLE_TABLENAME, VARCHAR);
fColinfomap[OID_SYSTABLE_SCHEMA] = ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSTABLE_SCHEMA, LISTOID_SYSTABLE_SCHEMA, TREEOID_SYSTABLE_SCHEMA, compressionType),
colPosition++, compressionType, OID_SYSTABLE_SCHEMA, VARCHAR);
fColinfomap[OID_SYSTABLE_SCHEMA] = ColType(
129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSTABLE_SCHEMA, LISTOID_SYSTABLE_SCHEMA, TREEOID_SYSTABLE_SCHEMA, compressionType),
colPosition++, compressionType, OID_SYSTABLE_SCHEMA, VARCHAR);
fColinfomap[OID_SYSTABLE_OBJECTID] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_OBJECTID, INT);
fColinfomap[OID_SYSTABLE_OBJECTID] = ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict,
colPosition++, compressionType, OID_SYSTABLE_OBJECTID, INT);
fColinfomap[OID_SYSTABLE_CREATEDATE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_CREATEDATE, DATE);
fColinfomap[OID_SYSTABLE_CREATEDATE] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSTABLE_CREATEDATE, DATE);
fColinfomap[OID_SYSTABLE_LASTUPDATE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_LASTUPDATE, DATE);
fColinfomap[OID_SYSTABLE_LASTUPDATE] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSTABLE_LASTUPDATE, DATE);
fColinfomap[OID_SYSTABLE_INIT] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_INIT, INT);
fColinfomap[OID_SYSTABLE_INIT] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSTABLE_INIT, INT);
fColinfomap[OID_SYSTABLE_NEXT] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_NEXT, INT);
fColinfomap[OID_SYSTABLE_NEXT] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSTABLE_NEXT, INT);
fColinfomap[OID_SYSTABLE_NUMOFROWS] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_NUMOFROWS, INT);
fColinfomap[OID_SYSTABLE_NUMOFROWS] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSTABLE_NUMOFROWS, INT);
fColinfomap[OID_SYSTABLE_AVGROWLEN] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_AVGROWLEN, INT);
fColinfomap[OID_SYSTABLE_AVGROWLEN] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSTABLE_AVGROWLEN, INT);
fColinfomap[OID_SYSTABLE_NUMOFBLOCKS] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_NUMOFBLOCKS, INT);
fColinfomap[OID_SYSTABLE_NUMOFBLOCKS] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSTABLE_NUMOFBLOCKS, INT);
fColinfomap[OID_SYSTABLE_AUTOINCREMENT] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_AUTOINCREMENT, INT);
fColinfomap[OID_SYSTABLE_AUTOINCREMENT] =
ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSTABLE_AUTOINCREMENT, INT);
fColinfomap[OID_SYSTABLE_AUXCOLUMNOID] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSTABLE_AUXCOLUMNOID, INT);
fColinfomap[OID_SYSTABLE_AUXCOLUMNOID] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSTABLE_AUXCOLUMNOID, INT);
fTablemap[make_table(CALPONT_SCHEMA, SYSCOLUMN_TABLE)] = SYSCOLUMN_BASE;
colPosition = 0;
fColinfomap[OID_SYSCOLUMN_SCHEMA] = ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_SCHEMA, LISTOID_SYSCOLUMN_SCHEMA, TREEOID_SYSCOLUMN_SCHEMA, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_SCHEMA, VARCHAR);
fColinfomap[OID_SYSCOLUMN_SCHEMA] = ColType(
129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_SCHEMA, LISTOID_SYSCOLUMN_SCHEMA, TREEOID_SYSCOLUMN_SCHEMA, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_SCHEMA, VARCHAR);
fColinfomap[OID_SYSCOLUMN_TABLENAME] = ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_TABLENAME, LISTOID_SYSCOLUMN_TABLENAME, TREEOID_SYSCOLUMN_TABLENAME, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_TABLENAME, VARCHAR);
fColinfomap[OID_SYSCOLUMN_TABLENAME] =
ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_TABLENAME, LISTOID_SYSCOLUMN_TABLENAME, TREEOID_SYSCOLUMN_TABLENAME,
compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_TABLENAME, VARCHAR);
fColinfomap[OID_SYSCOLUMN_COLNAME] = ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_COLNAME, LISTOID_SYSCOLUMN_COLNAME, TREEOID_SYSCOLUMN_COLNAME, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_COLNAME, VARCHAR);
fColinfomap[OID_SYSCOLUMN_COLNAME] =
ColType(129, scale, precision, NOTNULL_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_COLNAME, LISTOID_SYSCOLUMN_COLNAME, TREEOID_SYSCOLUMN_COLNAME,
compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_COLNAME, VARCHAR);
fColinfomap[OID_SYSCOLUMN_OBJECTID] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_OBJECTID, INT);
fColinfomap[OID_SYSCOLUMN_OBJECTID] = ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict,
colPosition++, compressionType, OID_SYSCOLUMN_OBJECTID, INT);
fColinfomap[OID_SYSCOLUMN_DICTOID] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_DICTOID, INT);
fColinfomap[OID_SYSCOLUMN_DICTOID] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_DICTOID, INT);
fColinfomap[OID_SYSCOLUMN_LISTOBJID] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_LISTOBJID, INT);
fColinfomap[OID_SYSCOLUMN_LISTOBJID] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_LISTOBJID, INT);
fColinfomap[OID_SYSCOLUMN_TREEOBJID] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_TREEOBJID, INT);
fColinfomap[OID_SYSCOLUMN_TREEOBJID] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_TREEOBJID, INT);
fColinfomap[OID_SYSCOLUMN_DATATYPE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_DATATYPE, INT);
fColinfomap[OID_SYSCOLUMN_DATATYPE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict,
colPosition++, compressionType, OID_SYSCOLUMN_DATATYPE, INT);
fColinfomap[OID_SYSCOLUMN_COLUMNLEN] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_COLUMNLEN, INT);
fColinfomap[OID_SYSCOLUMN_COLUMNLEN] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_COLUMNLEN, INT);
fColinfomap[OID_SYSCOLUMN_COLUMNPOS] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_COLUMNPOS, INT);
fColinfomap[OID_SYSCOLUMN_COLUMNPOS] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_COLUMNPOS, INT);
fColinfomap[OID_SYSCOLUMN_LASTUPDATE] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_LASTUPDATE, DATE);
fColinfomap[OID_SYSCOLUMN_LASTUPDATE] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_LASTUPDATE, DATE);
fColinfomap[OID_SYSCOLUMN_DEFAULTVAL] = ColType(64, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_DEFAULTVAL, LISTOID_SYSCOLUMN_DEFAULTVAL, TREEOID_SYSCOLUMN_DEFAULTVAL, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_DEFAULTVAL, VARCHAR);
fColinfomap[OID_SYSCOLUMN_DEFAULTVAL] =
ColType(64, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_DEFAULTVAL, LISTOID_SYSCOLUMN_DEFAULTVAL,
TREEOID_SYSCOLUMN_DEFAULTVAL, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_DEFAULTVAL, VARCHAR);
fColinfomap[OID_SYSCOLUMN_NULLABLE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_NULLABLE, INT);
fColinfomap[OID_SYSCOLUMN_NULLABLE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict,
colPosition++, compressionType, OID_SYSCOLUMN_NULLABLE, INT);
fColinfomap[OID_SYSCOLUMN_SCALE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_SCALE, INT);
fColinfomap[OID_SYSCOLUMN_SCALE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_SCALE, INT);
fColinfomap[OID_SYSCOLUMN_PRECISION] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_PRECISION, INT);
fColinfomap[OID_SYSCOLUMN_PRECISION] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_PRECISION, INT);
fColinfomap[OID_SYSCOLUMN_AUTOINC] = ColType(1, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_AUTOINC, CHAR);
fColinfomap[OID_SYSCOLUMN_AUTOINC] = ColType(1, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_AUTOINC, CHAR);
fColinfomap[OID_SYSCOLUMN_DISTCOUNT] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_DISTCOUNT, INT);
fColinfomap[OID_SYSCOLUMN_DISTCOUNT] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_DISTCOUNT, INT);
fColinfomap[OID_SYSCOLUMN_NULLCOUNT] = ColType(4, scale, precision, NO_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_NULLCOUNT, INT);
fColinfomap[OID_SYSCOLUMN_NULLCOUNT] = ColType(4, scale, precision, NO_CONSTRAINT, notDict, colPosition++,
compressionType, OID_SYSCOLUMN_NULLCOUNT, INT);
fColinfomap[OID_SYSCOLUMN_MINVALUE] = ColType(65, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_MINVALUE, LISTOID_SYSCOLUMN_MINVALUE, TREEOID_SYSCOLUMN_MINVALUE, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_MINVALUE, VARCHAR);
fColinfomap[OID_SYSCOLUMN_MINVALUE] =
ColType(65, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_MINVALUE, LISTOID_SYSCOLUMN_MINVALUE, TREEOID_SYSCOLUMN_MINVALUE,
compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_MINVALUE, VARCHAR);
fColinfomap[OID_SYSCOLUMN_MAXVALUE] = ColType(65, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_MAXVALUE, LISTOID_SYSCOLUMN_MAXVALUE, TREEOID_SYSCOLUMN_MAXVALUE, compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_MAXVALUE, VARCHAR);
fColinfomap[OID_SYSCOLUMN_MAXVALUE] =
ColType(65, scale, precision, NO_CONSTRAINT,
DictOID(DICTOID_SYSCOLUMN_MAXVALUE, LISTOID_SYSCOLUMN_MAXVALUE, TREEOID_SYSCOLUMN_MAXVALUE,
compressionType),
colPosition++, compressionType, OID_SYSCOLUMN_MAXVALUE, VARCHAR);
fColinfomap[OID_SYSCOLUMN_COMPRESSIONTYPE] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_COMPRESSIONTYPE, INT);
fColinfomap[OID_SYSCOLUMN_COMPRESSIONTYPE] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_COMPRESSIONTYPE, INT);
fColinfomap[OID_SYSCOLUMN_NEXTVALUE] = ColType(8, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_NEXTVALUE, UBIGINT);
fColinfomap[OID_SYSCOLUMN_NEXTVALUE] =
ColType(8, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_NEXTVALUE, UBIGINT);
fColinfomap[OID_SYSCOLUMN_CHARSETNUM] = ColType(4, scale, precision, NOTNULL_CONSTRAINT,
notDict, colPosition++, compressionType, OID_SYSCOLUMN_CHARSETNUM, INT);
fColinfomap[OID_SYSCOLUMN_CHARSETNUM] =
ColType(4, scale, precision, NOTNULL_CONSTRAINT, notDict, colPosition++, compressionType,
OID_SYSCOLUMN_CHARSETNUM, INT);
}
void CalpontSystemCatalog::buildSysOIDmap()
@ -6170,13 +6186,14 @@ CalpontSystemCatalog::ColType::ColType(const ColType& rhs) : TypeHolderStd(rhs)
}
CalpontSystemCatalog::ColType::ColType(int32_t colWidth_, int32_t scale_, int32_t precision_,
const ConstraintType& constraintType_, const DictOID& ddn_, int32_t colPosition_,
int32_t compressionType_, OID columnOID_, const ColDataType& colDataType_)
: constraintType(constraintType_),
ddn(ddn_),
colPosition(colPosition_),
compressionType(compressionType_),
columnOID(columnOID_)
const ConstraintType& constraintType_, const DictOID& ddn_,
int32_t colPosition_, int32_t compressionType_, OID columnOID_,
const ColDataType& colDataType_)
: constraintType(constraintType_)
, ddn(ddn_)
, colPosition(colPosition_)
, compressionType(compressionType_)
, columnOID(columnOID_)
{
colWidth = colWidth_;
scale = scale_;
@ -6251,8 +6268,7 @@ boost::any CalpontSystemCatalog::ColType::convertColumnData(const NullString& da
}
CalpontSystemCatalog::ColType CalpontSystemCatalog::ColType::convertUnionColType(
vector<CalpontSystemCatalog::ColType>& types,
unsigned int& rc)
vector<CalpontSystemCatalog::ColType>& types, unsigned int& rc)
{
idbassert(types.size());
CalpontSystemCatalog::ColType unionedType = types[0];
@ -6328,7 +6344,7 @@ bool ctListSort(const CalpontSystemCatalog::ColType& a, const CalpontSystemCatal
return a.colPosition < b.colPosition;
}
bool operator <(const Partitions& a, const Partitions& b)
bool operator<(const Partitions& a, const Partitions& b)
{
// lexicographic order.
uint32_t l = std::min(a.fPartNames.size(), b.fPartNames.size());
@ -6353,7 +6369,7 @@ bool operator <(const Partitions& a, const Partitions& b)
}
return false;
}
bool operator ==(const Partitions& a, const Partitions& b)
bool operator==(const Partitions& a, const Partitions& b)
{
if (a.fPartNames.size() != b.fPartNames.size())
{
@ -6370,7 +6386,7 @@ bool operator ==(const Partitions& a, const Partitions& b)
return true;
}
bool operator !=(const Partitions& a, const Partitions& b)
bool operator!=(const Partitions& a, const Partitions& b)
{
return !(a == b);
}

2
dbcon/execplan/calpontsystemcatalog.h
View File

@ -1010,7 +1010,7 @@ const CalpontSystemCatalog::TableAliasName make_aliasview(const std::string& s,
const bool fisColumnStore = true,
int lower_case_table_names = 0);
inline bool isNull(int128_t val, const execplan::CalpontSystemCatalog::ColType& ct)
inline bool isNull(int128_t val, const execplan::CalpontSystemCatalog::ColType& /*ct*/)
{
return datatypes::Decimal::isWideDecimalNullValue(val);
}

4
dbcon/execplan/constantcolumn.cpp
View File

@ -349,13 +349,11 @@ void RollupMarkColumn::unserialize(messageqcpp::ByteStream& b)
b >> (uint8_t&)fResult.decimalVal.precision;
}
static utils::NullString ns;
const utils::NullString& RollupMarkColumn::getStrVal(rowgroup::Row& row, bool& isNull)
const utils::NullString& RollupMarkColumn::getStrVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return ns;
}
bool ConstantColumn::operator==(const ConstantColumn& t) const
{
const ReturnedColumn *rc1, *rc2;

52
dbcon/execplan/constantcolumn.h
View File

@ -262,13 +262,13 @@ class ConstantColumn : public ReturnedColumn
* F&E
*/
using ReturnedColumn::evaluate;
virtual void evaluate(rowgroup::Row& row)
virtual void evaluate(rowgroup::Row& /*row*/)
{
}
/**
* F&E
*/
bool getBoolVal(rowgroup::Row& row, bool& isNull) override
bool getBoolVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return TreeNode::getBoolVal();
@ -276,7 +276,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
const utils::NullString& getStrVal(rowgroup::Row& row, bool& isNull) override
const utils::NullString& getStrVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.strVal;
@ -284,7 +284,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.intVal;
@ -292,7 +292,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
uint64_t getUintVal(rowgroup::Row& row, bool& isNull) override
uint64_t getUintVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.uintVal;
@ -300,7 +300,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
float getFloatVal(rowgroup::Row& row, bool& isNull) override
float getFloatVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.floatVal;
@ -308,7 +308,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
double getDoubleVal(rowgroup::Row& row, bool& isNull) override
double getDoubleVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.doubleVal;
@ -316,7 +316,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
IDB_Decimal getDecimalVal(rowgroup::Row& row, bool& isNull) override
IDB_Decimal getDecimalVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
return fResult.decimalVal;
@ -324,7 +324,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
int32_t getDateIntVal(rowgroup::Row& row, bool& isNull) override
int32_t getDateIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
@ -339,7 +339,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getDatetimeIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getDatetimeIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
@ -355,7 +355,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getTimestampIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getTimestampIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
@ -371,7 +371,7 @@ class ConstantColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getTimeIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getTimeIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = isNull || (fType == NULLDATA);
@ -509,7 +509,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* accessor
*/
void data(const std::string data) override
void data(const std::string /*data*/) override
{
idbassert(0);
}
@ -521,7 +521,7 @@ class RollupMarkColumn : public ReturnedColumn
return "RollupMarkColumn";
}
std::string toCppCode(IncludeSet& includes) const override
std::string toCppCode(IncludeSet& /*includes*/) const override
{
idbassert(0);
}
@ -551,7 +551,7 @@ class RollupMarkColumn : public ReturnedColumn
* Do a deep, strict (as opposed to semantic) equivalence test.
* @return true iff every member of t is a duplicate copy of every member of this; false otherwise
*/
bool operator==(const TreeNode* t) const override
bool operator==(const TreeNode* /*t*/) const override
{
return false;
}
@ -561,7 +561,7 @@ class RollupMarkColumn : public ReturnedColumn
* Do a deep, strict (as opposed to semantic) equivalence test.
* @return true iff every member of t is a duplicate copy of every member of this; false otherwise
*/
bool operator==(const RollupMarkColumn& t) const
bool operator==(const RollupMarkColumn& /*t*/) const
{
return true;
}
@ -571,7 +571,7 @@ class RollupMarkColumn : public ReturnedColumn
* Do a deep, strict (as opposed to semantic) equivalence test.
* @return false iff every member of t is a duplicate copy of every member of this; true otherwise
*/
bool operator!=(const TreeNode* t) const override
bool operator!=(const TreeNode* /*t*/) const override
{
return true;
}
@ -581,7 +581,7 @@ class RollupMarkColumn : public ReturnedColumn
* Do a deep, strict (as opposed to semantic) equivalence test.
* @return false iff every member of t is a duplicate copy of every member of this; true otherwise
*/
bool operator!=(const RollupMarkColumn& t) const
bool operator!=(const RollupMarkColumn& /*t*/) const
{
return false;
}
@ -611,13 +611,13 @@ class RollupMarkColumn : public ReturnedColumn
***********************************************************/
public:
using ReturnedColumn::evaluate;
virtual void evaluate(rowgroup::Row& row)
virtual void evaluate(rowgroup::Row& /*row*/)
{
}
/**
* F&E
*/
bool getBoolVal(rowgroup::Row& row, bool& isNull) override
bool getBoolVal(rowgroup::Row& /*row*/, bool& /*isNull*/) override
{
return true;
}
@ -628,7 +628,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;
return 0x12340000UL;
@ -657,7 +657,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
IDB_Decimal getDecimalVal(rowgroup::Row& row, bool& isNull) override
IDB_Decimal getDecimalVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;
return fResult.decimalVal;
@ -665,7 +665,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
int32_t getDateIntVal(rowgroup::Row& row, bool& isNull) override
int32_t getDateIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;
@ -680,7 +680,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getDatetimeIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getDatetimeIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;
@ -696,7 +696,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getTimestampIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getTimestampIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;
@ -712,7 +712,7 @@ class RollupMarkColumn : public ReturnedColumn
/**
* F&E
*/
int64_t getTimeIntVal(rowgroup::Row& row, bool& isNull) override
int64_t getTimeIntVal(rowgroup::Row& /*row*/, bool& isNull) override
{
isNull = false;

1
dbcon/execplan/functioncolumn.h
View File

@ -335,7 +335,6 @@ class FunctionColumn : public ReturnedColumn
funcexp::FunctionParm fFunctionParms;
funcexp::Func* fFunctor; /// functor to execute this function
funcexp::Func* fDynamicFunctor = nullptr; // for rand encode decode
bool fFixed = false;
};
/**

2
dbcon/execplan/groupconcatcolumn.cpp
View File

@ -50,7 +50,7 @@ GroupConcatColumn::GroupConcatColumn(const uint32_t sessionID, bool isJsonArrayA
{
}
GroupConcatColumn::GroupConcatColumn(const GroupConcatColumn& rhs, const uint32_t sessionID)
GroupConcatColumn::GroupConcatColumn(const GroupConcatColumn& rhs, const uint32_t /*sessionID*/)
: AggregateColumn(dynamic_cast<const AggregateColumn&>(rhs))
, fOrderCols(rhs.fOrderCols)
, fSeparator(rhs.fSeparator)

4
dbcon/execplan/intervalcolumn.h
View File

@ -122,12 +122,12 @@ class IntervalColumn : public ReturnedColumn
int fIntervalType;
// okay to be private for now.
bool operator==(const TreeNode* t) const override
bool operator==(const TreeNode* /*t*/) const override
{
return false;
}
bool operator==(const IntervalColumn& t) const;
bool operator!=(const TreeNode* t) const override
bool operator!=(const TreeNode* /*t*/) const override
{
return false;
}

4
dbcon/execplan/mcsanalyzetableexecutionplan.h
View File

@ -237,11 +237,11 @@ class MCSAnalyzeTableExecutionPlan : public CalpontExecutionPlan
void unserialize(messageqcpp::ByteStream& bs) override;
// TODO: Why do we need this?
bool operator==(const CalpontExecutionPlan* t) const override
bool operator==(const CalpontExecutionPlan* /*t*/) const override
{
return false;
}
bool operator!=(const CalpontExecutionPlan* t) const override
bool operator!=(const CalpontExecutionPlan* /*t*/) const override
{
return false;
}

4
dbcon/execplan/objectidmanager.cpp
View File

@ -66,7 +66,7 @@
#include <iostream>
#include <cstring>
#include <stdexcept>
//#define NDEBUG
// #define NDEBUG
#include <boost/thread.hpp>
using namespace std;
@ -144,7 +144,7 @@ void ObjectIDManager::returnOID(int oid)
returnOIDs(oid, oid);
}
void ObjectIDManager::returnOIDs(int start, int end)
void ObjectIDManager::returnOIDs(int /*start*/, int /*end*/)
{
//@Bug 1412. Do not reuse oids for now.
return;

30
dbcon/execplan/operator.h
View File

@ -157,78 +157,78 @@ class Operator : public TreeNode
fOp = op;
}
using TreeNode::evaluate;
virtual void evaluate(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual void evaluate(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
}
// The following methods should be pure virtual. Currently too many instanslization exists.
using TreeNode::getStrVal;
virtual const utils::NullString& getStrVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual const utils::NullString& getStrVal(rowgroup::Row& /*row*/, bool& isNull, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
isNull = isNull || fResult.strVal.isNull();
return fResult.strVal;
}
using TreeNode::getIntVal;
virtual int64_t getIntVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual int64_t getIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.intVal;
}
using TreeNode::getUintVal;
virtual uint64_t getUintVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual uint64_t getUintVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.uintVal;
}
using TreeNode::getFloatVal;
virtual float getFloatVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual float getFloatVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.floatVal;
}
using TreeNode::getDoubleVal;
virtual double getDoubleVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual double getDoubleVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.doubleVal;
}
using TreeNode::getLongDoubleVal;
virtual long double getLongDoubleVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual long double getLongDoubleVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.longDoubleVal;
}
using TreeNode::getDecimalVal;
virtual IDB_Decimal getDecimalVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual IDB_Decimal getDecimalVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.decimalVal;
}
using TreeNode::getDateIntVal;
virtual int32_t getDateIntVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual int32_t getDateIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.intVal;
}
using TreeNode::getDatetimeIntVal;
virtual int64_t getDatetimeIntVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual int64_t getDatetimeIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.intVal;
}
using TreeNode::getTimestampIntVal;
virtual int64_t getTimestampIntVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual int64_t getTimestampIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.intVal;
}
using TreeNode::getTimeIntVal;
virtual int64_t getTimeIntVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual int64_t getTimeIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.intVal;
}
using TreeNode::getBoolVal;
virtual bool getBoolVal(rowgroup::Row& row, bool& isNull, ParseTree* lop, ParseTree* rop)
virtual bool getBoolVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ParseTree* /*lop*/, ParseTree* /*rop*/)
{
return fResult.boolVal;
}
virtual bool getBoolVal(rowgroup::Row& row, bool& isNull, ReturnedColumn* lop, ReturnedColumn* rop)
virtual bool getBoolVal(rowgroup::Row& /*row*/, bool& /*isNull*/, ReturnedColumn* /*lop*/, ReturnedColumn* /*rop*/)
{
return fResult.boolVal;
}
virtual void setOpType(Type& l, Type& r)
virtual void setOpType(Type& /*l*/, Type& /*r*/)
{
}
void operationType(const Type& ot) override

2
dbcon/execplan/returnedcolumn.h
View File

@ -321,7 +321,7 @@ class ReturnedColumn : public TreeNode
* @return true, if all arguments belong to one table
* false, if multiple tables are involved in the function
*/
virtual bool singleTable(CalpontSystemCatalog::TableAliasName& tan)
virtual bool singleTable(CalpontSystemCatalog::TableAliasName& /*tan*/)
{
return false;
}

26
dbcon/execplan/rewrites.cpp
View File

@ -82,7 +82,7 @@ enum class ChildType
Leave
};
void printTreeLevel(execplan::ParseTree* root, int level)
void printTreeLevel([[maybe_unused]] execplan::ParseTree* root, [[maybe_unused]] int level)
{
#if debug_rewrites
auto sep = std::string(level * 4, '-');
@ -116,7 +116,8 @@ struct StackFrameWithSet
bool orMet;
bool andParent;
CommonContainer localset;
StackFrameWithSet(execplan::ParseTree* node_, ParseTree::GoTo direction_, bool orMet_ = false, bool andParent_ = false)
StackFrameWithSet(execplan::ParseTree* node_, ParseTree::GoTo direction_, bool orMet_ = false,
bool andParent_ = false)
: node(node_), direction(direction_), orMet(orMet_), andParent(andParent_), localset({{}, {}})
{
}
@ -274,8 +275,7 @@ void deleteOneNode(execplan::ParseTree** node)
#if debug_rewrites
std::cerr << " Deleting: " << (*node)->data() << " " << boost::core::demangle(typeid(**node).name())
<< " "
<< "ptr: " << *node << std::endl;
<< " " << "ptr: " << *node << std::endl;
#endif
delete *node;
@ -397,7 +397,8 @@ void removeFromTreeIterative(execplan::ParseTree** root, const CommonContainer&
} // namespace details
void dumpTreeFiles(execplan::ParseTree* filters, const std::string& name, std::string dumpfolder = {})
void dumpTreeFiles([[maybe_unused]] execplan::ParseTree* filters, [[maybe_unused]] const std::string& name,
[[maybe_unused]] std::string dumpfolder = {})
{
#if debug_rewrites
messageqcpp::ByteStream beforetree;
@ -484,17 +485,18 @@ bool NodeSemanticComparator::operator()(execplan::ParseTree* left, execplan::Par
return left->data()->data() < right->data()->data();
}
bool checkFiltersLimit(execplan::ParseTree* tree, uint64_t limit)
{
uint64_t maxLimit = 0;
auto walker = [](const execplan::ParseTree* node, void* maxLimit){
auto walker = [](const execplan::ParseTree* node, void* maxLimit)
{
auto maybe_cf = dynamic_cast<ConstantFilter*>(node->data());
if (maybe_cf != nullptr && (maybe_cf->op()->op() == OpType::OP_OR || maybe_cf->op()->op() == OpType::OP_IN))
{
*((uint64_t*)maxLimit) = std::max(maybe_cf->filterList().size(), *((uint64_t*)maxLimit));
}
};
if (maybe_cf != nullptr &&
(maybe_cf->op()->op() == OpType::OP_OR || maybe_cf->op()->op() == OpType::OP_IN))
{
*((uint64_t*)maxLimit) = std::max(maybe_cf->filterList().size(), *((uint64_t*)maxLimit));
}
};
tree->walk(walker, &maxLimit);
return maxLimit <= limit;
}

2
dbcon/execplan/sessionmanager.cpp
View File

@ -49,7 +49,7 @@ SessionManager::SessionManager()
txnidFilename = conf->getConfig("SessionManager", "TxnIDFile");
}
SessionManager::SessionManager(bool nolock)
SessionManager::SessionManager(bool /*nolock*/)
{
config::Config* conf;
string stmp;

26
dbcon/execplan/treenode.h
View File

@ -267,18 +267,18 @@ class TreeNode
/***********************************************************************
* F&E framework *
***********************************************************************/
virtual const utils::NullString& getStrVal(rowgroup::Row& row, bool& isNull)
virtual const utils::NullString& getStrVal(rowgroup::Row& /*row*/, bool& isNull)
{
isNull = isNull ||
fResult.strVal
.isNull(); // XXX: NullString returns isNull, we should remove that parameter altogether.
return fResult.strVal;
}
virtual int64_t getIntVal(rowgroup::Row& row, bool& isNull)
virtual int64_t getIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.intVal;
}
virtual uint64_t getUintVal(rowgroup::Row& row, bool& isNull)
virtual uint64_t getUintVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.uintVal;
}
@ -294,43 +294,43 @@ class TreeNode
int64_t val = getIntVal(row, isNull);
return datatypes::TSInt64Null(val, isNull);
}
virtual float getFloatVal(rowgroup::Row& row, bool& isNull)
virtual float getFloatVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.floatVal;
}
virtual double getDoubleVal(rowgroup::Row& row, bool& isNull)
virtual double getDoubleVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.doubleVal;
}
virtual long double getLongDoubleVal(rowgroup::Row& row, bool& isNull)
virtual long double getLongDoubleVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.longDoubleVal;
}
virtual IDB_Decimal getDecimalVal(rowgroup::Row& row, bool& isNull)
virtual IDB_Decimal getDecimalVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.decimalVal;
}
virtual bool getBoolVal(rowgroup::Row& row, bool& isNull)
virtual bool getBoolVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.boolVal;
}
virtual int32_t getDateIntVal(rowgroup::Row& row, bool& isNull)
virtual int32_t getDateIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.intVal;
}
virtual int64_t getDatetimeIntVal(rowgroup::Row& row, bool& isNull)
virtual int64_t getDatetimeIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.intVal;
}
virtual int64_t getTimestampIntVal(rowgroup::Row& row, bool& isNull)
virtual int64_t getTimestampIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.intVal;
}
virtual int64_t getTimeIntVal(rowgroup::Row& row, bool& isNull)
virtual int64_t getTimeIntVal(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
return fResult.intVal;
}
virtual void evaluate(rowgroup::Row& row, bool& isNull)
virtual void evaluate(rowgroup::Row& /*row*/, bool& /*isNull*/)
{
}

4
dbcon/execplan/windowfunctioncolumn.h
View File

@ -168,12 +168,12 @@ class WindowFunctionColumn : public ReturnedColumn
WF_OrderBy fOrderBy; /// order by clause
// not support for window functions for now.
bool operator==(const TreeNode* t) const override
bool operator==(const TreeNode* /*t*/) const override
{
return false;
}
bool operator==(const WindowFunctionColumn& t) const;
bool operator!=(const TreeNode* t) const override
bool operator!=(const TreeNode* /*t*/) const override
{
return false;
}