From 9e9ac328794126fd1340fb6892256cdab101af18 Mon Sep 17 00:00:00 2001 From: Denis Khalikov Date: Tue, 10 Sep 2024 17:43:25 +0300 Subject: [PATCH] fix(logging): MCOL-5789 Add logs on failure. (#3307) --- versioning/BRM/dbrm.cpp | 6 +++++- versioning/BRM/masterdbrmnode.cpp | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/versioning/BRM/dbrm.cpp b/versioning/BRM/dbrm.cpp index 27e36067a..82d3eeba4 100644 --- a/versioning/BRM/dbrm.cpp +++ b/versioning/BRM/dbrm.cpp @@ -3198,7 +3198,11 @@ void DBRM::rolledback(TxnID& txnid) if (tmp != ERR_OK) { if (getSystemReady() != 0) - log("DBRM: error: SessionManager::rolledback() failed (valid error code)", logging::LOG_TYPE_ERROR); + { + std::stringstream errorStream; + errorStream << "DBRM: error: SessionManager::rolledback() failed (error code " << tmp << ")"; + log(errorStream.str(), logging::LOG_TYPE_ERROR); + } } } diff --git a/versioning/BRM/masterdbrmnode.cpp b/versioning/BRM/masterdbrmnode.cpp index 418a82c76..08b24a4ae 100644 --- a/versioning/BRM/masterdbrmnode.cpp +++ b/versioning/BRM/masterdbrmnode.cpp @@ -1633,8 +1633,12 @@ void MasterDBRMNode::doRolledBack(ByteStream& msg, ThreadParams* p) #endif sm.rolledback(txnid); } - catch (exception&) + catch (exception& ex) { + ostringstream errStream; + errStream << "doRolledBack() failed: " << ex.what(); + log(errStream.str()); + reply << (uint8_t)ERR_FAILURE; try