database/mariadb-columnstore-engine
1
0
Fork 0
mirror of https://github.com/mariadb-corporation/mariadb-columnstore-engine.git synced 2025-08-08 14:22:09 +03:00
Code Activity

MCOL-1579 Remove chmod of /dev/shm

Browse Source 
We appear to chmod /dev/shm as a workaround to a CentOS 7 bug that was
fixed last year which accidentally set it to 755. If a user has /dev/shm
locked down we should get them to fix it rather than modifying it
ourselves.

The code before this fixed changed a root install to 755 for /dev/shm
which instantly broke anything using mmap() with MAP_SHARED as an
unprivileged user.
This commit is contained in:
Andrew Hutchings
2018-07-23 10:40:18 +01:00
parent 49f124b61d
commit 979d00a679
3 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
oam/install_scripts/post-install
View File

@@ -247,7 +247,6 @@ else
$SUDO chmod 777 /tmp
$installdir/bin/syslogSetup.sh --installdir=$installdir install > /tmp/syslog_install.log 2>&1
$SUDO chown $user:$user $installdir/etc/Columnstore.xml
$SUDO chmod -R 777 /dev/shm
$SUDO mkdir /var/lock/subsys > /dev/null 2>&1
$SUDO chmod 777 /var/lock/subsys > /dev/null 2>&1
$SUDO rm -f /var/lock/subsys/mysql-Columnstore

7
procmon/main.cpp
View File

@@ -131,13 +131,6 @@ int main(int argc, char **argv)
if (p && *p)
USER = p;
// change permissions on /dev/shm
if ( !rootUser)
{
string cmd = "sudo chmod 777 /dev/shm >/dev/null 2>&1";
system(cmd.c_str());
}
// get and set locale language
string systemLang = "C";

7
procmon/processmonitor.cpp
View File

@@ -988,13 +988,6 @@ void ProcessMonitor::processMessage(messageqcpp::ByteStream msg, messageqcpp::IO
int requestStatus = oam::API_SUCCESS;
log.writeLog(__LINE__, "MSG RECEIVED: Start All process request...");
// change permissions on /dev/shm
string cmd = "chmod 755 /dev/shm >/dev/null 2>&1";
if ( !rootUser)
cmd = "sudo chmod 777 /dev/shm >/dev/null 2>&1";
system(cmd.c_str());
//start the mysqld daemon
try {
oam.actionMysqlCalpont(MYSQL_START);